From: Wolfram Sang <wsa@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Peter Rosin <peda@axentia.se>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] i2c: gpio: support write-only sda
Date: Fri, 20 Jan 2023 11:27:27 +0100 [thread overview]
Message-ID: <Y8psjzVeuZ+hOwMo@ninjato> (raw)
In-Reply-To: <6f4b54d9-ab6d-a4d4-5142-27c89e03c6d2@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
Hi Heiner,
On Wed, Jan 18, 2023 at 10:49:48PM +0100, Heiner Kallweit wrote:
> There are slave devices that understand I2C but have read-only SDA and
> SCL. Examples are FD650 7-segment LED controller and its derivatives.
> Typical board designs don't even have a pull-up for both pins.
> Therefore add properties for not using open-drain. For write-only SCL
> we have a property already, add one for write-only SDA.
The code looks good to me. I am just waiting for an ack on the bindings.
Thanks a lot for keeping at it!
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-01-20 10:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 21:49 [PATCH v5 0/3] i2c: gpio: support write-only sda Heiner Kallweit
2023-01-18 21:51 ` [PATCH v5 1/3] dt-bindings: i2c-gpio: Add properties for dealing with write-only SDA/SCL w/o pullup Heiner Kallweit
2023-01-23 21:08 ` Rob Herring
2023-01-23 22:20 ` Wolfram Sang
2023-01-18 21:54 ` [PATCH v5 2/3] i2c: algo: bit: allow getsda to be NULL Heiner Kallweit
2023-01-23 22:20 ` Wolfram Sang
2023-01-18 21:55 ` [PATCH v5 3/3] i2c: gpio: support write-only sda/scl w/o pull-up Heiner Kallweit
2023-01-23 22:21 ` Wolfram Sang
2023-01-20 10:27 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8psjzVeuZ+hOwMo@ninjato \
--to=wsa@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.