From: Nathan Chancellor <nathan@kernel.org>
To: Jocelyn Falempe <jfalempe@redhat.com>
Cc: llvm@lists.linux.dev, Kees Cook <keescook@chromium.org>,
Tom Rix <trix@redhat.com>,
intel-gfx@lists.freedesktop.org,
Nick Desaulniers <ndesaulniers@google.com>,
patches@lists.linux.dev, Sami Tolvanen <samitolvanen@google.com>,
dri-devel@lists.freedesktop.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs
Date: Thu, 12 Jan 2023 08:56:57 -0700 [thread overview]
Message-ID: <Y8Atycuni0bl8std@dev-arch.thelio-3990X> (raw)
In-Reply-To: <4dcf830e-62a5-837b-7590-ac5395f84c14@redhat.com>
Hi Jocelyn,
On Thu, Jan 12, 2023 at 11:08:17AM +0100, Jocelyn Falempe wrote:
> This patch does also solve a kernel crash when reading
> /sys/class/drm/card1/gt/gt0/* on a skylake machine:
> https://bugzilla.redhat.com/show_bug.cgi?id=2154880
Interesting, I wonder what aspect of this patch fixes this because I am
not sure that is an intended consequence of this change but that is
still good to hear!
For the record, this is commit a8a4f0467d70 ("drm/i915: Fix CFI
violations in gt_sysfs") in mainline.
> Do you think it can be backported to stable releases ?
> Conflicts are trivial on top of v6.0 at least.
I had a report from another user of this crash affecting them with kCFI
so it is on my TODO to backport it to 6.1 (6.0 just went EOL) but I am
currently out of the office until next Wednesday so I won't be able to
get to it until then (as I would like to test the backport on affected
hardware). If someone wants to beat me to it, I won't complain ;)
Cheers,
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Jocelyn Falempe <jfalempe@redhat.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Kees Cook <keescook@chromium.org>, Tom Rix <trix@redhat.com>,
intel-gfx@lists.freedesktop.org, llvm@lists.linux.dev,
Nick Desaulniers <ndesaulniers@google.com>,
patches@lists.linux.dev, dri-devel@lists.freedesktop.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Sami Tolvanen <samitolvanen@google.com>,
Andi Shyti <andi.shyti@linux.intel.com>
Subject: Re: [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs
Date: Thu, 12 Jan 2023 08:56:57 -0700 [thread overview]
Message-ID: <Y8Atycuni0bl8std@dev-arch.thelio-3990X> (raw)
In-Reply-To: <4dcf830e-62a5-837b-7590-ac5395f84c14@redhat.com>
Hi Jocelyn,
On Thu, Jan 12, 2023 at 11:08:17AM +0100, Jocelyn Falempe wrote:
> This patch does also solve a kernel crash when reading
> /sys/class/drm/card1/gt/gt0/* on a skylake machine:
> https://bugzilla.redhat.com/show_bug.cgi?id=2154880
Interesting, I wonder what aspect of this patch fixes this because I am
not sure that is an intended consequence of this change but that is
still good to hear!
For the record, this is commit a8a4f0467d70 ("drm/i915: Fix CFI
violations in gt_sysfs") in mainline.
> Do you think it can be backported to stable releases ?
> Conflicts are trivial on top of v6.0 at least.
I had a report from another user of this crash affecting them with kCFI
so it is on my TODO to backport it to 6.1 (6.0 just went EOL) but I am
currently out of the office until next Wednesday so I won't be able to
get to it until then (as I would like to test the backport on affected
hardware). If someone wants to beat me to it, I won't complain ;)
Cheers,
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Jocelyn Falempe <jfalempe@redhat.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
llvm@lists.linux.dev, Kees Cook <keescook@chromium.org>,
Andi Shyti <andi.shyti@linux.intel.com>,
Tom Rix <trix@redhat.com>,
intel-gfx@lists.freedesktop.org,
Nick Desaulniers <ndesaulniers@google.com>,
patches@lists.linux.dev, Sami Tolvanen <samitolvanen@google.com>,
dri-devel@lists.freedesktop.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs
Date: Thu, 12 Jan 2023 08:56:57 -0700 [thread overview]
Message-ID: <Y8Atycuni0bl8std@dev-arch.thelio-3990X> (raw)
In-Reply-To: <4dcf830e-62a5-837b-7590-ac5395f84c14@redhat.com>
Hi Jocelyn,
On Thu, Jan 12, 2023 at 11:08:17AM +0100, Jocelyn Falempe wrote:
> This patch does also solve a kernel crash when reading
> /sys/class/drm/card1/gt/gt0/* on a skylake machine:
> https://bugzilla.redhat.com/show_bug.cgi?id=2154880
Interesting, I wonder what aspect of this patch fixes this because I am
not sure that is an intended consequence of this change but that is
still good to hear!
For the record, this is commit a8a4f0467d70 ("drm/i915: Fix CFI
violations in gt_sysfs") in mainline.
> Do you think it can be backported to stable releases ?
> Conflicts are trivial on top of v6.0 at least.
I had a report from another user of this crash affecting them with kCFI
so it is on my TODO to backport it to 6.1 (6.0 just went EOL) but I am
currently out of the office until next Wednesday so I won't be able to
get to it until then (as I would like to test the backport on affected
hardware). If someone wants to beat me to it, I won't complain ;)
Cheers,
Nathan
next prev parent reply other threads:[~2023-01-12 15:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 20:59 [Intel-gfx] [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs Nathan Chancellor
2022-10-13 20:59 ` Nathan Chancellor
2022-10-13 20:59 ` Nathan Chancellor
2022-10-13 22:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix CFI violations in gt_sysfs (rev3) Patchwork
2022-10-13 22:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-14 3:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-18 18:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix CFI violations in gt_sysfs (rev4) Patchwork
2022-10-18 18:32 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-10-27 17:17 ` [Intel-gfx] [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs Andi Shyti
2022-10-27 17:17 ` Andi Shyti
2022-10-27 17:17 ` Andi Shyti
2023-01-12 10:08 ` [Intel-gfx] " Jocelyn Falempe
2023-01-12 10:08 ` Jocelyn Falempe
2023-01-12 10:08 ` Jocelyn Falempe
2023-01-12 15:56 ` Nathan Chancellor [this message]
2023-01-12 15:56 ` Nathan Chancellor
2023-01-12 15:56 ` Nathan Chancellor
2023-01-13 8:03 ` [Intel-gfx] " Jocelyn Falempe
2023-01-13 8:03 ` Jocelyn Falempe
2023-01-13 8:03 ` Jocelyn Falempe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8Atycuni0bl8std@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jfalempe@redhat.com \
--cc=keescook@chromium.org \
--cc=llvm@lists.linux.dev \
--cc=ndesaulniers@google.com \
--cc=patches@lists.linux.dev \
--cc=rodrigo.vivi@intel.com \
--cc=samitolvanen@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.