All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: f.fainelli@gmail.com, amd-gfx@lists.freedesktop.org,
	liviu.dudau@arm.com, dri-devel@lists.freedesktop.org,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	thierry.reding@gmail.com, james.qian.wang@arm.com,
	patrik.r.jakobsson@gmail.com, daniel@ffwll.ch,
	alexander.deucher@amd.com, bcm-kernel-feedback-list@broadcom.com,
	airlied@gmail.com, christian.koenig@amd.com,
	linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2 05/10] drm/panel: Do not include <linux/fb.h>
Date: Fri, 13 Jan 2023 16:12:27 +0100	[thread overview]
Message-ID: <Y8F021QdBYD9IEvD@ravnborg.org> (raw)
In-Reply-To: <20230111130206.29974-6-tzimmermann@suse.de>

On Wed, Jan 11, 2023 at 02:02:01PM +0100, Thomas Zimmermann wrote:
> Remove unnecessary include statements for <linux/fb.h>. No functional
> changes. Include <linux/of.h> where the driver got the header file via
> <linux/fb.h>.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  drivers/gpu/drm/panel/panel-ilitek-ili9881c.c         | 1 -
>  drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 -
>  drivers/gpu/drm/panel/panel-ronbo-rb070d30.c          | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index cbb68caa36f2..1ec696adf9de 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> @@ -7,7 +7,6 @@
>  #include <linux/device.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
> -#include <linux/fb.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/of_device.h>
> diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> index 79f852465a84..35d568da342f 100644
> --- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> +++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> @@ -43,7 +43,6 @@
>  
>  #include <linux/delay.h>
>  #include <linux/err.h>
> -#include <linux/fb.h>
>  #include <linux/i2c.h>
>  #include <linux/media-bus-format.h>
>  #include <linux/module.h>
> diff --git a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
> index 866d1bf5530e..2ef5ea5eaeeb 100644
> --- a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
> +++ b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
> @@ -11,7 +11,6 @@
>  #include <linux/device.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
> -#include <linux/fb.h>
>  #include <linux/kernel.h>
>  #include <linux/media-bus-format.h>
>  #include <linux/module.h>
> -- 
> 2.39.0

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: alexander.deucher@amd.com, christian.koenig@amd.com,
	airlied@gmail.com, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	patrik.r.jakobsson@gmail.com, thierry.reding@gmail.com,
	f.fainelli@gmail.com, james.qian.wang@arm.com,
	liviu.dudau@arm.com, dri-devel@lists.freedesktop.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 05/10] drm/panel: Do not include <linux/fb.h>
Date: Fri, 13 Jan 2023 16:12:27 +0100	[thread overview]
Message-ID: <Y8F021QdBYD9IEvD@ravnborg.org> (raw)
In-Reply-To: <20230111130206.29974-6-tzimmermann@suse.de>

On Wed, Jan 11, 2023 at 02:02:01PM +0100, Thomas Zimmermann wrote:
> Remove unnecessary include statements for <linux/fb.h>. No functional
> changes. Include <linux/of.h> where the driver got the header file via
> <linux/fb.h>.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  drivers/gpu/drm/panel/panel-ilitek-ili9881c.c         | 1 -
>  drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 -
>  drivers/gpu/drm/panel/panel-ronbo-rb070d30.c          | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index cbb68caa36f2..1ec696adf9de 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> @@ -7,7 +7,6 @@
>  #include <linux/device.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
> -#include <linux/fb.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/of_device.h>
> diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> index 79f852465a84..35d568da342f 100644
> --- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> +++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> @@ -43,7 +43,6 @@
>  
>  #include <linux/delay.h>
>  #include <linux/err.h>
> -#include <linux/fb.h>
>  #include <linux/i2c.h>
>  #include <linux/media-bus-format.h>
>  #include <linux/module.h>
> diff --git a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
> index 866d1bf5530e..2ef5ea5eaeeb 100644
> --- a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
> +++ b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
> @@ -11,7 +11,6 @@
>  #include <linux/device.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
> -#include <linux/fb.h>
>  #include <linux/kernel.h>
>  #include <linux/media-bus-format.h>
>  #include <linux/module.h>
> -- 
> 2.39.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: f.fainelli@gmail.com, amd-gfx@lists.freedesktop.org,
	liviu.dudau@arm.com, dri-devel@lists.freedesktop.org,
	thierry.reding@gmail.com, james.qian.wang@arm.com,
	alexander.deucher@amd.com, bcm-kernel-feedback-list@broadcom.com,
	christian.koenig@amd.com, linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2 05/10] drm/panel: Do not include <linux/fb.h>
Date: Fri, 13 Jan 2023 16:12:27 +0100	[thread overview]
Message-ID: <Y8F021QdBYD9IEvD@ravnborg.org> (raw)
In-Reply-To: <20230111130206.29974-6-tzimmermann@suse.de>

On Wed, Jan 11, 2023 at 02:02:01PM +0100, Thomas Zimmermann wrote:
> Remove unnecessary include statements for <linux/fb.h>. No functional
> changes. Include <linux/of.h> where the driver got the header file via
> <linux/fb.h>.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  drivers/gpu/drm/panel/panel-ilitek-ili9881c.c         | 1 -
>  drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 -
>  drivers/gpu/drm/panel/panel-ronbo-rb070d30.c          | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index cbb68caa36f2..1ec696adf9de 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> @@ -7,7 +7,6 @@
>  #include <linux/device.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
> -#include <linux/fb.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/of_device.h>
> diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> index 79f852465a84..35d568da342f 100644
> --- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> +++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> @@ -43,7 +43,6 @@
>  
>  #include <linux/delay.h>
>  #include <linux/err.h>
> -#include <linux/fb.h>
>  #include <linux/i2c.h>
>  #include <linux/media-bus-format.h>
>  #include <linux/module.h>
> diff --git a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
> index 866d1bf5530e..2ef5ea5eaeeb 100644
> --- a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
> +++ b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
> @@ -11,7 +11,6 @@
>  #include <linux/device.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
> -#include <linux/fb.h>
>  #include <linux/kernel.h>
>  #include <linux/media-bus-format.h>
>  #include <linux/module.h>
> -- 
> 2.39.0

  reply	other threads:[~2023-01-13 15:28 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 13:01 [PATCH v2 00/10] drm: Do not include <linux/fb.h> unnecessarily Thomas Zimmermann
2023-01-11 13:01 ` Thomas Zimmermann
2023-01-11 13:01 ` [PATCH v2 01/10] drm: Include <linux/backlight.h> where needed Thomas Zimmermann
2023-01-11 13:01   ` Thomas Zimmermann
2023-01-13 15:09   ` Sam Ravnborg
2023-01-13 15:09     ` Sam Ravnborg
2023-01-13 15:09     ` Sam Ravnborg
2023-01-13 15:38     ` Thomas Zimmermann
2023-01-13 15:38       ` Thomas Zimmermann
2023-01-11 13:01 ` [PATCH v2 02/10] drm: Include <linux/of.h> " Thomas Zimmermann
2023-01-11 13:01   ` Thomas Zimmermann
2023-01-11 13:15   ` Liviu Dudau
2023-01-11 13:15     ` Liviu Dudau
2023-01-11 13:15     ` Liviu Dudau
2023-01-11 16:08   ` Ville Syrjälä
2023-01-11 16:08     ` Ville Syrjälä
2023-01-11 16:08     ` Ville Syrjälä
2023-01-13 15:11     ` Sam Ravnborg
2023-01-13 15:11       ` Sam Ravnborg
2023-01-13 15:11       ` Sam Ravnborg
2023-01-13 15:47       ` Ville Syrjälä
2023-01-13 15:47         ` Ville Syrjälä
2023-01-13 15:47         ` Ville Syrjälä
2023-01-11 13:01 ` [PATCH v2 03/10] drm: Don't include <linux/fb.h> in drm_crtc_helper.h Thomas Zimmermann
2023-01-11 13:01   ` Thomas Zimmermann
2023-01-11 16:03   ` Ville Syrjälä
2023-01-11 16:03     ` Ville Syrjälä
2023-01-11 16:03     ` Ville Syrjälä
2023-01-11 13:02 ` [PATCH v2 04/10] drm/amdgpu: Do not include <linux/fb.h> Thomas Zimmermann
2023-01-11 13:02   ` Thomas Zimmermann
2023-01-11 13:02 ` [PATCH v2 05/10] drm/panel: " Thomas Zimmermann
2023-01-11 13:02   ` Thomas Zimmermann
2023-01-13 15:12   ` Sam Ravnborg [this message]
2023-01-13 15:12     ` Sam Ravnborg
2023-01-13 15:12     ` Sam Ravnborg
2023-01-11 13:02 ` [PATCH v2 06/10] drm: Define enum mode_set_atomic in drm_modeset_helper_tables.h Thomas Zimmermann
2023-01-11 13:02   ` Thomas Zimmermann
2023-01-11 16:03   ` Ville Syrjälä
2023-01-11 16:03     ` Ville Syrjälä
2023-01-11 16:03     ` Ville Syrjälä
2023-01-11 13:02 ` [PATCH v2 07/10] drm/amdgpu: Do not include <drm/drm_fb_helper.h> Thomas Zimmermann
2023-01-11 13:02   ` Thomas Zimmermann
2023-01-11 13:21   ` Christian König
2023-01-11 13:21     ` Christian König
2023-01-11 13:34     ` Thomas Zimmermann
2023-01-11 13:34       ` Thomas Zimmermann
2023-01-11 13:02 ` [PATCH v2 08/10] drm/nouveau: " Thomas Zimmermann
2023-01-11 13:02   ` Thomas Zimmermann
2023-01-11 13:02 ` [PATCH v2 09/10] drm/radeon: Remove trailing whitespaces Thomas Zimmermann
2023-01-11 13:02   ` Thomas Zimmermann
2023-01-11 13:02 ` [PATCH v2 10/10] drm/radeon: Do not include <drm/drm_fb_helper.h> Thomas Zimmermann
2023-01-11 13:02   ` Thomas Zimmermann
2023-01-13 15:14 ` [PATCH v2 00/10] drm: Do not include <linux/fb.h> unnecessarily Sam Ravnborg
2023-01-13 15:14   ` Sam Ravnborg
2023-01-13 15:14   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8F021QdBYD9IEvD@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=f.fainelli@gmail.com \
    --cc=james.qian.wang@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=liviu.dudau@arm.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=patrik.r.jakobsson@gmail.com \
    --cc=thierry.reding@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.