All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Saurabh Singh Sengar <ssengar@microsoft.com>,
	Praveen Kumar <kumarpraveen@linux.microsoft.com>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
	David Airlie <airlied@gmail.com>
Subject: Re: [Intel-gfx] [PATCH v3 0/2] drm/i915: Avoid full proxy f_ops debug attributes
Date: Fri, 13 Jan 2023 14:05:58 -0500	[thread overview]
Message-ID: <Y8Grli/Ie01RvDBR@intel.com> (raw)
In-Reply-To: <cover.1673451705.git.drv@mailo.com>

On Wed, Jan 11, 2023 at 09:20:40PM +0530, Deepak R Varma wrote:
> This patch series proposes to replace a combination of DEFINE_SIMPLE_ATTRIBUTE() +
> debugfs_create_file() by a combination of DEFINE_DEBUGFS_ATTRIBUTE() +
> debugfs_create_file_unsafe(). The change reduced overhead in terms of managing
> the full proxy f_ops at runtime. The patches 1 & 2 covers for the DRRS and FBC
> f_ops debugfs attributes respectively.
> 
> Following coccicheck make command helped identify this change:
> 
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

pushed both patches to drm-intel-next. Thanks for the patches.

> 
> Changes in v3:
>    Patch 1/2: fix checkpatch function parameter alignment complaint
>    Patch 2/2: None
> 
> Changes in v2:
>    - Individual patches clubbed in patch set
>    - Update patch log message to include coccicheck make command
> 
> 
> Deepak R Varma (2):
>   drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes
>   drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes
> 
>  drivers/gpu/drm/i915/display/intel_drrs.c |  8 ++++----
>  drivers/gpu/drm/i915/display/intel_fbc.c  | 12 ++++++------
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Saurabh Singh Sengar <ssengar@microsoft.com>,
	Praveen Kumar <kumarpraveen@linux.microsoft.com>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 0/2] drm/i915: Avoid full proxy f_ops debug attributes
Date: Fri, 13 Jan 2023 14:05:58 -0500	[thread overview]
Message-ID: <Y8Grli/Ie01RvDBR@intel.com> (raw)
In-Reply-To: <cover.1673451705.git.drv@mailo.com>

On Wed, Jan 11, 2023 at 09:20:40PM +0530, Deepak R Varma wrote:
> This patch series proposes to replace a combination of DEFINE_SIMPLE_ATTRIBUTE() +
> debugfs_create_file() by a combination of DEFINE_DEBUGFS_ATTRIBUTE() +
> debugfs_create_file_unsafe(). The change reduced overhead in terms of managing
> the full proxy f_ops at runtime. The patches 1 & 2 covers for the DRRS and FBC
> f_ops debugfs attributes respectively.
> 
> Following coccicheck make command helped identify this change:
> 
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

pushed both patches to drm-intel-next. Thanks for the patches.

> 
> Changes in v3:
>    Patch 1/2: fix checkpatch function parameter alignment complaint
>    Patch 2/2: None
> 
> Changes in v2:
>    - Individual patches clubbed in patch set
>    - Update patch log message to include coccicheck make command
> 
> 
> Deepak R Varma (2):
>   drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes
>   drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes
> 
>  drivers/gpu/drm/i915/display/intel_drrs.c |  8 ++++----
>  drivers/gpu/drm/i915/display/intel_fbc.c  | 12 ++++++------
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	David Airlie <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	<intel-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	"Saurabh Singh Sengar" <ssengar@microsoft.com>,
	Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH v3 0/2] drm/i915: Avoid full proxy f_ops debug attributes
Date: Fri, 13 Jan 2023 14:05:58 -0500	[thread overview]
Message-ID: <Y8Grli/Ie01RvDBR@intel.com> (raw)
In-Reply-To: <cover.1673451705.git.drv@mailo.com>

On Wed, Jan 11, 2023 at 09:20:40PM +0530, Deepak R Varma wrote:
> This patch series proposes to replace a combination of DEFINE_SIMPLE_ATTRIBUTE() +
> debugfs_create_file() by a combination of DEFINE_DEBUGFS_ATTRIBUTE() +
> debugfs_create_file_unsafe(). The change reduced overhead in terms of managing
> the full proxy f_ops at runtime. The patches 1 & 2 covers for the DRRS and FBC
> f_ops debugfs attributes respectively.
> 
> Following coccicheck make command helped identify this change:
> 
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

pushed both patches to drm-intel-next. Thanks for the patches.

> 
> Changes in v3:
>    Patch 1/2: fix checkpatch function parameter alignment complaint
>    Patch 2/2: None
> 
> Changes in v2:
>    - Individual patches clubbed in patch set
>    - Update patch log message to include coccicheck make command
> 
> 
> Deepak R Varma (2):
>   drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes
>   drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes
> 
>  drivers/gpu/drm/i915/display/intel_drrs.c |  8 ++++----
>  drivers/gpu/drm/i915/display/intel_fbc.c  | 12 ++++++------
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> 

  parent reply	other threads:[~2023-01-13 19:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 15:50 [Intel-gfx] [PATCH v3 0/2] drm/i915: Avoid full proxy f_ops debug attributes Deepak R Varma
2023-01-11 15:50 ` Deepak R Varma
2023-01-11 15:50 ` Deepak R Varma
2023-01-11 15:51 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/display: Avoid full proxy f_ops for DRRS " Deepak R Varma
2023-01-11 15:51   ` Deepak R Varma
2023-01-11 15:51   ` Deepak R Varma
2023-01-11 15:51 ` [Intel-gfx] [PATCH v3 2/2] drm/i915/fbc: Avoid full proxy f_ops for FBC " Deepak R Varma
2023-01-11 15:51   ` Deepak R Varma
2023-01-11 15:51   ` Deepak R Varma
2023-01-11 16:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Avoid full proxy f_ops debug attributes (rev2) Patchwork
2023-01-11 17:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-11 23:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-01-13 19:05 ` Rodrigo Vivi [this message]
2023-01-13 19:05   ` [PATCH v3 0/2] drm/i915: Avoid full proxy f_ops debug attributes Rodrigo Vivi
2023-01-13 19:05   ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8Grli/Ie01RvDBR@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=drv@mailo.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kumarpraveen@linux.microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ssengar@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.