From: Mark Brown <broonie@kernel.org>
To: Jarrah Gosbell <kernel@undef.tools>
Cc: Oder Chiou <oder_chiou@realtek.com>,
alsa-devel@alsa-project.org, phone-devel@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Ondrej Jirman <megi@xff.cz>
Subject: Re: [PATCH] ASoC: codec: rt5640: Resolve failure to set DMIC clock after playback
Date: Sat, 14 Jan 2023 17:25:48 +0000 [thread overview]
Message-ID: <Y8LlnIbvnLGERCNo@sirena.org.uk> (raw)
In-Reply-To: <20230114003053.401274-1-kernel@undef.tools>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Sat, Jan 14, 2023 at 12:30:54AM +0000, Jarrah Gosbell wrote:
> rt5640_set_dai_sysclk is called with freq == 0 when playback stops. This
> causes DMIC setup code to fail. I2S interface doesn't need to be active
> for codec to work, so don't clear rt5640->sysclk after
> rt5640_set_dai_sysclk is called with freq == 0.
The goal with set_sysclk() is to record the current clock
frequency, if the clock is stopped it should be set to zero. If
a machine driver is setting the input clock to zero when it's
still being provided then it should be fixed. If the device
doesn't need a clock for DMIC (which seems dubious) then whatever
is checking for a clock should be fixed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jarrah Gosbell <kernel@undef.tools>
Cc: Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org, Ondrej Jirman <megi@xff.cz>
Subject: Re: [PATCH] ASoC: codec: rt5640: Resolve failure to set DMIC clock after playback
Date: Sat, 14 Jan 2023 17:25:48 +0000 [thread overview]
Message-ID: <Y8LlnIbvnLGERCNo@sirena.org.uk> (raw)
In-Reply-To: <20230114003053.401274-1-kernel@undef.tools>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Sat, Jan 14, 2023 at 12:30:54AM +0000, Jarrah Gosbell wrote:
> rt5640_set_dai_sysclk is called with freq == 0 when playback stops. This
> causes DMIC setup code to fail. I2S interface doesn't need to be active
> for codec to work, so don't clear rt5640->sysclk after
> rt5640_set_dai_sysclk is called with freq == 0.
The goal with set_sysclk() is to record the current clock
frequency, if the clock is stopped it should be set to zero. If
a machine driver is setting the input clock to zero when it's
still being provided then it should be fixed. If the device
doesn't need a clock for DMIC (which seems dubious) then whatever
is checking for a clock should be fixed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-14 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 0:30 [PATCH] ASoC: codec: rt5640: Resolve failure to set DMIC clock after playback Jarrah Gosbell
2023-01-14 0:30 ` Jarrah Gosbell
2023-01-14 17:25 ` Mark Brown [this message]
2023-01-14 17:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8LlnIbvnLGERCNo@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kernel@undef.tools \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=megi@xff.cz \
--cc=oder_chiou@realtek.com \
--cc=phone-devel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.