From: Andrew Lunn <andrew@lunn.ch>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>,
Wong Vee Khee <vee.khee.wong@linux.intel.com>
Subject: Re: [PATCH net v1] net: stmmac: Fix queue statistics reading
Date: Sun, 15 Jan 2023 17:48:10 +0100 [thread overview]
Message-ID: <Y8QuSiFkIyRv1Lqf@lunn.ch> (raw)
In-Reply-To: <87fsccvy2o.fsf@kurt>
On Sun, Jan 15, 2023 at 12:25:51PM +0100, Kurt Kanzenbach wrote:
> Hi Andrew,
>
> On Sat Jan 14 2023, Andrew Lunn wrote:
> > On Sat, Jan 14, 2023 at 01:04:37PM +0100, Kurt Kanzenbach wrote:
> >> Correct queue statistics reading. All queue statistics are stored as unsigned
> >> long values. The retrieval for ethtool fetches these values as u64. However, on
> >> some systems the size of the counters are 32 bit.
> >
> >> @@ -551,16 +551,16 @@ static void stmmac_get_per_qstats(struct stmmac_priv *priv, u64 *data)
> >> p = (char *)priv + offsetof(struct stmmac_priv,
> >> xstats.txq_stats[q].tx_pkt_n);
> >> for (stat = 0; stat < STMMAC_TXQ_STATS; stat++) {
> >> - *data++ = (*(u64 *)p);
> >> - p += sizeof(u64 *);
> >> + *data++ = (*(unsigned long *)p);
> >> + p += sizeof(unsigned long);
> >
> > As you said in the comment, the register is 32 bits.
>
> Maybe the commit message is a bit misleading. There are no registers
> involved here.
Ah!
In that case, yes, unsigned long. Maybe reword the commit message to
mention the values are being read from struct stmmac_txq_stats and
struct stmmac_rxq_stats which use unsigned long. That would avoid my
confusion of thinking it is being read from a register.
With that change made, you can add my Reviewed-by.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>,
Wong Vee Khee <vee.khee.wong@linux.intel.com>
Subject: Re: [PATCH net v1] net: stmmac: Fix queue statistics reading
Date: Sun, 15 Jan 2023 17:48:10 +0100 [thread overview]
Message-ID: <Y8QuSiFkIyRv1Lqf@lunn.ch> (raw)
In-Reply-To: <87fsccvy2o.fsf@kurt>
On Sun, Jan 15, 2023 at 12:25:51PM +0100, Kurt Kanzenbach wrote:
> Hi Andrew,
>
> On Sat Jan 14 2023, Andrew Lunn wrote:
> > On Sat, Jan 14, 2023 at 01:04:37PM +0100, Kurt Kanzenbach wrote:
> >> Correct queue statistics reading. All queue statistics are stored as unsigned
> >> long values. The retrieval for ethtool fetches these values as u64. However, on
> >> some systems the size of the counters are 32 bit.
> >
> >> @@ -551,16 +551,16 @@ static void stmmac_get_per_qstats(struct stmmac_priv *priv, u64 *data)
> >> p = (char *)priv + offsetof(struct stmmac_priv,
> >> xstats.txq_stats[q].tx_pkt_n);
> >> for (stat = 0; stat < STMMAC_TXQ_STATS; stat++) {
> >> - *data++ = (*(u64 *)p);
> >> - p += sizeof(u64 *);
> >> + *data++ = (*(unsigned long *)p);
> >> + p += sizeof(unsigned long);
> >
> > As you said in the comment, the register is 32 bits.
>
> Maybe the commit message is a bit misleading. There are no registers
> involved here.
Ah!
In that case, yes, unsigned long. Maybe reword the commit message to
mention the values are being read from struct stmmac_txq_stats and
struct stmmac_rxq_stats which use unsigned long. That would avoid my
confusion of thinking it is being read from a register.
With that change made, you can add my Reviewed-by.
Andrew
next prev parent reply other threads:[~2023-01-15 16:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 12:04 [PATCH net v1] net: stmmac: Fix queue statistics reading Kurt Kanzenbach
2023-01-14 12:04 ` Kurt Kanzenbach
2023-01-14 15:10 ` Andrew Lunn
2023-01-14 15:10 ` Andrew Lunn
2023-01-15 11:25 ` Kurt Kanzenbach
2023-01-15 11:25 ` Kurt Kanzenbach
2023-01-15 16:48 ` Andrew Lunn [this message]
2023-01-15 16:48 ` Andrew Lunn
2023-01-16 13:20 ` patchwork-bot+netdevbpf
2023-01-16 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8QuSiFkIyRv1Lqf@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=vee.khee.wong@linux.intel.com \
--cc=vijayakannan.ayyathurai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.