From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions
Date: Sun, 15 Jan 2023 17:57:55 +0100 [thread overview]
Message-ID: <Y8Qwk5H8Yd7qiN0j@lunn.ch> (raw)
In-Reply-To: <d75ef7df-a645-7fdd-491a-f89f70dbea01@gmail.com>
On Sun, Jan 15, 2023 at 04:19:37PM +0100, Heiner Kallweit wrote:
> On my SC2-based system the genphy driver was used because the PHY
> identifies as 0x01803300. It works normal with the meson g12a
> driver after this change.
> Switch to PHY_ID_MATCH_MODEL to cover the different sub-versions.
Hi Heiner
Are there any datasheets for these devices? Anything which documents
the lower nibble really is a revision?
I'm just trying to avoid future problems where we find it is actually
a different PHY, needs its own MATCH_EXACT entry, and then we find we
break devices using 0x01803302 which we had no idea exists, but got
covered by this change.
Andrew
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions
Date: Sun, 15 Jan 2023 17:57:55 +0100 [thread overview]
Message-ID: <Y8Qwk5H8Yd7qiN0j@lunn.ch> (raw)
In-Reply-To: <d75ef7df-a645-7fdd-491a-f89f70dbea01@gmail.com>
On Sun, Jan 15, 2023 at 04:19:37PM +0100, Heiner Kallweit wrote:
> On my SC2-based system the genphy driver was used because the PHY
> identifies as 0x01803300. It works normal with the meson g12a
> driver after this change.
> Switch to PHY_ID_MATCH_MODEL to cover the different sub-versions.
Hi Heiner
Are there any datasheets for these devices? Anything which documents
the lower nibble really is a revision?
I'm just trying to avoid future problems where we find it is actually
a different PHY, needs its own MATCH_EXACT entry, and then we find we
break devices using 0x01803302 which we had no idea exists, but got
covered by this change.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions
Date: Sun, 15 Jan 2023 17:57:55 +0100 [thread overview]
Message-ID: <Y8Qwk5H8Yd7qiN0j@lunn.ch> (raw)
In-Reply-To: <d75ef7df-a645-7fdd-491a-f89f70dbea01@gmail.com>
On Sun, Jan 15, 2023 at 04:19:37PM +0100, Heiner Kallweit wrote:
> On my SC2-based system the genphy driver was used because the PHY
> identifies as 0x01803300. It works normal with the meson g12a
> driver after this change.
> Switch to PHY_ID_MATCH_MODEL to cover the different sub-versions.
Hi Heiner
Are there any datasheets for these devices? Anything which documents
the lower nibble really is a revision?
I'm just trying to avoid future problems where we find it is actually
a different PHY, needs its own MATCH_EXACT entry, and then we find we
break devices using 0x01803302 which we had no idea exists, but got
covered by this change.
Andrew
next prev parent reply other threads:[~2023-01-15 16:58 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 15:19 [PATCH net-next] net: phy: meson-gxl: support more G12A-internal PHY versions Heiner Kallweit
2023-01-15 15:19 ` Heiner Kallweit
2023-01-15 15:19 ` Heiner Kallweit
2023-01-15 16:57 ` Andrew Lunn [this message]
2023-01-15 16:57 ` Andrew Lunn
2023-01-15 16:57 ` Andrew Lunn
2023-01-15 17:09 ` Heiner Kallweit
2023-01-15 17:09 ` Heiner Kallweit
2023-01-15 17:09 ` Heiner Kallweit
2023-01-15 18:43 ` Neil Armstrong
2023-01-15 18:43 ` Neil Armstrong
2023-01-15 18:43 ` Neil Armstrong
2023-01-15 19:42 ` Anand Moon
2023-01-15 19:42 ` Anand Moon
2023-01-15 19:42 ` Anand Moon
2023-01-15 20:38 ` Heiner Kallweit
2023-01-15 20:38 ` Heiner Kallweit
2023-01-15 20:38 ` Heiner Kallweit
2023-01-17 12:04 ` Paolo Abeni
2023-01-17 12:04 ` Paolo Abeni
2023-01-17 12:04 ` Paolo Abeni
2023-01-17 13:30 ` Andrew Lunn
2023-01-17 13:30 ` Andrew Lunn
2023-01-17 13:30 ` Andrew Lunn
2023-01-17 14:51 ` Heiner Kallweit
2023-01-17 14:51 ` Heiner Kallweit
2023-01-17 14:51 ` Heiner Kallweit
2023-01-20 9:55 ` Jerome Brunet
2023-01-20 9:55 ` Jerome Brunet
2023-01-20 9:55 ` Jerome Brunet
2023-01-19 22:42 ` Heiner Kallweit
2023-01-19 22:42 ` Heiner Kallweit
2023-01-19 22:42 ` Heiner Kallweit
2023-01-20 10:01 ` Jerome Brunet
2023-01-20 10:01 ` Jerome Brunet
2023-01-20 10:01 ` Jerome Brunet
2023-01-20 10:22 ` Heiner Kallweit
2023-01-20 10:22 ` Heiner Kallweit
2023-01-20 10:22 ` Heiner Kallweit
2023-01-20 10:52 ` Heiner Kallweit
2023-01-20 10:52 ` Heiner Kallweit
2023-01-20 10:52 ` Heiner Kallweit
2023-01-20 12:48 ` Jerome Brunet
2023-01-20 12:48 ` Jerome Brunet
2023-01-20 12:48 ` Jerome Brunet
2023-01-19 22:56 ` [PATCH net-next] net: mdio: mux-meson-g12a: use devm_clk_get_enabled to simplify the code Heiner Kallweit
2023-01-19 22:56 ` Heiner Kallweit
2023-01-19 22:56 ` Heiner Kallweit
2023-01-20 10:14 ` Jerome Brunet
2023-01-20 10:14 ` Jerome Brunet
2023-01-20 10:14 ` Jerome Brunet
2023-01-23 14:50 ` patchwork-bot+netdevbpf
2023-01-23 14:50 ` patchwork-bot+netdevbpf
2023-01-23 14:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8Qwk5H8Yd7qiN0j@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.