Re: [PATCH 1/2] riscv: dts: sifive unmatched: Remove PWM controlled LED's active-low properties

From: Conor Dooley <conor.dooley@microchip.com>
To: Nylon Chen <nylon.chen@sifive.com>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
	<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
	<nylon7717@gmail.com>, <zong.li@sifive.com>,
	<greentime.hu@sifive.com>, <vincent.chen@sifive.com>
Subject: Re: [PATCH 1/2] riscv: dts: sifive unmatched: Remove PWM controlled LED's active-low properties
Date: Tue, 17 Jan 2023 13:57:48 +0000	[thread overview]
Message-ID: <Y8apXMzlDYhuLOqV@wendy> (raw)
In-Reply-To: <20230113083115.2590-2-nylon.chen@sifive.com>

[-- Attachment #1.1: Type: text/plain, Size: 1534 bytes --]

Hey Nylon,

On Fri, Jan 13, 2023 at 04:31:14PM +0800, Nylon Chen wrote:
> This removes the active-low properties of the PWM-controlled LEDs in
> the HiFive Unmatched device tree.

Does unleashed also have the same issue?
It has the same compatible at the very least.

Thanks,
Conor.

> 
> Signed-off-by: Nylon Chen <nylon.chen@sifive.com>
> Reviewed-by: Vincent Chen <vincent.chen@sifive.com>
> ---
>  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 07387f9c135c..11f08a545ee6 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -52,7 +52,6 @@ led-controller-1 {
>  
>  		led-d12 {
>  			pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>;
> -			active-low;
>  			color = <LED_COLOR_ID_GREEN>;
>  			max-brightness = <255>;
>  			label = "d12";
> @@ -69,19 +68,16 @@ multi-led {
>  
>  			led-red {
>  				pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>;
> -				active-low;
>  				color = <LED_COLOR_ID_RED>;
>  			};
>  
>  			led-green {
>  				pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>;
> -				active-low;
>  				color = <LED_COLOR_ID_GREEN>;
>  			};
>  
>  			led-blue {
>  				pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>;
> -				active-low;
>  				color = <LED_COLOR_ID_BLUE>;
>  			};
>  		};
> -- 
> 2.36.1
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv