All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nipun Gupta <nipun.gupta@amd.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	rafael@kernel.org, eric.auger@redhat.com,
	alex.williamson@redhat.com, cohuck@redhat.com,
	song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org,
	maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com,
	saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org,
	yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com,
	robin.murphy@arm.com, will@kernel.org, joro@8bytes.org,
	masahiroy@kernel.org, ndesaulniers@google.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, okaya@kernel.org,
	harpreet.anand@amd.com, nikhil.agarwal@amd.com,
	michal.simek@amd.com, git@amd.com
Subject: Re: [PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware interaction
Date: Tue, 17 Jan 2023 15:08:23 +0100	[thread overview]
Message-ID: <Y8ar1+QfRR++YfKJ@kroah.com> (raw)
In-Reply-To: <20230117134139.1298-5-nipun.gupta@amd.com>

On Tue, Jan 17, 2023 at 07:11:36PM +0530, Nipun Gupta wrote:
> +/** Request/Response structure */
> +#define MCDI_HEADER_OFST 0
> +#define MCDI_HEADER_CODE_LBN 0
> +#define MCDI_HEADER_CODE_WIDTH 7
> +#define MCDI_HEADER_RESYNC_LBN 7
> +#define MCDI_HEADER_RESYNC_WIDTH 1
> +#define MCDI_HEADER_DATALEN_LBN 8
> +#define MCDI_HEADER_DATALEN_WIDTH 8
> +#define MCDI_HEADER_SEQ_LBN 16
> +#define MCDI_HEADER_SEQ_WIDTH 4
> +#define MCDI_HEADER_RSVD_LBN 20
> +#define MCDI_HEADER_RSVD_WIDTH 1
> +#define MCDI_HEADER_NOT_EPOCH_LBN 21
> +#define MCDI_HEADER_NOT_EPOCH_WIDTH 1
> +#define MCDI_HEADER_ERROR_LBN 22
> +#define MCDI_HEADER_ERROR_WIDTH 1
> +#define MCDI_HEADER_RESPONSE_LBN 23
> +#define MCDI_HEADER_RESPONSE_WIDTH 1
> +#define MCDI_HEADER_XFLAGS_LBN 24
> +#define MCDI_HEADER_XFLAGS_WIDTH 8

<snip>

This whole file could use some tabs to align all of the values for the
defines to make it readable.  Any chance of doing that?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Nipun Gupta <nipun.gupta@amd.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	rafael@kernel.org, eric.auger@redhat.com,
	alex.williamson@redhat.com, cohuck@redhat.com,
	song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org,
	maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com,
	saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org,
	yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com,
	robin.murphy@arm.com, will@kernel.org, joro@8bytes.org,
	masahiroy@kernel.org, ndesaulniers@google.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, okaya@kernel.org,
	harpreet.anand@amd.com, nikhil.agarwal@amd.com,
	michal.simek@amd.com, git@amd.com
Subject: Re: [PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware interaction
Date: Tue, 17 Jan 2023 15:08:23 +0100	[thread overview]
Message-ID: <Y8ar1+QfRR++YfKJ@kroah.com> (raw)
In-Reply-To: <20230117134139.1298-5-nipun.gupta@amd.com>

On Tue, Jan 17, 2023 at 07:11:36PM +0530, Nipun Gupta wrote:
> +/** Request/Response structure */
> +#define MCDI_HEADER_OFST 0
> +#define MCDI_HEADER_CODE_LBN 0
> +#define MCDI_HEADER_CODE_WIDTH 7
> +#define MCDI_HEADER_RESYNC_LBN 7
> +#define MCDI_HEADER_RESYNC_WIDTH 1
> +#define MCDI_HEADER_DATALEN_LBN 8
> +#define MCDI_HEADER_DATALEN_WIDTH 8
> +#define MCDI_HEADER_SEQ_LBN 16
> +#define MCDI_HEADER_SEQ_WIDTH 4
> +#define MCDI_HEADER_RSVD_LBN 20
> +#define MCDI_HEADER_RSVD_WIDTH 1
> +#define MCDI_HEADER_NOT_EPOCH_LBN 21
> +#define MCDI_HEADER_NOT_EPOCH_WIDTH 1
> +#define MCDI_HEADER_ERROR_LBN 22
> +#define MCDI_HEADER_ERROR_WIDTH 1
> +#define MCDI_HEADER_RESPONSE_LBN 23
> +#define MCDI_HEADER_RESPONSE_WIDTH 1
> +#define MCDI_HEADER_XFLAGS_LBN 24
> +#define MCDI_HEADER_XFLAGS_WIDTH 8

<snip>

This whole file could use some tabs to align all of the values for the
defines to make it readable.  Any chance of doing that?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-01-17 14:09 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 13:41 [PATCH 0/7] add support for CDX bus Nipun Gupta
2023-01-17 13:41 ` Nipun Gupta
2023-01-17 13:41 ` [PATCH 01/19] bus/cdx: add the cdx bus driver Nipun Gupta
2023-01-17 13:41   ` Nipun Gupta
2023-01-17 14:07   ` Greg KH
2023-01-17 14:07     ` Greg KH
2023-01-18 10:56     ` Gupta, Nipun
2023-01-18 10:56       ` Gupta, Nipun
2023-01-17 17:21   ` Randy Dunlap
2023-01-17 17:21     ` Randy Dunlap
2023-01-18 10:59     ` Gupta, Nipun
2023-01-18 10:59       ` Gupta, Nipun
2023-01-17 13:41 ` [PATCH 02/19] iommu/arm-smmu-v3: support ops registration for CDX bus Nipun Gupta
2023-01-17 13:41   ` Nipun Gupta
2023-01-17 13:41 ` [PATCH 03/19] dt-bindings: bus: add CDX bus controller device tree bindings Nipun Gupta
2023-01-17 13:41   ` Nipun Gupta
2023-01-17 17:54   ` Krzysztof Kozlowski
2023-01-17 17:54     ` Krzysztof Kozlowski
2023-01-18 12:39     ` Gupta, Nipun
2023-01-18 12:39       ` Gupta, Nipun
2023-01-18 12:43       ` Krzysztof Kozlowski
2023-01-18 12:43         ` Krzysztof Kozlowski
2023-01-19  7:33         ` Gupta, Nipun
2023-01-19  7:33           ` Gupta, Nipun
2023-01-17 13:41 ` [PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware interaction Nipun Gupta
2023-01-17 13:41   ` Nipun Gupta
2023-01-17 14:08   ` Greg KH [this message]
2023-01-17 14:08     ` Greg KH
2023-01-18 10:58     ` Gupta, Nipun
2023-01-18 10:58       ` Gupta, Nipun
2023-01-17 13:41 ` [PATCH 05/19] bus/cdx: add cdx controller Nipun Gupta
2023-01-17 13:41   ` Nipun Gupta
2023-01-17 14:10   ` Greg KH
2023-01-17 14:10     ` Greg KH
2023-01-18 12:36     ` Gupta, Nipun
2023-01-18 12:36       ` Gupta, Nipun
2023-01-17 13:41 ` [PATCH 06/19] bus/cdx: add rpmsg communication channel for CDX Nipun Gupta
2023-01-17 13:41   ` Nipun Gupta
2023-01-17 13:41 ` [PATCH 07/19] bus/cdx: add device attributes Nipun Gupta
2023-01-17 13:41   ` Nipun Gupta
2023-01-17 14:13   ` Greg KH
2023-01-17 14:13     ` Greg KH
2023-01-18 13:03     ` Gupta, Nipun
2023-01-18 13:03       ` Gupta, Nipun
2023-01-17 17:47 ` [PATCH 0/7] add support for CDX bus Krzysztof Kozlowski
2023-01-17 17:47   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8ar1+QfRR++YfKJ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Michael.Srba@seznam.cz \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eric.auger@redhat.com \
    --cc=f.fainelli@gmail.com \
    --cc=git@amd.com \
    --cc=harpreet.anand@amd.com \
    --cc=jeffrey.l.hugo@gmail.com \
    --cc=jgg@nvidia.com \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=maz@kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=ndesaulniers@google.com \
    --cc=nikhil.agarwal@amd.com \
    --cc=nipun.gupta@amd.com \
    --cc=okaya@kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=saravanak@google.com \
    --cc=song.bao.hua@hisilicon.com \
    --cc=will@kernel.org \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.