All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: linux-omap@vger.kernel.org, peter.ujfalusi@gmail.com,
	jarkko.nikula@bitmer.com
Subject: Re: omap  mcbsp and prcm_fck
Date: Thu, 19 Jan 2023 09:41:36 +0200	[thread overview]
Message-ID: <Y8j0MMLoanjo1MCf@atomide.com> (raw)
In-Reply-To: <20230117120810.6cf8b6f7@aktux>

Hi,

* Andreas Kemnade <andreas@kemnade.info> [230117 11:08]:
> Hi,
> 
> while trying to create a devicetree for a omap4 device, I stumbled upon this:
> 
> [   59.789367] omap-mcbsp 40124000.mcbsp: CLKS: could not clk_get() prcm_fck
> 
> But where should prcm_fck come from? The string does not appear in the
> devicetree binding documentation. I have seen it only in the omap_hwmod_* stuff
> used by omap2/3.
> 
> So how to make mcbsp happy?

I think all you need to do is add an entry for prcm_fck to point to
mcbsp4_sync_mux_ck in omap44xx_clks[]. Seems this got dropped with commit
349355ce3a05 ("ARM: OMAP2+: Drop legacy platform data for omap4 mcbsp").

Or patch the driver so it tries to use the dt clock so that the standard
assigned-clocks devicetree property works for a board specific
configuration.

Regards,

Tony

  reply	other threads:[~2023-01-19  7:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 11:08 omap mcbsp and prcm_fck Andreas Kemnade
2023-01-19  7:41 ` Tony Lindgren [this message]
2023-01-19 21:16   ` Andreas Kemnade
2023-01-24 13:25     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8j0MMLoanjo1MCf@atomide.com \
    --to=tony@atomide.com \
    --cc=andreas@kemnade.info \
    --cc=jarkko.nikula@bitmer.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.