* [PATCH v2] drm/radeon: Do not use deprecated drm log API
@ 2023-01-17 18:04 Nirmoy Das
2023-01-17 18:04 ` Nirmoy Das
2023-01-19 7:56 ` [PATCH v2] drm/radeon: Do not use deprecated drm log API Sam Ravnborg
0 siblings, 2 replies; 8+ messages in thread
From: Nirmoy Das @ 2023-01-17 18:04 UTC (permalink / raw)
To: dri-devel; +Cc: Alex Deucher, Christian König, amd-gfx, Nirmoy Das
Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR()
with proper APIs.
v2: replace pr_err with dev_err(Alex).
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/radeon/radeon_dp_auxch.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_dp_auxch.c b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
index 69379b95146e..1e5b6baf76a1 100644
--- a/drivers/gpu/drm/radeon/radeon_dp_auxch.c
+++ b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
@@ -158,7 +158,7 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg
} while (retry_count++ < 1000);
if (retry_count >= 1000) {
- DRM_ERROR("auxch hw never signalled completion, error %08x\n", tmp);
+ dev_err(rdev->dev, "auxch hw never signalled completion, error %08x\n", tmp);
ret = -EIO;
goto done;
}
@@ -168,8 +168,7 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg
goto done;
}
if (tmp & AUX_RX_ERROR_FLAGS) {
- DRM_DEBUG_KMS_RATELIMITED("dp_aux_ch flags not zero: %08x\n",
- tmp);
+ drm_dbg_kms_ratelimited(dev, "dp_aux_ch flags not zero: %08x\n", tmp);
ret = -EIO;
goto done;
}
--
2.39.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()
2023-01-17 18:04 [PATCH v2] drm/radeon: Do not use deprecated drm log API Nirmoy Das
@ 2023-01-17 18:04 ` Nirmoy Das
2023-01-19 7:56 ` [PATCH v2] drm/radeon: Do not use deprecated drm log API Sam Ravnborg
1 sibling, 0 replies; 8+ messages in thread
From: Nirmoy Das @ 2023-01-17 18:04 UTC (permalink / raw)
To: dri-devel
Cc: Daniel Vetter, Sam Ravnborg, Maarten Lankhorst, Maxime Ripard,
amd-gfx, Thomas Zimmermann, David Airlie, Nirmoy Das
There are no current users of DRM_DEBUG_KMS_RATELIMITED()
so remove it.
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
---
include/drm/drm_print.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index a44fb7ef257f..c3753da97c4e 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -605,9 +605,6 @@ void __drm_err(const char *format, ...);
#define drm_dbg_kms_ratelimited(drm, fmt, ...) \
__DRM_DEFINE_DBG_RATELIMITED(KMS, drm, fmt, ## __VA_ARGS__)
-/* NOTE: this is deprecated in favor of drm_dbg_kms_ratelimited(NULL, ...). */
-#define DRM_DEBUG_KMS_RATELIMITED(fmt, ...) drm_dbg_kms_ratelimited(NULL, fmt, ## __VA_ARGS__)
-
/*
* struct drm_device based WARNs
*
--
2.39.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()
@ 2023-01-17 18:04 ` Nirmoy Das
0 siblings, 0 replies; 8+ messages in thread
From: Nirmoy Das @ 2023-01-17 18:04 UTC (permalink / raw)
To: dri-devel; +Cc: Sam Ravnborg, amd-gfx, Thomas Zimmermann, Nirmoy Das
There are no current users of DRM_DEBUG_KMS_RATELIMITED()
so remove it.
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
---
include/drm/drm_print.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index a44fb7ef257f..c3753da97c4e 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -605,9 +605,6 @@ void __drm_err(const char *format, ...);
#define drm_dbg_kms_ratelimited(drm, fmt, ...) \
__DRM_DEFINE_DBG_RATELIMITED(KMS, drm, fmt, ## __VA_ARGS__)
-/* NOTE: this is deprecated in favor of drm_dbg_kms_ratelimited(NULL, ...). */
-#define DRM_DEBUG_KMS_RATELIMITED(fmt, ...) drm_dbg_kms_ratelimited(NULL, fmt, ## __VA_ARGS__)
-
/*
* struct drm_device based WARNs
*
--
2.39.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()
2023-01-17 18:04 ` Nirmoy Das
(?)
@ 2023-01-17 18:06 ` Alex Deucher
2023-01-17 18:12 ` Das, Nirmoy
-1 siblings, 1 reply; 8+ messages in thread
From: Alex Deucher @ 2023-01-17 18:06 UTC (permalink / raw)
To: Nirmoy Das; +Cc: Thomas Zimmermann, Sam Ravnborg, amd-gfx, dri-devel
On Tue, Jan 17, 2023 at 1:05 PM Nirmoy Das <nirmoy.das@intel.com> wrote:
>
> There are no current users of DRM_DEBUG_KMS_RATELIMITED()
> so remove it.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sam Ravnborg <sam@ravnborg.org>
>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Feel free to take the patches through whatever tree you want.
Alex
> ---
> include/drm/drm_print.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> index a44fb7ef257f..c3753da97c4e 100644
> --- a/include/drm/drm_print.h
> +++ b/include/drm/drm_print.h
> @@ -605,9 +605,6 @@ void __drm_err(const char *format, ...);
> #define drm_dbg_kms_ratelimited(drm, fmt, ...) \
> __DRM_DEFINE_DBG_RATELIMITED(KMS, drm, fmt, ## __VA_ARGS__)
>
> -/* NOTE: this is deprecated in favor of drm_dbg_kms_ratelimited(NULL, ...). */
> -#define DRM_DEBUG_KMS_RATELIMITED(fmt, ...) drm_dbg_kms_ratelimited(NULL, fmt, ## __VA_ARGS__)
> -
> /*
> * struct drm_device based WARNs
> *
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()
2023-01-17 18:06 ` Alex Deucher
@ 2023-01-17 18:12 ` Das, Nirmoy
2023-01-18 6:27 ` Christian König
0 siblings, 1 reply; 8+ messages in thread
From: Das, Nirmoy @ 2023-01-17 18:12 UTC (permalink / raw)
To: Alex Deucher; +Cc: Thomas Zimmermann, Sam Ravnborg, amd-gfx, dri-devel
Hi Alex,
On 1/17/2023 7:06 PM, Alex Deucher wrote:
> On Tue, Jan 17, 2023 at 1:05 PM Nirmoy Das <nirmoy.das@intel.com> wrote:
>> There are no current users of DRM_DEBUG_KMS_RATELIMITED()
>> so remove it.
>>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Series is:
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> Feel free to take the patches through whatever tree you want.
Please help me with this, I don't have committer rights for any tree.
Nirmoy
>
> Alex
>
>> ---
>> include/drm/drm_print.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
>> index a44fb7ef257f..c3753da97c4e 100644
>> --- a/include/drm/drm_print.h
>> +++ b/include/drm/drm_print.h
>> @@ -605,9 +605,6 @@ void __drm_err(const char *format, ...);
>> #define drm_dbg_kms_ratelimited(drm, fmt, ...) \
>> __DRM_DEFINE_DBG_RATELIMITED(KMS, drm, fmt, ## __VA_ARGS__)
>>
>> -/* NOTE: this is deprecated in favor of drm_dbg_kms_ratelimited(NULL, ...). */
>> -#define DRM_DEBUG_KMS_RATELIMITED(fmt, ...) drm_dbg_kms_ratelimited(NULL, fmt, ## __VA_ARGS__)
>> -
>> /*
>> * struct drm_device based WARNs
>> *
>> --
>> 2.39.0
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()
2023-01-17 18:12 ` Das, Nirmoy
@ 2023-01-18 6:27 ` Christian König
2023-01-18 9:34 ` Das, Nirmoy
0 siblings, 1 reply; 8+ messages in thread
From: Christian König @ 2023-01-18 6:27 UTC (permalink / raw)
To: Das, Nirmoy, Alex Deucher
Cc: dri-devel, Sam Ravnborg, amd-gfx, Thomas Zimmermann
Am 17.01.23 um 19:12 schrieb Das, Nirmoy:
> Hi Alex,
>
> On 1/17/2023 7:06 PM, Alex Deucher wrote:
>> On Tue, Jan 17, 2023 at 1:05 PM Nirmoy Das <nirmoy.das@intel.com> wrote:
>>> There are no current users of DRM_DEBUG_KMS_RATELIMITED()
>>> so remove it.
>>>
>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> Cc: Maxime Ripard <mripard@kernel.org>
>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>> Cc: David Airlie <airlied@gmail.com>
>>> Cc: Daniel Vetter <daniel@ffwll.ch>
>>> Cc: Sam Ravnborg <sam@ravnborg.org>
>>>
>>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>>> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>> Series is:
>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>
>> Feel free to take the patches through whatever tree you want.
>
>
> Please help me with this, I don't have committer rights for any tree.
Going to push that into drm-misc-next later today.
Thanks,
Christian.
>
>
> Nirmoy
>
>
>>
>> Alex
>>
>>> ---
>>> include/drm/drm_print.h | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>
>>> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
>>> index a44fb7ef257f..c3753da97c4e 100644
>>> --- a/include/drm/drm_print.h
>>> +++ b/include/drm/drm_print.h
>>> @@ -605,9 +605,6 @@ void __drm_err(const char *format, ...);
>>> #define drm_dbg_kms_ratelimited(drm, fmt, ...) \
>>> __DRM_DEFINE_DBG_RATELIMITED(KMS, drm, fmt, ## __VA_ARGS__)
>>>
>>> -/* NOTE: this is deprecated in favor of
>>> drm_dbg_kms_ratelimited(NULL, ...). */
>>> -#define DRM_DEBUG_KMS_RATELIMITED(fmt, ...)
>>> drm_dbg_kms_ratelimited(NULL, fmt, ## __VA_ARGS__)
>>> -
>>> /*
>>> * struct drm_device based WARNs
>>> *
>>> --
>>> 2.39.0
>>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()
2023-01-18 6:27 ` Christian König
@ 2023-01-18 9:34 ` Das, Nirmoy
0 siblings, 0 replies; 8+ messages in thread
From: Das, Nirmoy @ 2023-01-18 9:34 UTC (permalink / raw)
To: Christian König, Alex Deucher
Cc: dri-devel, Sam Ravnborg, amd-gfx, Thomas Zimmermann
On 1/18/2023 7:27 AM, Christian König wrote:
>
>
> Am 17.01.23 um 19:12 schrieb Das, Nirmoy:
>> Hi Alex,
>>
>> On 1/17/2023 7:06 PM, Alex Deucher wrote:
>>> On Tue, Jan 17, 2023 at 1:05 PM Nirmoy Das <nirmoy.das@intel.com>
>>> wrote:
>>>> There are no current users of DRM_DEBUG_KMS_RATELIMITED()
>>>> so remove it.
>>>>
>>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>>> Cc: Maxime Ripard <mripard@kernel.org>
>>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>>> Cc: David Airlie <airlied@gmail.com>
>>>> Cc: Daniel Vetter <daniel@ffwll.ch>
>>>> Cc: Sam Ravnborg <sam@ravnborg.org>
>>>>
>>>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>>>> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>>> Series is:
>>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>>
>>> Feel free to take the patches through whatever tree you want.
>>
>>
>> Please help me with this, I don't have committer rights for any tree.
>
> Going to push that into drm-misc-next later today.
Thanks, Christian.
>
> Thanks,
> Christian.
>
>>
>>
>> Nirmoy
>>
>>
>>>
>>> Alex
>>>
>>>> ---
>>>> include/drm/drm_print.h | 3 ---
>>>> 1 file changed, 3 deletions(-)
>>>>
>>>> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
>>>> index a44fb7ef257f..c3753da97c4e 100644
>>>> --- a/include/drm/drm_print.h
>>>> +++ b/include/drm/drm_print.h
>>>> @@ -605,9 +605,6 @@ void __drm_err(const char *format, ...);
>>>> #define drm_dbg_kms_ratelimited(drm, fmt, ...) \
>>>> __DRM_DEFINE_DBG_RATELIMITED(KMS, drm, fmt, ## __VA_ARGS__)
>>>>
>>>> -/* NOTE: this is deprecated in favor of
>>>> drm_dbg_kms_ratelimited(NULL, ...). */
>>>> -#define DRM_DEBUG_KMS_RATELIMITED(fmt, ...)
>>>> drm_dbg_kms_ratelimited(NULL, fmt, ## __VA_ARGS__)
>>>> -
>>>> /*
>>>> * struct drm_device based WARNs
>>>> *
>>>> --
>>>> 2.39.0
>>>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/radeon: Do not use deprecated drm log API
2023-01-17 18:04 [PATCH v2] drm/radeon: Do not use deprecated drm log API Nirmoy Das
2023-01-17 18:04 ` Nirmoy Das
@ 2023-01-19 7:56 ` Sam Ravnborg
1 sibling, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2023-01-19 7:56 UTC (permalink / raw)
To: Nirmoy Das; +Cc: Alex Deucher, amd-gfx, Christian König, dri-devel
Hi Nirmoy,
On Tue, Jan 17, 2023 at 07:04:16PM +0100, Nirmoy Das wrote:
> Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR()
> with proper APIs.
Thanks for working on this!
Also thanks for Christian to take care and apply the patches.
Sam
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-01-19 7:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-17 18:04 [PATCH v2] drm/radeon: Do not use deprecated drm log API Nirmoy Das
2023-01-17 18:04 ` [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED() Nirmoy Das
2023-01-17 18:04 ` Nirmoy Das
2023-01-17 18:06 ` Alex Deucher
2023-01-17 18:12 ` Das, Nirmoy
2023-01-18 6:27 ` Christian König
2023-01-18 9:34 ` Das, Nirmoy
2023-01-19 7:56 ` [PATCH v2] drm/radeon: Do not use deprecated drm log API Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.