All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Cristian Marussi <cristian.marussi@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Linux Documentation <linux-doc@vger.kernel.org>
Cc: sudeep.holla@arm.com, Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI documentation
Date: Fri, 20 Jan 2023 19:43:30 +0700	[thread overview]
Message-ID: <Y8qMclu5Tc3dKCS6@debian.me> (raw)
In-Reply-To: <20230120122326.1932614-1-cristian.marussi@arm.com>

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

[Also Cc: linux-doc list]

On Fri, Jan 20, 2023 at 12:23:26PM +0000, Cristian Marussi wrote:
> diff --git a/Documentation/ABI/testing/debugfs-scmi-raw b/Documentation/ABI/testing/debugfs-scmi-raw
> index 5468ec08c084..b1c505ed444c 100644
> --- a/Documentation/ABI/testing/debugfs-scmi-raw
> +++ b/Documentation/ABI/testing/debugfs-scmi-raw
> @@ -80,9 +80,13 @@ Description:	SCMI Raw synchronous message injection/snooping facility; write
>  		Each write to the entry causes one command request to be built
>  		and sent while the replies are read back one message at time
>  		(receiving an EOF at each message boundary).
> +		Channel identifier <m> matches the SCMI protocol number which
> +		has been associated with this transport channel in the DT
> +		description, with Base protocol number 0x10 being the default
> +		channel for this instance.

s/Base/base/

>  		Note that these per-channel entries rooted at <..>/channels
>  		exist only if the transport is configured to have more than
> -		one channel.
> +		one default channel.
>  Users:		Debugging, any userspace test suite
>  
>  What:		/sys/kernel/debug/scmi/<n>/raw/channels/<m>/message_async
> @@ -103,7 +107,11 @@ Description:	SCMI Raw asynchronous message injection/snooping facility; write
>  		Each write to the entry causes one command request to be built
>  		and sent while the replies are read back one message at time
>  		(receiving an EOF at each message boundary).
> +		Channel identifier <m> matches the SCMI protocol number which
> +		has been associated with this transport channel in the DT
> +		description, with Base protocol number 0x10 being the default
> +		channel for this instance.

Same here.

>  		Note that these per-channel entries rooted at <..>/channels
>  		exist only if the transport is configured to have more than
> -		one channel.
> +		one default channel.
>  Users:		Debugging, any userspace test suite
 
Otherwise LGTM.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Cristian Marussi <cristian.marussi@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Linux Documentation <linux-doc@vger.kernel.org>
Cc: sudeep.holla@arm.com, Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI documentation
Date: Fri, 20 Jan 2023 19:43:30 +0700	[thread overview]
Message-ID: <Y8qMclu5Tc3dKCS6@debian.me> (raw)
In-Reply-To: <20230120122326.1932614-1-cristian.marussi@arm.com>


[-- Attachment #1.1: Type: text/plain, Size: 2030 bytes --]

[Also Cc: linux-doc list]

On Fri, Jan 20, 2023 at 12:23:26PM +0000, Cristian Marussi wrote:
> diff --git a/Documentation/ABI/testing/debugfs-scmi-raw b/Documentation/ABI/testing/debugfs-scmi-raw
> index 5468ec08c084..b1c505ed444c 100644
> --- a/Documentation/ABI/testing/debugfs-scmi-raw
> +++ b/Documentation/ABI/testing/debugfs-scmi-raw
> @@ -80,9 +80,13 @@ Description:	SCMI Raw synchronous message injection/snooping facility; write
>  		Each write to the entry causes one command request to be built
>  		and sent while the replies are read back one message at time
>  		(receiving an EOF at each message boundary).
> +		Channel identifier <m> matches the SCMI protocol number which
> +		has been associated with this transport channel in the DT
> +		description, with Base protocol number 0x10 being the default
> +		channel for this instance.

s/Base/base/

>  		Note that these per-channel entries rooted at <..>/channels
>  		exist only if the transport is configured to have more than
> -		one channel.
> +		one default channel.
>  Users:		Debugging, any userspace test suite
>  
>  What:		/sys/kernel/debug/scmi/<n>/raw/channels/<m>/message_async
> @@ -103,7 +107,11 @@ Description:	SCMI Raw asynchronous message injection/snooping facility; write
>  		Each write to the entry causes one command request to be built
>  		and sent while the replies are read back one message at time
>  		(receiving an EOF at each message boundary).
> +		Channel identifier <m> matches the SCMI protocol number which
> +		has been associated with this transport channel in the DT
> +		description, with Base protocol number 0x10 being the default
> +		channel for this instance.

Same here.

>  		Note that these per-channel entries rooted at <..>/channels
>  		exist only if the transport is configured to have more than
> -		one channel.
> +		one default channel.
>  Users:		Debugging, any userspace test suite
 
Otherwise LGTM.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-01-20 12:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 12:23 [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI documentation Cristian Marussi
2023-01-20 12:23 ` Cristian Marussi
2023-01-20 12:43 ` Bagas Sanjaya [this message]
2023-01-20 12:43   ` Bagas Sanjaya
2023-01-20 14:34   ` Cristian Marussi
2023-01-20 14:34     ` Cristian Marussi
2023-01-20 14:14 ` Sudeep Holla
2023-01-20 14:14   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8qMclu5Tc3dKCS6@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.