From: Conor Dooley <conor@kernel.org>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Yimin Gu <ustcymgu@gmail.com>,
Waldemar Brodkorb <wbx@openadk.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v1 1/2] riscv: Kconfig: Allow RV32 to build with no MMU
Date: Sat, 21 Jan 2023 15:00:44 +0000 [thread overview]
Message-ID: <Y8v+HOkrT5RF0Ysn@spud> (raw)
In-Reply-To: <Y8sAQqOo4DX7GwHN@spud>
[-- Attachment #1.1: Type: text/plain, Size: 996 bytes --]
On Fri, Jan 20, 2023 at 08:57:38PM +0000, Conor Dooley wrote:
> > > > diff --git a/drivers/clk/clk-k210.c b/drivers/clk/clk-k210.c
> > > > index 67a7cb3503c3..17c5bfb384ad 100644
> > > > --- a/drivers/clk/clk-k210.c
> > > > +++ b/drivers/clk/clk-k210.c
> > > > @@ -495,7 +495,7 @@ static unsigned long k210_pll_get_rate(struct clk_hw *hw,
> > > > f = FIELD_GET(K210_PLL_CLKF, reg) + 1;
> > > > od = FIELD_GET(K210_PLL_CLKOD, reg) + 1;
> > > > - return (u64)parent_rate * f / (r * od);
> > > > + return div_u64(parent_rate * f, r * od);
> > >
> > > Nope, that's wrong. I omitted the cast...
> > >
> > > return div_u64((u64)parent_rate * f, r * od);
>
>
> > Ah that's a much better fix, shall I prepend this to the set and author you?
>
> Uh, I'd rather check that it is a functional fix first!
> I have the board, so I'll give it a go tomorrow and let you know.
Gave it a go, board still works with revised version of this change in
place.
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Yimin Gu <ustcymgu@gmail.com>,
Waldemar Brodkorb <wbx@openadk.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v1 1/2] riscv: Kconfig: Allow RV32 to build with no MMU
Date: Sat, 21 Jan 2023 15:00:44 +0000 [thread overview]
Message-ID: <Y8v+HOkrT5RF0Ysn@spud> (raw)
In-Reply-To: <Y8sAQqOo4DX7GwHN@spud>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On Fri, Jan 20, 2023 at 08:57:38PM +0000, Conor Dooley wrote:
> > > > diff --git a/drivers/clk/clk-k210.c b/drivers/clk/clk-k210.c
> > > > index 67a7cb3503c3..17c5bfb384ad 100644
> > > > --- a/drivers/clk/clk-k210.c
> > > > +++ b/drivers/clk/clk-k210.c
> > > > @@ -495,7 +495,7 @@ static unsigned long k210_pll_get_rate(struct clk_hw *hw,
> > > > f = FIELD_GET(K210_PLL_CLKF, reg) + 1;
> > > > od = FIELD_GET(K210_PLL_CLKOD, reg) + 1;
> > > > - return (u64)parent_rate * f / (r * od);
> > > > + return div_u64(parent_rate * f, r * od);
> > >
> > > Nope, that's wrong. I omitted the cast...
> > >
> > > return div_u64((u64)parent_rate * f, r * od);
>
>
> > Ah that's a much better fix, shall I prepend this to the set and author you?
>
> Uh, I'd rather check that it is a functional fix first!
> I have the board, so I'll give it a go tomorrow and let you know.
Gave it a go, board still works with revised version of this change in
place.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-21 15:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 5:26 [PATCH v1 0/2] Add RISC-V 32 NOMMU support Jesse Taube
2023-01-19 5:26 ` Jesse Taube
2023-01-19 5:26 ` [PATCH v1 1/2] riscv: Kconfig: Allow RV32 to build with no MMU Jesse Taube
2023-01-19 5:26 ` Jesse Taube
2023-01-20 7:33 ` kernel test robot
2023-01-20 7:33 ` kernel test robot
2023-01-20 7:59 ` Conor Dooley
2023-01-20 7:59 ` Conor Dooley
2023-01-20 17:39 ` Jesse Taube
2023-01-20 17:39 ` Jesse Taube
2023-01-20 20:44 ` Conor Dooley
2023-01-20 20:44 ` Conor Dooley
2023-01-20 20:48 ` Conor Dooley
2023-01-20 20:48 ` Conor Dooley
2023-01-20 20:51 ` Jesse Taube
2023-01-20 20:51 ` Jesse Taube
2023-01-20 20:57 ` Conor Dooley
2023-01-20 20:57 ` Conor Dooley
2023-01-21 15:00 ` Conor Dooley [this message]
2023-01-21 15:00 ` Conor Dooley
2023-01-19 5:26 ` [PATCH v1 2/2] riscv: configs: Add nommu decfconfig for RV32 Jesse Taube
2023-01-19 5:26 ` Jesse Taube
2023-01-20 8:05 ` Conor Dooley
2023-01-20 8:05 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8v+HOkrT5RF0Ysn@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mr.bossman075@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ustcymgu@gmail.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.