From: Wolfram Sang <wsa@kernel.org>
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc: michal.simek@xilinx.com, michal.simek@amd.com,
devicetree@vger.kernel.org, andrew@lunn.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, git@amd.com, srinivas.goud@amd.com,
shubhrajyoti.datta@amd.com, manion05gk@gmail.com,
Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Subject: Re: [PATCH V4 5/9] i2c: xiic: Add smbus_block_read functionality
Date: Fri, 3 Feb 2023 17:37:43 +0100 [thread overview]
Message-ID: <Y904V8zdCKDFxtR3@shikoro> (raw)
In-Reply-To: <1675330898-563-6-git-send-email-manikanta.guntupalli@amd.com>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Thu, Feb 02, 2023 at 03:11:34PM +0530, Manikanta Guntupalli wrote:
> From: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
>
> smbus_block_read is added to xiic driver to read from few sensors
> which support this command. Since the number of bytes to read is not
> known prior to transfer, xiic standard mode is being used for low level
> control of IP.
>
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> Acked-by: Michal Simek <michal.simek@amd.com>
Applied to for-next, thanks!
> - return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | I2C_FUNC_SMBUS_BLOCK_DATA;
Note: Since you implemented I2C_M_RECV_LEN anyhow, you get the emulated
I2C_FUNC_SMBUS_BLOCK_PROC_CALL basically for free, so you could also use
I2C_FUNC_SMBUS_EMUL_ALL here.
If you'd like this, please send an incremental patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc: michal.simek@xilinx.com, michal.simek@amd.com,
devicetree@vger.kernel.org, andrew@lunn.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, git@amd.com, srinivas.goud@amd.com,
shubhrajyoti.datta@amd.com, manion05gk@gmail.com,
Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Subject: Re: [PATCH V4 5/9] i2c: xiic: Add smbus_block_read functionality
Date: Fri, 3 Feb 2023 17:37:43 +0100 [thread overview]
Message-ID: <Y904V8zdCKDFxtR3@shikoro> (raw)
In-Reply-To: <1675330898-563-6-git-send-email-manikanta.guntupalli@amd.com>
[-- Attachment #1.1: Type: text/plain, Size: 958 bytes --]
On Thu, Feb 02, 2023 at 03:11:34PM +0530, Manikanta Guntupalli wrote:
> From: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
>
> smbus_block_read is added to xiic driver to read from few sensors
> which support this command. Since the number of bytes to read is not
> known prior to transfer, xiic standard mode is being used for low level
> control of IP.
>
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> Acked-by: Michal Simek <michal.simek@amd.com>
Applied to for-next, thanks!
> - return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | I2C_FUNC_SMBUS_BLOCK_DATA;
Note: Since you implemented I2C_M_RECV_LEN anyhow, you get the emulated
I2C_FUNC_SMBUS_BLOCK_PROC_CALL basically for free, so you could also use
I2C_FUNC_SMBUS_EMUL_ALL here.
If you'd like this, please send an incremental patch.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-03 16:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 9:41 [PATCH V4 0/9] Added Standard mode and SMBus support Manikanta Guntupalli
2023-02-02 9:41 ` Manikanta Guntupalli
2023-02-02 9:41 ` [PATCH V4 1/9] i2c: xiic: Add standard mode support for > 255 byte Manikanta Guntupalli
2023-02-02 9:41 ` Manikanta Guntupalli
2023-02-03 16:35 ` Wolfram Sang
2023-02-03 16:35 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 2/9] i2c: xiic: Fix Rx and Tx paths in standard mode Manikanta Guntupalli
2023-02-02 9:41 ` Manikanta Guntupalli
2023-02-03 16:35 ` Wolfram Sang
2023-02-03 16:35 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 3/9] i2c: xiic: Switch to Xiic standard mode for i2c-read Manikanta Guntupalli
2023-02-02 9:41 ` Manikanta Guntupalli
2023-02-03 16:35 ` Wolfram Sang
2023-02-03 16:35 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 4/9] i2c: xiic: Add wait for FIFO empty in send_tx Manikanta Guntupalli
2023-02-02 9:41 ` Manikanta Guntupalli
2023-02-03 16:35 ` Wolfram Sang
2023-02-03 16:35 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 5/9] i2c: xiic: Add smbus_block_read functionality Manikanta Guntupalli
2023-02-02 9:41 ` Manikanta Guntupalli
2023-02-03 16:37 ` Wolfram Sang [this message]
2023-02-03 16:37 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 6/9] i2c: xiic: Remove interrupt enable/disable in Rx path Manikanta Guntupalli
2023-02-02 9:41 ` Manikanta Guntupalli
2023-02-03 16:37 ` Wolfram Sang
2023-02-03 16:37 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 7/9] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to Manikanta Guntupalli
2023-02-02 9:41 ` Manikanta Guntupalli
2023-02-02 9:46 ` Krzysztof Kozlowski
2023-02-02 9:46 ` Krzysztof Kozlowski
2023-02-02 9:41 ` [PATCH V4 8/9] i2c: xiic: Update compatible with new IP version Manikanta Guntupalli
2023-02-02 9:41 ` Manikanta Guntupalli
2023-02-02 9:41 ` [PATCH V4 9/9] i2c: xiic: Add SCL frequency configuration support Manikanta Guntupalli
2023-02-02 9:41 ` Manikanta Guntupalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y904V8zdCKDFxtR3@shikoro \
--to=wsa@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=manion05gk@gmail.com \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=raviteja.narayanam@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.goud@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.