[PATCH] perf: Enable debug/source packaging

[PATCH] perf: Enable debug/source packaging

[Richard Purdie]

This was disabled in 2014[1] due to an error message which as far
as I can tell, no longer occurs.

Having debug information and source files present will make debugging
reproducibility issues much easier so remove this line as it appears
no longer needed.

[1] OE-Core revision c1b5a262c0201faf2c6bf545d6acb32dfe383ba3

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-kernel/perf/perf.bb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index 1dff39a17e4..e8a9c57a0aa 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -360,6 +360,4 @@ FILES:${PN}-python = " \
                        "
 FILES:${PN}-perl = "${libexecdir}/perf-core/scripts/perl"
 
-
-INHIBIT_PACKAGE_DEBUG_SPLIT="1"
 DEBUG_OPTIMIZATION:append = " -Wno-error=maybe-uninitialized"
-- 
2.37.2

Re: [OE-core] [PATCH] perf: Enable debug/source packaging

[Alexandre Belloni]

Hello Richard,

This is causing:
WARNING: perf-1.0-r9 do_package_qa: QA Issue: File /usr/src/debug/perf/1.0-r9/util/expr-flex.h in package perf-src contains reference to TMPDIR

On 03/02/2023 16:52:03+0000, Richard Purdie wrote:
> This was disabled in 2014[1] due to an error message which as far
> as I can tell, no longer occurs.
> 
> Having debug information and source files present will make debugging
> reproducibility issues much easier so remove this line as it appears
> no longer needed.
> 
> [1] OE-Core revision c1b5a262c0201faf2c6bf545d6acb32dfe383ba3
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-kernel/perf/perf.bb | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 1dff39a17e4..e8a9c57a0aa 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -360,6 +360,4 @@ FILES:${PN}-python = " \
>                         "
>  FILES:${PN}-perl = "${libexecdir}/perf-core/scripts/perl"
>  
> -
> -INHIBIT_PACKAGE_DEBUG_SPLIT="1"
>  DEBUG_OPTIMIZATION:append = " -Wno-error=maybe-uninitialized"
> -- 
> 2.37.2
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#176733): https://lists.openembedded.org/g/openembedded-core/message/176733
> Mute This Topic: https://lists.openembedded.org/mt/96726928/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] perf: Enable debug/source packaging

[Richard Purdie]

On Fri, 2023-02-03 at 23:28 +0100, Alexandre Belloni wrote:
> Hello Richard,
> 
> This is causing:
> WARNING: perf-1.0-r9 do_package_qa: QA Issue: File /usr/src/debug/perf/1.0-r9/util/expr-flex.h in package perf-src contains reference to TMPDIR

Sorry, not sure why my local tests didn't show that up. I've sent a v2.

Cheers,

Richard