From: Lee Jones <lee@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv6 05/11] mfd: rk808: split into core and i2c
Date: Sat, 4 Feb 2023 13:52:37 +0000 [thread overview]
Message-ID: <Y95jJYlqDayiaMP1@google.com> (raw)
In-Reply-To: <20230127181244.160887-6-sebastian.reichel@collabora.com>
On Fri, 27 Jan 2023, Sebastian Reichel wrote:
> Split rk808 into a core and an i2c part in preperation for
> SPI support.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> drivers/clk/Kconfig | 2 +-
> drivers/input/misc/Kconfig | 2 +-
> drivers/mfd/Kconfig | 7 +-
> drivers/mfd/Makefile | 3 +-
> drivers/mfd/{rk808.c => rk8xx-core.c} | 209 +++++---------------------
> drivers/mfd/rk8xx-i2c.c | 200 ++++++++++++++++++++++++
> drivers/pinctrl/Kconfig | 2 +-
> drivers/power/supply/Kconfig | 2 +-
> drivers/regulator/Kconfig | 2 +-
> drivers/rtc/Kconfig | 2 +-
> include/linux/mfd/rk808.h | 6 +
> sound/soc/codecs/Kconfig | 2 +-
> 12 files changed, 256 insertions(+), 183 deletions(-)
> rename drivers/mfd/{rk808.c => rk8xx-core.c} (76%)
> create mode 100644 drivers/mfd/rk8xx-i2c.c
Looks like you completely ignored (no response / no action) my review of
v4. This submission is therefore not getting one! All comments can be
superimposed from v4.
--
Lee Jones [李琼斯]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv6 05/11] mfd: rk808: split into core and i2c
Date: Sat, 4 Feb 2023 13:52:37 +0000 [thread overview]
Message-ID: <Y95jJYlqDayiaMP1@google.com> (raw)
In-Reply-To: <20230127181244.160887-6-sebastian.reichel@collabora.com>
On Fri, 27 Jan 2023, Sebastian Reichel wrote:
> Split rk808 into a core and an i2c part in preperation for
> SPI support.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> drivers/clk/Kconfig | 2 +-
> drivers/input/misc/Kconfig | 2 +-
> drivers/mfd/Kconfig | 7 +-
> drivers/mfd/Makefile | 3 +-
> drivers/mfd/{rk808.c => rk8xx-core.c} | 209 +++++---------------------
> drivers/mfd/rk8xx-i2c.c | 200 ++++++++++++++++++++++++
> drivers/pinctrl/Kconfig | 2 +-
> drivers/power/supply/Kconfig | 2 +-
> drivers/regulator/Kconfig | 2 +-
> drivers/rtc/Kconfig | 2 +-
> include/linux/mfd/rk808.h | 6 +
> sound/soc/codecs/Kconfig | 2 +-
> 12 files changed, 256 insertions(+), 183 deletions(-)
> rename drivers/mfd/{rk808.c => rk8xx-core.c} (76%)
> create mode 100644 drivers/mfd/rk8xx-i2c.c
Looks like you completely ignored (no response / no action) my review of
v4. This submission is therefore not getting one! All comments can be
superimposed from v4.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-02-04 13:53 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 18:12 [PATCHv6 00/11] Introduce RK806 Support Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-01-27 18:12 ` [PATCHv6 01/11] clk: RK808: reduce 'struct rk808' usage Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-01-27 18:12 ` [PATCHv6 02/11] mfd: rk808: convert to device managed resources Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-01-27 18:12 ` [PATCHv6 03/11] mfd: rk808: use dev_err_probe Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-01-27 18:12 ` [PATCHv6 04/11] mfd: rk808: replace 'struct i2c_client' with 'struct device' Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-01-27 18:12 ` [PATCHv6 05/11] mfd: rk808: split into core and i2c Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-01-27 20:06 ` Alexandre Belloni
2023-01-27 20:06 ` Alexandre Belloni
2023-02-04 13:52 ` Lee Jones [this message]
2023-02-04 13:52 ` Lee Jones
2023-02-04 14:01 ` Lee Jones
2023-02-04 14:01 ` Lee Jones
2023-02-05 1:06 ` Sebastian Reichel
2023-02-05 1:06 ` Sebastian Reichel
2023-02-06 18:47 ` Lee Jones
2023-02-06 18:47 ` Lee Jones
2023-03-02 16:24 ` Lee Jones
2023-03-02 16:24 ` Lee Jones
2023-01-27 18:12 ` [PATCHv6 06/11] mfd: rk8xx-i2c: use device_get_match_data Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-03-02 16:50 ` Lee Jones
2023-03-02 16:50 ` Lee Jones
2023-01-27 18:12 ` [PATCHv6 07/11] dt-bindings: mfd: add rk806 binding Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-01-27 18:12 ` [PATCHv6 08/11] mfd: rk8xx: add rk806 support Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-03-02 17:52 ` Lee Jones
2023-03-02 17:52 ` Lee Jones
2023-01-27 18:12 ` [PATCHv6 09/11] pinctrl: rk805: add rk806 pinctrl support Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-01-30 22:31 ` Linus Walleij
2023-01-30 22:31 ` Linus Walleij
2023-01-30 23:36 ` Sebastian Reichel
2023-01-30 23:36 ` Sebastian Reichel
2023-03-02 16:22 ` Lee Jones
2023-03-02 16:22 ` Lee Jones
2023-03-06 12:37 ` Linus Walleij
2023-03-06 12:37 ` Linus Walleij
2023-01-27 18:12 ` [PATCHv6 10/11] regulator: expose regulator_find_closest_bigger Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
2023-01-27 18:12 ` [PATCHv6 11/11] regulator: rk808: add rk806 support Sebastian Reichel
2023-01-27 18:12 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y95jJYlqDayiaMP1@google.com \
--to=lee@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.