From: Mike Kravetz <mike.kravetz@oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: kernel test robot <lkp@intel.com>,
netdev@vger.kernel.org, amd-gfx@lists.freedesktop.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6
Date: Tue, 24 Jan 2023 12:44:19 -0800 [thread overview]
Message-ID: <Y9BDIzZY73KjFe3X@monkey> (raw)
In-Reply-To: <54b10139-6652-6a4b-a143-0df9bcbd2910@oracle.com>
On 01/24/23 12:42, Sidhartha Kumar wrote:
> On 1/24/23 12:28 PM, Andrew Morton wrote:
> > On Wed, 25 Jan 2023 00:37:05 +0800 kernel test robot <lkp@intel.com> wrote:
> >
> > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > branch HEAD: a54df7622717a40ddec95fd98086aff8ba7839a6 Add linux-next specific files for 20230124
> > >
> > > Error/Warning: (recently discovered and may have been fixed)
> > >
> > > ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/fsl-edma.ko] undefined!
> > > ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/idma64.ko] undefined!
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_training.c:1585:38: warning: variable 'result' set but not used [-Wunused-but-set-variable]
> > >
> > > Unverified Error/Warning (likely false positive, please contact us if interested):
> > >
> > > ...
> > >
> > > mm/hugetlb.c:3100 alloc_hugetlb_folio() error: uninitialized symbol 'h_cg'.
> >
> > hugetlb_cgroup_commit_charge(idx, pages_per_huge_page(h), h_cg, folio);
> >
> > The warning looks to be bogus. I guess we could put a "= NULL" in
> > there to keep the compiler quiet?
> >
> This could be because if CONFIG_CGROUP_HUGETLB is not set, the function in
> alloc_hugetlb_folio() which initializes h_cg just returns 0
>
> static inline int hugetlb_cgroup_charge_cgroup_rsvd(int idx,
> unsigned long nr_pages,
> struct hugetlb_cgroup **ptr)
> {
> return 0;
> }
Yes!
>
> where ptr is h_cg. I can add a "= NULL" in the v2 of my hugetlb page fault
> conversion series.
Thanks
--
Mike Kravetz
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kernel test robot <lkp@intel.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org,
amd-gfx@lists.freedesktop.org,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6
Date: Tue, 24 Jan 2023 12:44:19 -0800 [thread overview]
Message-ID: <Y9BDIzZY73KjFe3X@monkey> (raw)
In-Reply-To: <54b10139-6652-6a4b-a143-0df9bcbd2910@oracle.com>
On 01/24/23 12:42, Sidhartha Kumar wrote:
> On 1/24/23 12:28 PM, Andrew Morton wrote:
> > On Wed, 25 Jan 2023 00:37:05 +0800 kernel test robot <lkp@intel.com> wrote:
> >
> > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > branch HEAD: a54df7622717a40ddec95fd98086aff8ba7839a6 Add linux-next specific files for 20230124
> > >
> > > Error/Warning: (recently discovered and may have been fixed)
> > >
> > > ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/fsl-edma.ko] undefined!
> > > ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/idma64.ko] undefined!
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_training.c:1585:38: warning: variable 'result' set but not used [-Wunused-but-set-variable]
> > >
> > > Unverified Error/Warning (likely false positive, please contact us if interested):
> > >
> > > ...
> > >
> > > mm/hugetlb.c:3100 alloc_hugetlb_folio() error: uninitialized symbol 'h_cg'.
> >
> > hugetlb_cgroup_commit_charge(idx, pages_per_huge_page(h), h_cg, folio);
> >
> > The warning looks to be bogus. I guess we could put a "= NULL" in
> > there to keep the compiler quiet?
> >
> This could be because if CONFIG_CGROUP_HUGETLB is not set, the function in
> alloc_hugetlb_folio() which initializes h_cg just returns 0
>
> static inline int hugetlb_cgroup_charge_cgroup_rsvd(int idx,
> unsigned long nr_pages,
> struct hugetlb_cgroup **ptr)
> {
> return 0;
> }
Yes!
>
> where ptr is h_cg. I can add a "= NULL" in the v2 of my hugetlb page fault
> conversion series.
Thanks
--
Mike Kravetz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kernel test robot <lkp@intel.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org,
amd-gfx@lists.freedesktop.org,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6
Date: Tue, 24 Jan 2023 12:44:19 -0800 [thread overview]
Message-ID: <Y9BDIzZY73KjFe3X@monkey> (raw)
In-Reply-To: <54b10139-6652-6a4b-a143-0df9bcbd2910@oracle.com>
On 01/24/23 12:42, Sidhartha Kumar wrote:
> On 1/24/23 12:28 PM, Andrew Morton wrote:
> > On Wed, 25 Jan 2023 00:37:05 +0800 kernel test robot <lkp@intel.com> wrote:
> >
> > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > branch HEAD: a54df7622717a40ddec95fd98086aff8ba7839a6 Add linux-next specific files for 20230124
> > >
> > > Error/Warning: (recently discovered and may have been fixed)
> > >
> > > ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/fsl-edma.ko] undefined!
> > > ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/idma64.ko] undefined!
> > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_training.c:1585:38: warning: variable 'result' set but not used [-Wunused-but-set-variable]
> > >
> > > Unverified Error/Warning (likely false positive, please contact us if interested):
> > >
> > > ...
> > >
> > > mm/hugetlb.c:3100 alloc_hugetlb_folio() error: uninitialized symbol 'h_cg'.
> >
> > hugetlb_cgroup_commit_charge(idx, pages_per_huge_page(h), h_cg, folio);
> >
> > The warning looks to be bogus. I guess we could put a "= NULL" in
> > there to keep the compiler quiet?
> >
> This could be because if CONFIG_CGROUP_HUGETLB is not set, the function in
> alloc_hugetlb_folio() which initializes h_cg just returns 0
>
> static inline int hugetlb_cgroup_charge_cgroup_rsvd(int idx,
> unsigned long nr_pages,
> struct hugetlb_cgroup **ptr)
> {
> return 0;
> }
Yes!
>
> where ptr is h_cg. I can add a "= NULL" in the v2 of my hugetlb page fault
> conversion series.
Thanks
--
Mike Kravetz
next prev parent reply other threads:[~2023-01-24 21:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 16:37 [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6 kernel test robot
2023-01-24 16:37 ` kernel test robot
2023-01-24 16:37 ` kernel test robot
2023-01-24 16:37 ` kernel test robot
2023-01-24 20:28 ` Andrew Morton
2023-01-24 20:28 ` Andrew Morton
2023-01-24 20:28 ` Andrew Morton
2023-01-24 20:28 ` Andrew Morton
2023-01-24 20:42 ` Sidhartha Kumar
2023-01-24 20:42 ` Sidhartha Kumar
2023-01-24 20:42 ` Sidhartha Kumar
2023-01-24 20:44 ` Mike Kravetz [this message]
2023-01-24 20:44 ` Mike Kravetz
2023-01-24 20:44 ` Mike Kravetz
2023-01-24 20:43 ` Mike Kravetz
2023-01-24 20:43 ` Mike Kravetz
2023-01-24 20:43 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9BDIzZY73KjFe3X@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sidhartha.kumar@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.