From: Greg KH <gregkh@linuxfoundation.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: stable@vger.kernel.org, sashal@kernel.org, x86@kernel.org,
kernel@gpiccoli.net, kernel-dev@igalia.com,
Deepak Sharma <deepak.sharma@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 5.10 / 5.15] x86: ACPI: cstate: Optimize C3 entry on AMD CPUs
Date: Thu, 26 Jan 2023 08:45:45 +0100 [thread overview]
Message-ID: <Y9IvqbdW+T5IsJH6@kroah.com> (raw)
In-Reply-To: <20230125215145.1171151-1-gpiccoli@igalia.com>
On Wed, Jan 25, 2023 at 06:51:45PM -0300, Guilherme G. Piccoli wrote:
> From: Deepak Sharma <deepak.sharma@amd.com>
>
> commit a8fb40966f19ff81520d9ccf8f7e2b95201368b8 upstream.
>
> All Zen or newer CPU which support C3 shares cache. Its not necessary to
> flush the caches in software before entering C3. This will cause drop in
> performance for the cores which share some caches. ARB_DIS is not used
> with current AMD C state implementation. So set related flags correctly.
>
> Signed-off-by: Deepak Sharma <deepak.sharma@amd.com>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
>
>
> Hi folks, this is a very simple optimization that might be read
> as a fix IMO, since it's setting the flags correctly for the Zen CPUs.
> It was built/boot tested in the Steam Deck.
>
> The backport for stable was a suggestion from Greg [0], so lemme
> know if any of you see an issue with that, or if we should target
> other stable versions (or less versions, maybe only 5.15).
> Cheers,
Looks good, thanks for the backport, now queued up!
greg k-h
prev parent reply other threads:[~2023-01-26 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 21:51 [PATCH 5.10 / 5.15] x86: ACPI: cstate: Optimize C3 entry on AMD CPUs Guilherme G. Piccoli
2023-01-26 7:45 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9IvqbdW+T5IsJH6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=deepak.sharma@amd.com \
--cc=gpiccoli@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=rafael.j.wysocki@intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.