All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrik Grimler <henrik@grimler.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	alim.akhtar@samsung.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 0/6] ARM: dts: add mmc aliases for Exynos devices
Date: Thu, 26 Jan 2023 14:19:40 +0100	[thread overview]
Message-ID: <Y9J97CU7f5qoiO/F@grimlerstat> (raw)
In-Reply-To: <0807a4ab-c544-2695-67d4-df9a3b1de4cf@linaro.org>

Hi Krzysztof,

On Thu, Jan 26, 2023 at 01:22:54PM +0100, Krzysztof Kozlowski wrote:
> On 26/01/2023 11:38, Henrik Grimler wrote:
> > It is convenient to have fixed mmcblk numbering of the eMMC and
> > sdcard, and with these aliases all Exynos 4 and 5 devices (and
> > probably Exynos 3, but I do not have one of those boards so cannot
> > verify) will have the eMMC as mmc0 and sdcard as mmc2.
> > 
> > I also removed sdhc aliases, as they should not be needed after [1] as
> > I understand it.
> > 
> > [1] https://lkml.kernel.org/lkml/20211124184603.3897245-1-john@metanate.com/
> 
> Marek sent the same in the past:
> https://lore.kernel.org/all/?q=%22exynos%3A+Use+fixed+index+for+the+MMC+devices%22
> 
> The patches are fine for me except, that these actually do not belong to
> DTSI. Aliases for board or user-exposable interfaces are actually board
> specific and each board should customize the ones it uses.

Thanks for reviewing!  I will change the series to only add aliases to
the boards I am familiar with.

> Best regards,
> Krzysztof

Best regards,
Henrik Grimler

WARNING: multiple messages have this Message-ID (diff)
From: Henrik Grimler <henrik@grimler.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	alim.akhtar@samsung.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 0/6] ARM: dts: add mmc aliases for Exynos devices
Date: Thu, 26 Jan 2023 14:19:40 +0100	[thread overview]
Message-ID: <Y9J97CU7f5qoiO/F@grimlerstat> (raw)
In-Reply-To: <0807a4ab-c544-2695-67d4-df9a3b1de4cf@linaro.org>

Hi Krzysztof,

On Thu, Jan 26, 2023 at 01:22:54PM +0100, Krzysztof Kozlowski wrote:
> On 26/01/2023 11:38, Henrik Grimler wrote:
> > It is convenient to have fixed mmcblk numbering of the eMMC and
> > sdcard, and with these aliases all Exynos 4 and 5 devices (and
> > probably Exynos 3, but I do not have one of those boards so cannot
> > verify) will have the eMMC as mmc0 and sdcard as mmc2.
> > 
> > I also removed sdhc aliases, as they should not be needed after [1] as
> > I understand it.
> > 
> > [1] https://lkml.kernel.org/lkml/20211124184603.3897245-1-john@metanate.com/
> 
> Marek sent the same in the past:
> https://lore.kernel.org/all/?q=%22exynos%3A+Use+fixed+index+for+the+MMC+devices%22
> 
> The patches are fine for me except, that these actually do not belong to
> DTSI. Aliases for board or user-exposable interfaces are actually board
> specific and each board should customize the ones it uses.

Thanks for reviewing!  I will change the series to only add aliases to
the boards I am familiar with.

> Best regards,
> Krzysztof

Best regards,
Henrik Grimler

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-01-26 13:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 10:38 [PATCH 0/6] ARM: dts: add mmc aliases for Exynos devices Henrik Grimler
2023-01-26 10:38 ` Henrik Grimler
2023-01-26 10:38 ` [PATCH 1/6] ARM: dts: exynos: add mmc aliases for Exynos3250 Henrik Grimler
2023-01-26 10:38   ` Henrik Grimler
2023-01-26 10:38 ` [PATCH 2/6] ARM: dts: exynos: add mmc aliases for Exynos4210 Henrik Grimler
2023-01-26 10:38   ` Henrik Grimler
2023-01-26 10:38 ` [PATCH 3/6] ARM: dts: exynos: add mmc aliases for Exynos4412 Henrik Grimler
2023-01-26 10:38   ` Henrik Grimler
2023-01-26 12:24   ` Krzysztof Kozlowski
2023-01-26 12:24     ` Krzysztof Kozlowski
2023-01-26 10:38 ` [PATCH 4/6] ARM: dts: exynos: add mmc aliases for Exynos5250 Henrik Grimler
2023-01-26 10:38   ` Henrik Grimler
2023-01-26 10:38 ` [PATCH 5/6] ARM: dts: exynos: add mmc aliases for Exynos5410 Henrik Grimler
2023-01-26 10:38   ` Henrik Grimler
2023-01-26 10:38 ` [PATCH 6/6] ARM: dts: exynos: add mmc aliases for Exynos5420 Henrik Grimler
2023-01-26 10:38   ` Henrik Grimler
2023-01-26 12:22 ` [PATCH 0/6] ARM: dts: add mmc aliases for Exynos devices Krzysztof Kozlowski
2023-01-26 12:22   ` Krzysztof Kozlowski
2023-01-26 13:19   ` Henrik Grimler [this message]
2023-01-26 13:19     ` Henrik Grimler
2023-01-26 13:28     ` Krzysztof Kozlowski
2023-01-26 13:28       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9J97CU7f5qoiO/F@grimlerstat \
    --to=henrik@grimler.se \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.