* [PATCH] drm/simpledrm: Fix an NULL vs IS_ERR() bug
@ 2023-01-26 9:28 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2023-01-26 9:28 UTC (permalink / raw)
To: Thierry Reding, Thomas Zimmermann
Cc: Javier Martinez Canillas, David Airlie, Daniel Vetter, dri-devel,
kernel-janitors
The devm_memremap() function doesn't return NULL, it returns error
pointers.
Fixes: 9a10c7e6519b ("drm/simpledrm: Add support for system memory framebuffers")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/gpu/drm/tiny/simpledrm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
index 2acc0eb32489..63881a3754f8 100644
--- a/drivers/gpu/drm/tiny/simpledrm.c
+++ b/drivers/gpu/drm/tiny/simpledrm.c
@@ -719,8 +719,8 @@ static struct simpledrm_device *simpledrm_device_create(struct drm_driver *drv,
drm_dbg(dev, "using system memory framebuffer at %pr\n", mem);
screen_base = devm_memremap(dev->dev, mem->start, resource_size(mem), MEMREMAP_WC);
- if (!screen_base)
- return ERR_PTR(-ENOMEM);
+ if (IS_ERR(screen_base))
+ return screen_base;
iosys_map_set_vaddr(&sdev->screen_base, screen_base);
} else {
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] drm/simpledrm: Fix an NULL vs IS_ERR() bug
@ 2023-01-26 9:28 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2023-01-26 9:28 UTC (permalink / raw)
To: Thierry Reding, Thomas Zimmermann
Cc: kernel-janitors, dri-devel, Javier Martinez Canillas
The devm_memremap() function doesn't return NULL, it returns error
pointers.
Fixes: 9a10c7e6519b ("drm/simpledrm: Add support for system memory framebuffers")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/gpu/drm/tiny/simpledrm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
index 2acc0eb32489..63881a3754f8 100644
--- a/drivers/gpu/drm/tiny/simpledrm.c
+++ b/drivers/gpu/drm/tiny/simpledrm.c
@@ -719,8 +719,8 @@ static struct simpledrm_device *simpledrm_device_create(struct drm_driver *drv,
drm_dbg(dev, "using system memory framebuffer at %pr\n", mem);
screen_base = devm_memremap(dev->dev, mem->start, resource_size(mem), MEMREMAP_WC);
- if (!screen_base)
- return ERR_PTR(-ENOMEM);
+ if (IS_ERR(screen_base))
+ return screen_base;
iosys_map_set_vaddr(&sdev->screen_base, screen_base);
} else {
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/simpledrm: Fix an NULL vs IS_ERR() bug
2023-01-26 9:28 ` Dan Carpenter
@ 2023-01-26 12:52 ` Thomas Zimmermann
-1 siblings, 0 replies; 8+ messages in thread
From: Thomas Zimmermann @ 2023-01-26 12:52 UTC (permalink / raw)
To: Dan Carpenter, Thierry Reding
Cc: kernel-janitors, dri-devel, Javier Martinez Canillas
[-- Attachment #1.1: Type: text/plain, Size: 1308 bytes --]
Am 26.01.23 um 10:28 schrieb Dan Carpenter:
> The devm_memremap() function doesn't return NULL, it returns error
> pointers.
>
> Fixes: 9a10c7e6519b ("drm/simpledrm: Add support for system memory framebuffers")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/tiny/simpledrm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
> index 2acc0eb32489..63881a3754f8 100644
> --- a/drivers/gpu/drm/tiny/simpledrm.c
> +++ b/drivers/gpu/drm/tiny/simpledrm.c
> @@ -719,8 +719,8 @@ static struct simpledrm_device *simpledrm_device_create(struct drm_driver *drv,
> drm_dbg(dev, "using system memory framebuffer at %pr\n", mem);
>
> screen_base = devm_memremap(dev->dev, mem->start, resource_size(mem), MEMREMAP_WC);
> - if (!screen_base)
> - return ERR_PTR(-ENOMEM);
> + if (IS_ERR(screen_base))
> + return screen_base;
>
> iosys_map_set_vaddr(&sdev->screen_base, screen_base);
> } else {
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/simpledrm: Fix an NULL vs IS_ERR() bug
@ 2023-01-26 12:52 ` Thomas Zimmermann
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Zimmermann @ 2023-01-26 12:52 UTC (permalink / raw)
To: Dan Carpenter, Thierry Reding
Cc: kernel-janitors, Javier Martinez Canillas, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1308 bytes --]
Am 26.01.23 um 10:28 schrieb Dan Carpenter:
> The devm_memremap() function doesn't return NULL, it returns error
> pointers.
>
> Fixes: 9a10c7e6519b ("drm/simpledrm: Add support for system memory framebuffers")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/tiny/simpledrm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
> index 2acc0eb32489..63881a3754f8 100644
> --- a/drivers/gpu/drm/tiny/simpledrm.c
> +++ b/drivers/gpu/drm/tiny/simpledrm.c
> @@ -719,8 +719,8 @@ static struct simpledrm_device *simpledrm_device_create(struct drm_driver *drv,
> drm_dbg(dev, "using system memory framebuffer at %pr\n", mem);
>
> screen_base = devm_memremap(dev->dev, mem->start, resource_size(mem), MEMREMAP_WC);
> - if (!screen_base)
> - return ERR_PTR(-ENOMEM);
> + if (IS_ERR(screen_base))
> + return screen_base;
>
> iosys_map_set_vaddr(&sdev->screen_base, screen_base);
> } else {
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/simpledrm: Fix an NULL vs IS_ERR() bug
2023-01-26 9:28 ` Dan Carpenter
@ 2023-01-26 16:18 ` Thierry Reding
-1 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2023-01-26 16:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Thierry Reding, Thomas Zimmermann, kernel-janitors, dri-devel,
Javier Martinez Canillas
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
On Thu, Jan 26, 2023 at 12:28:44PM +0300, Dan Carpenter wrote:
> The devm_memremap() function doesn't return NULL, it returns error
> pointers.
>
> Fixes: 9a10c7e6519b ("drm/simpledrm: Add support for system memory framebuffers")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/gpu/drm/tiny/simpledrm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Good catch! Applied to drm-misc-next, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/simpledrm: Fix an NULL vs IS_ERR() bug
@ 2023-01-26 16:18 ` Thierry Reding
0 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2023-01-26 16:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Thierry Reding, kernel-janitors, dri-devel, Thomas Zimmermann,
Javier Martinez Canillas
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
On Thu, Jan 26, 2023 at 12:28:44PM +0300, Dan Carpenter wrote:
> The devm_memremap() function doesn't return NULL, it returns error
> pointers.
>
> Fixes: 9a10c7e6519b ("drm/simpledrm: Add support for system memory framebuffers")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/gpu/drm/tiny/simpledrm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Good catch! Applied to drm-misc-next, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/simpledrm: Fix an NULL vs IS_ERR() bug
2023-01-26 16:18 ` Thierry Reding
@ 2023-02-01 10:32 ` Thomas Zimmermann
-1 siblings, 0 replies; 8+ messages in thread
From: Thomas Zimmermann @ 2023-02-01 10:32 UTC (permalink / raw)
To: Thierry Reding, Dan Carpenter
Cc: Thierry Reding, kernel-janitors, dri-devel,
Javier Martinez Canillas
[-- Attachment #1.1: Type: text/plain, Size: 773 bytes --]
Am 26.01.23 um 17:18 schrieb Thierry Reding:
> On Thu, Jan 26, 2023 at 12:28:44PM +0300, Dan Carpenter wrote:
>> The devm_memremap() function doesn't return NULL, it returns error
>> pointers.
>>
>> Fixes: 9a10c7e6519b ("drm/simpledrm: Add support for system memory framebuffers")
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>> ---
>> drivers/gpu/drm/tiny/simpledrm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Good catch! Applied to drm-misc-next, thanks.
I have cherry-picked the patch into drm-misc-next-fixes.
>
> Thierry
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/simpledrm: Fix an NULL vs IS_ERR() bug
@ 2023-02-01 10:32 ` Thomas Zimmermann
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Zimmermann @ 2023-02-01 10:32 UTC (permalink / raw)
To: Thierry Reding, Dan Carpenter
Cc: Thierry Reding, kernel-janitors, Javier Martinez Canillas,
dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 773 bytes --]
Am 26.01.23 um 17:18 schrieb Thierry Reding:
> On Thu, Jan 26, 2023 at 12:28:44PM +0300, Dan Carpenter wrote:
>> The devm_memremap() function doesn't return NULL, it returns error
>> pointers.
>>
>> Fixes: 9a10c7e6519b ("drm/simpledrm: Add support for system memory framebuffers")
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>> ---
>> drivers/gpu/drm/tiny/simpledrm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Good catch! Applied to drm-misc-next, thanks.
I have cherry-picked the patch into drm-misc-next-fixes.
>
> Thierry
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-02-01 10:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-26 9:28 [PATCH] drm/simpledrm: Fix an NULL vs IS_ERR() bug Dan Carpenter
2023-01-26 9:28 ` Dan Carpenter
2023-01-26 12:52 ` Thomas Zimmermann
2023-01-26 12:52 ` Thomas Zimmermann
2023-01-26 16:18 ` Thierry Reding
2023-01-26 16:18 ` Thierry Reding
2023-02-01 10:32 ` Thomas Zimmermann
2023-02-01 10:32 ` Thomas Zimmermann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.