From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Jó Ágila Bitsch" <jgilab@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] usb: gadget: Use correct APIs and data types for UUID handling
Date: Thu, 26 Jan 2023 12:15:09 +0200 [thread overview]
Message-ID: <Y9JSrWafclaTmLwP@smile.fi.intel.com> (raw)
In-Reply-To: <CAMUOyH163WY3Csbs8QOy6VssrR9TXZRi6ChnqPn=PO7z12rZOQ@mail.gmail.com>
On Wed, Jan 25, 2023 at 10:54:58PM +0100, Jó Ágila Bitsch wrote:
> On Wed, Jan 25, 2023 at 9:01 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Jan 25, 2023 at 06:31:36PM +0100, Jó Ágila Bitsch wrote:
> > > On Wed, Jan 25, 2023 at 3:34 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
...
> > > I compiled and tested your patch in my test setup and it works perfectly.
> >
> > Thanks for the testing. According to Submitting Patches documentation
> > you can provide a formal Tested-by tag.
>
> Thanks for pointing this out to me.
>
> I'm not really sure how to do that though.
> On https://docs.kernel.org/process/submitting-patches.html#reviewer-s-statement-of-oversight,
> it says:
> > Both Tested-by and Reviewed-by tags, once received on mailing list from tester or reviewer, should be added by author to the applicable patches when sending next versions.
>
> So I guess you could do that at your convenience on any next version.
In mine I can only do if you give me that tag. Till this
line the tag is not given, but...
> Or is it already ok, if I just add the following line in my comment?
...this is what is expected to have.
> Tested-By: Jó Ágila Bitsch <jgilab@gmail.com>
And now _if_ I need a new version I will bear this with it. Otherwise
maintainer, who picks up the patch, takes care of gathering these all
together.
> I'm still quite a newbie in the kernel development community, so
> thanks for bearing with my ignorance :-)
So far you are doing good, thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-01-26 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 14:34 [PATCH v1 1/1] usb: gadget: Use correct APIs and data types for UUID handling Andy Shevchenko
2023-01-25 17:31 ` Jó Ágila Bitsch
2023-01-25 20:01 ` Andy Shevchenko
2023-01-25 21:54 ` Jó Ágila Bitsch
2023-01-26 10:15 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9JSrWafclaTmLwP@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgilab@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.