From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] spi: sh-msiof: Enforce fixed DTDL for R-Car H3
Date: Thu, 26 Jan 2023 14:40:48 +0100 [thread overview]
Message-ID: <Y9KC4Pu/AnnXOLhI@ninjato> (raw)
In-Reply-To: <CAMuHMdXRBYhR+_+r+akZ5nKYPgpVKMNEHB5KCP_pnPJYtHvU=A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
> > I have to disagree here. The docs say that other values are prohibited.
> > IMO the driver should take care of valid values then. We should not rely
> > on user provided input.
>
> Then we should make sure the user cannot override to an invalid value
> through "renesas,dtdl" either?
We do. The new flag is checked after sh_msiof_spi_parse_dt(), so any
user input will be overwritten with the only value allowed.
> To be clarified with Renesas?
Frankly, I don't think it is worth the hazzle and just stick to the
latest docs. Yes, they may be inaccurate for ES2.0 but what is the
downside? Will it break things or is this just a little overhead?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-01-26 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 7:47 [PATCH] spi: sh-msiof: Enforce fixed DTDL for R-Car H3 Wolfram Sang
2023-01-26 9:57 ` Geert Uytterhoeven
2023-01-26 13:07 ` Wolfram Sang
2023-01-26 13:26 ` Geert Uytterhoeven
2023-01-26 13:40 ` Wolfram Sang [this message]
2023-01-26 13:43 ` Geert Uytterhoeven
2023-02-15 8:02 ` Geert Uytterhoeven
2023-02-16 2:59 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9KC4Pu/AnnXOLhI@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.