From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
matthias.bgg@gmail.com, john@phrozen.org, sean.wang@mediatek.com,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node
Date: Mon, 30 Jan 2023 16:54:56 +0100 [thread overview]
Message-ID: <Y9foUMtlMZfZ18nr@orome> (raw)
In-Reply-To: <20221202180932.5k3vymrwds5ssivq@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]
On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-König wrote:
> On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote:
> > Specify #pwm-cells on pwm@11006000 to make it actually usable.
> >
> > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes")
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > index 146e18b5b1f4..f321c6d0fd7c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > @@ -435,6 +435,7 @@ uart3: serial@11005000 {
> > pwm: pwm@11006000 {
> > compatible = "mediatek,mt7622-pwm";
> > reg = <0 0x11006000 0 0x1000>;
> > + #pwm-cells = <2>;
>
> 3 should be possible, too. The driver does only support one
> polarity, so it's not really needed, but would be nice for consistency?
>
> Thierry, what's your take here?
There's little point in setting this to 3 if the driver doesn't support
it. The core should catch misconfiguration, but that's more of a fail-
safe and if we can just avoid this from the start by not allowing anyone
to specify inversed polarity that seems like a good idea.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
matthias.bgg@gmail.com, john@phrozen.org, sean.wang@mediatek.com,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node
Date: Mon, 30 Jan 2023 16:54:56 +0100 [thread overview]
Message-ID: <Y9foUMtlMZfZ18nr@orome> (raw)
In-Reply-To: <20221202180932.5k3vymrwds5ssivq@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1417 bytes --]
On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-König wrote:
> On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote:
> > Specify #pwm-cells on pwm@11006000 to make it actually usable.
> >
> > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes")
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > index 146e18b5b1f4..f321c6d0fd7c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > @@ -435,6 +435,7 @@ uart3: serial@11005000 {
> > pwm: pwm@11006000 {
> > compatible = "mediatek,mt7622-pwm";
> > reg = <0 0x11006000 0 0x1000>;
> > + #pwm-cells = <2>;
>
> 3 should be possible, too. The driver does only support one
> polarity, so it's not really needed, but would be nice for consistency?
>
> Thierry, what's your take here?
There's little point in setting this to 3 if the driver doesn't support
it. The core should catch misconfiguration, but that's more of a fail-
safe and if we can just avoid this from the start by not allowing anyone
to specify inversed polarity that seems like a good idea.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-30 15:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 11:20 [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes AngeloGioacchino Del Regno
2022-11-28 11:20 ` AngeloGioacchino Del Regno
2022-11-28 11:20 ` [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node AngeloGioacchino Del Regno
2022-11-28 11:20 ` AngeloGioacchino Del Regno
2022-12-02 18:09 ` Uwe Kleine-König
2022-12-02 18:09 ` Uwe Kleine-König
2023-01-17 21:39 ` Uwe Kleine-König
2023-01-17 21:39 ` Uwe Kleine-König
2023-01-19 17:33 ` Matthias Brugger
2023-01-19 17:33 ` Matthias Brugger
2023-01-30 15:54 ` Thierry Reding [this message]
2023-01-30 15:54 ` Thierry Reding
2023-02-01 10:56 ` Matthias Brugger
2023-02-01 10:56 ` Matthias Brugger
2022-11-28 11:20 ` [PATCH v1 2/2] dt-bindings: pwm: mediatek: Convert pwm-mediatek to dt schema AngeloGioacchino Del Regno
2022-11-28 11:20 ` AngeloGioacchino Del Regno
2022-11-29 13:58 ` Krzysztof Kozlowski
2022-11-29 13:58 ` Krzysztof Kozlowski
2023-01-30 15:46 ` (subset) [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes Thierry Reding
2023-01-30 15:46 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9foUMtlMZfZ18nr@orome \
--to=thierry.reding@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.