From: Stefan Hajnoczi <stefanha@redhat.com>
To: Bo Liu <liubo03@inspur.com>
Cc: kvm@vger.kernel.org, mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pbonzini@redhat.com
Subject: Re: [PATCH] vhost-scsi: convert sysfs snprintf and sprintf to sysfs_emit
Date: Mon, 30 Jan 2023 14:33:15 -0500 [thread overview]
Message-ID: <Y9gbe+Pr5AcGbcta@fedora> (raw)
In-Reply-To: <20230129091145.2837-1-liubo03@inspur.com>
[-- Attachment #1.1: Type: text/plain, Size: 441 bytes --]
On Sun, Jan 29, 2023 at 04:11:45AM -0500, Bo Liu wrote:
> Follow the advice of the Documentation/filesystems/sysfs.rst
> and show() should only use sysfs_emit() or sysfs_emit_at()
> when formatting the value to be returned to user space.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
> ---
> drivers/vhost/scsi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Bo Liu <liubo03@inspur.com>
Cc: mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vhost-scsi: convert sysfs snprintf and sprintf to sysfs_emit
Date: Mon, 30 Jan 2023 14:33:15 -0500 [thread overview]
Message-ID: <Y9gbe+Pr5AcGbcta@fedora> (raw)
In-Reply-To: <20230129091145.2837-1-liubo03@inspur.com>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
On Sun, Jan 29, 2023 at 04:11:45AM -0500, Bo Liu wrote:
> Follow the advice of the Documentation/filesystems/sysfs.rst
> and show() should only use sysfs_emit() or sysfs_emit_at()
> when formatting the value to be returned to user space.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
> ---
> drivers/vhost/scsi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-30 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 9:11 [PATCH] vhost-scsi: convert sysfs snprintf and sprintf to sysfs_emit Bo Liu
2023-01-29 10:32 ` Simon Horman
2023-01-30 19:33 ` Stefan Hajnoczi [this message]
2023-01-30 19:33 ` Stefan Hajnoczi
2023-01-31 7:00 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9gbe+Pr5AcGbcta@fedora \
--to=stefanha@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo03@inspur.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.