From: John Watts <contact@jookia.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 3/4] ARM: novena: Read Ethernet MAC address from EEPROM
Date: Tue, 31 Jan 2023 07:25:42 +1100 [thread overview]
Message-ID: <Y9gnxmdaHL4LXklH@novena-choice-citizen> (raw)
In-Reply-To: <20230130200443.mybfhzrcsywqw65v@pengutronix.de>
On Mon, Jan 30, 2023 at 09:04:43PM +0100, Marco Felsch wrote:
> Hi John,
>
> thanks for the patch.
Thanks for the review as always :)
> This will trigger a double free since you're use of an unconditional
> free() during probe().
It returns NULL, so probe will do a no-op.
>
> Regards,
> Marco
John.
next prev parent reply other threads:[~2023-01-30 20:28 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 17:51 [PATCH 0/5] Add support for the Kosagi Novena board John Watts
2023-01-22 17:51 ` [PATCH 1/5] ARM: novena: Add " John Watts
2023-01-23 9:20 ` Sascha Hauer
2023-01-22 17:51 ` [PATCH 2/5] ARM: novena: Setup RAM using static configuration John Watts
2023-01-22 17:51 ` [PATCH 3/5] ARM: novena: Require the PFUZE regulator John Watts
2023-01-22 17:51 ` [PATCH 4/5] ARM: novena: Read Ethernet MAC address from EEPROM John Watts
2023-01-23 9:33 ` Sascha Hauer
2023-01-23 9:55 ` John Watts
2023-01-24 18:35 ` John Watts
2023-01-25 8:04 ` Sascha Hauer
2023-01-25 8:11 ` John Watts
2023-01-25 8:19 ` Sascha Hauer
2023-01-25 13:31 ` John Watts
2023-01-25 13:48 ` Ahmad Fatoum
2023-01-25 14:04 ` John Watts
2023-01-25 14:16 ` Ahmad Fatoum
2023-01-25 14:28 ` John Watts
2023-01-25 14:33 ` Ahmad Fatoum
2023-01-25 14:50 ` John Watts
2023-01-25 15:42 ` Sascha Hauer
2023-01-25 16:13 ` John Watts
2023-01-22 17:51 ` [PATCH 5/5] ARM: novena: Use DDR3 information from SPD EEPROM John Watts
2023-01-22 23:20 ` John Watts
2023-01-25 16:42 ` [PATCH v2 0/4] Add support for the Kosagi Novena board John Watts
2023-01-25 16:42 ` [PATCH v2 1/4] ARM: novena: Add " John Watts
2023-01-25 19:33 ` Marco Felsch
2023-01-26 7:25 ` Sascha Hauer
2023-01-26 7:50 ` John Watts
2023-01-26 9:13 ` Marco Felsch
2023-01-25 16:42 ` [PATCH v2 2/4] ARM: novena: Setup RAM using static configuration John Watts
2023-01-25 19:39 ` Marco Felsch
2023-01-26 7:54 ` John Watts
2023-01-26 8:11 ` Sascha Hauer
2023-01-26 9:14 ` Marco Felsch
2023-01-25 16:42 ` [PATCH v2 3/4] ARM: novena: Read Ethernet MAC address from EEPROM John Watts
2023-01-25 20:07 ` Marco Felsch
2023-01-26 8:05 ` John Watts
2023-01-26 9:07 ` Marco Felsch
2023-01-25 16:42 ` [PATCH v2 4/4] ARM: novena: Use DDR3 information from SPD EEPROM John Watts
2023-01-29 23:27 ` [PATCH v3 0/4] Add support for the Kosagi Novena board John Watts
2023-01-29 23:27 ` [PATCH v3 1/4] ARM: novena: Add " John Watts
2023-01-30 20:13 ` Marco Felsch
2023-01-30 20:26 ` John Watts
2023-01-31 9:45 ` Marco Felsch
2023-01-29 23:27 ` [PATCH v3 2/4] ARM: novena: Setup RAM using static configuration John Watts
2023-01-29 23:27 ` [PATCH v3 3/4] ARM: novena: Read Ethernet MAC address from EEPROM John Watts
2023-01-30 20:04 ` Marco Felsch
2023-01-30 20:25 ` John Watts [this message]
2023-01-31 9:29 ` Marco Felsch
2023-01-29 23:28 ` [PATCH v3 4/4] ARM: novena: Use DDR3 information from SPD EEPROM John Watts
2023-01-30 20:18 ` Marco Felsch
2023-01-30 20:41 ` John Watts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9gnxmdaHL4LXklH@novena-choice-citizen \
--to=contact@jookia.org \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.