Re: [PATCH v3 4/4] ARM: novena: Use DDR3 information from SPD EEPROM

[John Watts <contact@jookia.org>]

On Mon, Jan 30, 2023 at 09:18:24PM +0100, Marco Felsch wrote:
> > +	if (eeprom->ddr3.mem_type != 0x0b) {
> 
> Is this parameter and value standarized?
> 
> > +		pr_err("SPD data is not DDR3\n");
> > +		return false;
> > +	}
> > +
> > +	if ((eeprom->ddr3.bus_width & 0x1f) != 0x03) {
> 
> Same question as above. Would be nice to avoid magic numbers if this is
> the case.

I believe it's standard. I could add some comments but the standard itself
isn't publicly available unless you can find it re-uploaded online.

> 
> Regards,
>   Marco

John.