From: Conor Dooley <conor@kernel.org>
To: Sia Jee Heng <jeeheng.sia@starfivetech.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, leyfoon.tan@starfivetech.com,
mason.huo@starfivetech.com
Subject: Re: [PATCH v3 1/4] RISC-V: Change suspend_save_csrs and suspend_restore_csrs to public function
Date: Mon, 30 Jan 2023 23:31:37 +0000 [thread overview]
Message-ID: <Y9hTWRaShrsjm2gP@spud> (raw)
In-Reply-To: <20230127091051.1465278-2-jeeheng.sia@starfivetech.com>
[-- Attachment #1.1: Type: text/plain, Size: 372 bytes --]
On Fri, Jan 27, 2023 at 05:10:48PM +0800, Sia Jee Heng wrote:
> Currently suspend_save_csrs() and suspend_restore_csrs() functions are
> statically defined in the suspend.c. Change the function's attribute
> to public so that the functions can be used by hibernation as well.
Seems reasonable to me!
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Sia Jee Heng <jeeheng.sia@starfivetech.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, leyfoon.tan@starfivetech.com,
mason.huo@starfivetech.com
Subject: Re: [PATCH v3 1/4] RISC-V: Change suspend_save_csrs and suspend_restore_csrs to public function
Date: Mon, 30 Jan 2023 23:31:37 +0000 [thread overview]
Message-ID: <Y9hTWRaShrsjm2gP@spud> (raw)
In-Reply-To: <20230127091051.1465278-2-jeeheng.sia@starfivetech.com>
[-- Attachment #1: Type: text/plain, Size: 372 bytes --]
On Fri, Jan 27, 2023 at 05:10:48PM +0800, Sia Jee Heng wrote:
> Currently suspend_save_csrs() and suspend_restore_csrs() functions are
> statically defined in the suspend.c. Change the function's attribute
> to public so that the functions can be used by hibernation as well.
Seems reasonable to me!
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-30 23:31 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 9:10 [PATCH v3 0/4] RISC-V Hibernation Support Sia Jee Heng
2023-01-27 9:10 ` Sia Jee Heng
2023-01-27 9:10 ` [PATCH v3 1/4] RISC-V: Change suspend_save_csrs and suspend_restore_csrs to public function Sia Jee Heng
2023-01-27 9:10 ` Sia Jee Heng
2023-01-30 23:31 ` Conor Dooley [this message]
2023-01-30 23:31 ` Conor Dooley
2023-01-27 9:10 ` [PATCH v3 2/4] RISC-V: Factor out common code of __cpu_resume_enter() Sia Jee Heng
2023-01-27 9:10 ` Sia Jee Heng
2023-01-30 21:49 ` Conor Dooley
2023-01-30 21:49 ` Conor Dooley
2023-02-01 6:19 ` JeeHeng Sia
2023-02-01 6:19 ` JeeHeng Sia
2023-01-27 9:10 ` [PATCH v3 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function Sia Jee Heng
2023-01-27 9:10 ` Sia Jee Heng
2023-01-30 21:57 ` Conor Dooley
2023-01-30 21:57 ` Conor Dooley
2023-01-31 8:19 ` Alexandre Ghiti
2023-01-31 8:19 ` Alexandre Ghiti
2023-02-01 5:48 ` JeeHeng Sia
2023-02-01 5:48 ` JeeHeng Sia
2023-01-27 9:10 ` [PATCH v3 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk Sia Jee Heng
2023-01-27 9:10 ` Sia Jee Heng
2023-01-30 23:30 ` Conor Dooley
2023-01-30 23:30 ` Conor Dooley
2023-01-31 9:59 ` Alexandre Ghiti
2023-01-31 9:59 ` Alexandre Ghiti
2023-02-07 4:58 ` JeeHeng Sia
2023-02-07 4:58 ` JeeHeng Sia
2023-02-07 5:27 ` Alexandre Ghiti
2023-02-07 5:27 ` Alexandre Ghiti
2023-02-02 2:43 ` JeeHeng Sia
2023-02-02 2:43 ` JeeHeng Sia
2023-02-03 3:43 ` JeeHeng Sia
2023-02-03 3:43 ` JeeHeng Sia
2023-02-03 6:30 ` Conor Dooley
2023-02-03 6:30 ` Conor Dooley
2023-02-04 20:42 ` kernel test robot
2023-02-04 20:42 ` kernel test robot
2023-02-07 15:46 ` Alexandre Ghiti
2023-02-07 15:46 ` Alexandre Ghiti
2023-02-08 4:43 ` JeeHeng Sia
2023-02-08 4:43 ` JeeHeng Sia
2023-02-08 12:04 ` Alexandre Ghiti
2023-02-08 12:04 ` Alexandre Ghiti
2023-02-09 6:12 ` JeeHeng Sia
2023-02-09 6:12 ` JeeHeng Sia
2023-02-10 13:24 ` Alexandre Ghiti
2023-02-10 13:24 ` Alexandre Ghiti
2023-02-13 1:51 ` JeeHeng Sia
2023-02-13 1:51 ` JeeHeng Sia
2023-02-14 6:57 ` Alexandre Ghiti
2023-02-14 6:57 ` Alexandre Ghiti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9hTWRaShrsjm2gP@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=jeeheng.sia@starfivetech.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mason.huo@starfivetech.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.