From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Natalia Petrova <n.petrova@fintech.ru>
Cc: lvc-project@linuxtesting.org, intel-wired-lan@lists.osuosl.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH v2] i40e: Add checking for null for nlmsg_find_attr()
Date: Tue, 31 Jan 2023 06:17:49 +0100 [thread overview]
Message-ID: <Y9ikffXU/qV1DV7f@kroah.com> (raw)
In-Reply-To: <20230130221106.19267-1-n.petrova@fintech.ru>
On Tue, Jan 31, 2023 at 01:11:06AM +0300, Natalia Petrova wrote:
> The result of nlmsg_find_attr() 'br_spec' is dereferenced in
> nla_for_each_nested(), but it can take null value in nla_find() function,
> which will result in an error.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 51616018dd1b ("i40e: Add support for getlink, setlink ndo ops")
> Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> v2: The remark about the error code by Simon Horman <simon.horman@corigine.com>
> was taken into account; return value -ENOENT was changed to -EINVAL.
> drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Natalia Petrova <n.petrova@fintech.ru>
Cc: stable@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH v2] i40e: Add checking for null for nlmsg_find_attr()
Date: Tue, 31 Jan 2023 06:17:49 +0100 [thread overview]
Message-ID: <Y9ikffXU/qV1DV7f@kroah.com> (raw)
In-Reply-To: <20230130221106.19267-1-n.petrova@fintech.ru>
On Tue, Jan 31, 2023 at 01:11:06AM +0300, Natalia Petrova wrote:
> The result of nlmsg_find_attr() 'br_spec' is dereferenced in
> nla_for_each_nested(), but it can take null value in nla_find() function,
> which will result in an error.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 51616018dd1b ("i40e: Add support for getlink, setlink ndo ops")
> Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> v2: The remark about the error code by Simon Horman <simon.horman@corigine.com>
> was taken into account; return value -ENOENT was changed to -EINVAL.
> drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2023-01-31 5:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 14:13 [Intel-wired-lan] [PATCH] i40e: Add checking for null for nlmsg_find_attr() Natalia Petrova
2023-01-25 14:13 ` Natalia Petrova
2023-01-25 15:08 ` [Intel-wired-lan] " Simon Horman
2023-01-25 15:08 ` Simon Horman
2023-01-25 15:57 ` Deepak R Varma
2023-01-25 20:09 ` [Intel-wired-lan] " Paul Menzel
2023-01-25 20:09 ` Paul Menzel
2023-01-30 22:11 ` [Intel-wired-lan] [PATCH v2] " Natalia Petrova
2023-01-30 22:11 ` Natalia Petrova
2023-01-30 22:13 ` kernel test robot
2023-01-31 5:17 ` Greg Kroah-Hartman [this message]
2023-01-31 5:17 ` Greg Kroah-Hartman
2023-01-31 16:23 ` [Intel-wired-lan] " Simon Horman
2023-01-31 16:23 ` Simon Horman
2023-02-01 9:06 ` [Intel-wired-lan] [PATCH v3] " Natalia Petrova
2023-02-01 9:06 ` Natalia Petrova
2023-02-02 17:23 ` [Intel-wired-lan] " Tony Nguyen
2023-02-02 17:23 ` Tony Nguyen
2023-02-07 10:48 ` [Intel-wired-lan] " G, GurucharanX
2023-02-07 10:48 ` G, GurucharanX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9ikffXU/qV1DV7f@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=n.petrova@fintech.ru \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.