All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corentin LABBE <clabbe@baylibre.com>
To: troy.lin@rock-chips.com, shawn.lin@rock-chips.com,
	hl@rock-chips.com, ty@wevs.org, mike.rudenko@gmail.com
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org, robin.murphy@arm.com
Subject: Re: [PATCH] hw_random: rockchip: import driver from vendor tree
Date: Tue, 31 Jan 2023 11:34:37 +0100	[thread overview]
Message-ID: <Y9juvficPxFUfgHD@Red> (raw)
In-Reply-To: <32f8797a-4b65-69df-ee8e-7891a6b4f1af@arm.com>

Le Tue, Sep 20, 2022 at 10:35:44AM +0100, Robin Murphy a écrit :
> On 2022-09-19 22:00, Jason A. Donenfeld wrote:
> > The Rockchip driver has long existed out of tree, but not upstream.
> > There is support for it upstream in u-boot, but not in Linux proper.
> > This commit imports the GPLv2 driver written by Lin Jinhan, together
> > with the DTS and config blobs from Wevsty.
> 
> Note that Corentin has a series enabling the full crypto driver for 
> RK3328 and RK3399[1], so it would seem more sensible to add TRNG support 
> to that. Having confliciting compatibles for the same hardware that 
> force the user to change their DT to choose one functionality or the 
> other isn't good (plus there's also no binding for this one).
> 
> Robin.
> 

Hello

I am very interested on how this serie was tested and which tools was used to ensure output was random.
And how did you get that CRYPTO_V1_TRNG_SAMPLE_PERIOD(100); was the best choice.

Thanks
Regards

WARNING: multiple messages have this Message-ID (diff)
From: Corentin LABBE <clabbe@baylibre.com>
To: troy.lin@rock-chips.com, shawn.lin@rock-chips.com,
	hl@rock-chips.com, ty@wevs.org, mike.rudenko@gmail.com
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org, robin.murphy@arm.com
Subject: Re: [PATCH] hw_random: rockchip: import driver from vendor tree
Date: Tue, 31 Jan 2023 11:34:37 +0100	[thread overview]
Message-ID: <Y9juvficPxFUfgHD@Red> (raw)
In-Reply-To: <32f8797a-4b65-69df-ee8e-7891a6b4f1af@arm.com>

Le Tue, Sep 20, 2022 at 10:35:44AM +0100, Robin Murphy a écrit :
> On 2022-09-19 22:00, Jason A. Donenfeld wrote:
> > The Rockchip driver has long existed out of tree, but not upstream.
> > There is support for it upstream in u-boot, but not in Linux proper.
> > This commit imports the GPLv2 driver written by Lin Jinhan, together
> > with the DTS and config blobs from Wevsty.
> 
> Note that Corentin has a series enabling the full crypto driver for 
> RK3328 and RK3399[1], so it would seem more sensible to add TRNG support 
> to that. Having confliciting compatibles for the same hardware that 
> force the user to change their DT to choose one functionality or the 
> other isn't good (plus there's also no binding for this one).
> 
> Robin.
> 

Hello

I am very interested on how this serie was tested and which tools was used to ensure output was random.
And how did you get that CRYPTO_V1_TRNG_SAMPLE_PERIOD(100); was the best choice.

Thanks
Regards

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2023-01-31 10:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 21:00 [PATCH] hw_random: rockchip: import driver from vendor tree Jason A. Donenfeld
2022-09-19 21:00 ` Jason A. Donenfeld
2022-09-20  9:35 ` Robin Murphy
2022-09-20  9:35   ` Robin Murphy
2022-09-20  9:49   ` Jason A. Donenfeld
2022-09-20  9:49     ` Jason A. Donenfeld
2022-09-27 16:37   ` Aurelien Jarno
2022-09-27 16:37     ` Aurelien Jarno
2022-09-27 19:46     ` LABBE Corentin
2022-09-27 19:46       ` LABBE Corentin
2022-09-27 21:39       ` Aurelien Jarno
2022-09-27 21:39         ` Aurelien Jarno
2022-09-29  7:45         ` LABBE Corentin
2022-09-29  7:45           ` LABBE Corentin
2022-11-16 18:04           ` Mikhail Rudenko
2022-11-16 18:04             ` Mikhail Rudenko
2022-11-22 13:29             ` Corentin LABBE
2022-11-22 13:29               ` Corentin LABBE
2022-11-22 15:04               ` Mikhail Rudenko
2022-11-22 15:04                 ` Mikhail Rudenko
2023-01-31 10:34   ` Corentin LABBE [this message]
2023-01-31 10:34     ` Corentin LABBE
2024-06-18 13:27     ` Anand Moon
2024-06-18 13:27       ` Anand Moon
2024-09-23  7:48       ` Janpieter Sollie
2024-09-23  7:48         ` Janpieter Sollie
2024-09-25 15:01         ` Corentin LABBE
2024-09-25 15:01           ` Corentin LABBE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9juvficPxFUfgHD@Red \
    --to=clabbe@baylibre.com \
    --cc=Jason@zx2c4.com \
    --cc=heiko@sntech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=hl@rock-chips.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mike.rudenko@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=shawn.lin@rock-chips.com \
    --cc=troy.lin@rock-chips.com \
    --cc=ty@wevs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.