All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	Samuel Holland <samuel@sholland.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Dao Lu <daolu@rivosinc.com>, Albert Ou <aou@eecs.berkeley.edu>,
	Heiko Stuebner <heiko@sntech.de>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Anup Patel <anup@brainfault.org>,
	Atish Patra <atishp@rivosinc.com>, Guo Ren <guoren@kernel.org>
Subject: Re: [PATCH] riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y
Date: Fri, 3 Feb 2023 00:25:41 +0800	[thread overview]
Message-ID: <Y9vkBZknfDOHGZzu@xhacker> (raw)
In-Reply-To: <167523607081.29266.3967297527966644183.b4-ty@rivosinc.com>

On Tue, Jan 31, 2023 at 11:21:10PM -0800, Palmer Dabbelt wrote:
> On Thu, 22 Sep 2022 01:09:58 -0500, Samuel Holland wrote:
> > commit 8eb060e10185 ("arch/riscv: add Zihintpause support") broke
> > building with CONFIG_CC_OPTIMIZE_FOR_SIZE enabled (gcc 11.1.0):
> > 
> >   CC      arch/riscv/kernel/vdso/vgettimeofday.o
> > In file included from <command-line>:
> > ./arch/riscv/include/asm/jump_label.h: In function 'cpu_relax':
> > ././include/linux/compiler_types.h:285:33: warning: 'asm' operand 0 probably does not match constraints
> >   285 | #define asm_volatile_goto(x...) asm goto(x)
> >       |                                 ^~~
> > ./arch/riscv/include/asm/jump_label.h:41:9: note: in expansion of macro 'asm_volatile_goto'
> >    41 |         asm_volatile_goto(
> >       |         ^~~~~~~~~~~~~~~~~
> > ././include/linux/compiler_types.h:285:33: error: impossible constraint in 'asm'
> >   285 | #define asm_volatile_goto(x...) asm goto(x)
> >       |                                 ^~~
> > ./arch/riscv/include/asm/jump_label.h:41:9: note: in expansion of macro 'asm_volatile_goto'
> >    41 |         asm_volatile_goto(
> >       |         ^~~~~~~~~~~~~~~~~
> > make[1]: *** [scripts/Makefile.build:249: arch/riscv/kernel/vdso/vgettimeofday.o] Error 1
> > make: *** [arch/riscv/Makefile:128: vdso_prepare] Error 2
> > 
> > [...]
> 
> Applied, thanks!

Hi Palmer,

I assume the build error is already fixed in v6.1 and can't be reproduced.

Thanks
> 
> [1/1] riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>       https://git.kernel.org/palmer/c/3c349eacc559
> 
> Best regards,
> -- 
> Palmer Dabbelt <palmer@rivosinc.com>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@kernel.org>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	Samuel Holland <samuel@sholland.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Dao Lu <daolu@rivosinc.com>, Albert Ou <aou@eecs.berkeley.edu>,
	Heiko Stuebner <heiko@sntech.de>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Anup Patel <anup@brainfault.org>,
	Atish Patra <atishp@rivosinc.com>, Guo Ren <guoren@kernel.org>
Subject: Re: [PATCH] riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y
Date: Fri, 3 Feb 2023 00:25:41 +0800	[thread overview]
Message-ID: <Y9vkBZknfDOHGZzu@xhacker> (raw)
In-Reply-To: <167523607081.29266.3967297527966644183.b4-ty@rivosinc.com>

On Tue, Jan 31, 2023 at 11:21:10PM -0800, Palmer Dabbelt wrote:
> On Thu, 22 Sep 2022 01:09:58 -0500, Samuel Holland wrote:
> > commit 8eb060e10185 ("arch/riscv: add Zihintpause support") broke
> > building with CONFIG_CC_OPTIMIZE_FOR_SIZE enabled (gcc 11.1.0):
> > 
> >   CC      arch/riscv/kernel/vdso/vgettimeofday.o
> > In file included from <command-line>:
> > ./arch/riscv/include/asm/jump_label.h: In function 'cpu_relax':
> > ././include/linux/compiler_types.h:285:33: warning: 'asm' operand 0 probably does not match constraints
> >   285 | #define asm_volatile_goto(x...) asm goto(x)
> >       |                                 ^~~
> > ./arch/riscv/include/asm/jump_label.h:41:9: note: in expansion of macro 'asm_volatile_goto'
> >    41 |         asm_volatile_goto(
> >       |         ^~~~~~~~~~~~~~~~~
> > ././include/linux/compiler_types.h:285:33: error: impossible constraint in 'asm'
> >   285 | #define asm_volatile_goto(x...) asm goto(x)
> >       |                                 ^~~
> > ./arch/riscv/include/asm/jump_label.h:41:9: note: in expansion of macro 'asm_volatile_goto'
> >    41 |         asm_volatile_goto(
> >       |         ^~~~~~~~~~~~~~~~~
> > make[1]: *** [scripts/Makefile.build:249: arch/riscv/kernel/vdso/vgettimeofday.o] Error 1
> > make: *** [arch/riscv/Makefile:128: vdso_prepare] Error 2
> > 
> > [...]
> 
> Applied, thanks!

Hi Palmer,

I assume the build error is already fixed in v6.1 and can't be reproduced.

Thanks
> 
> [1/1] riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>       https://git.kernel.org/palmer/c/3c349eacc559
> 
> Best regards,
> -- 
> Palmer Dabbelt <palmer@rivosinc.com>

  reply	other threads:[~2023-02-02 16:36 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  6:09 [PATCH] riscv: Fix build with CONFIG_CC_OPTIMIZE_FOR_SIZE=y Samuel Holland
2022-09-22  6:09 ` Samuel Holland
2022-09-22 13:25 ` Conor Dooley
2022-09-22 13:25   ` Conor Dooley
2022-09-22 15:45 ` Heiko Stuebner
2022-09-22 15:45   ` Heiko Stuebner
2022-09-22 15:52   ` Jessica Clarke
2022-09-22 15:52     ` Jessica Clarke
2022-09-23  7:17     ` Heiko Stuebner
2022-09-23  7:17       ` Heiko Stuebner
2022-09-23 18:01       ` Atish Patra
2022-09-23 18:01         ` Atish Patra
2022-09-24 23:15         ` Conor Dooley
2022-09-24 23:15           ` Conor Dooley
2022-09-28  7:21           ` Atish Patra
2022-09-28  7:21             ` Atish Patra
2022-09-28 21:16             ` Conor Dooley
2022-09-28 21:16               ` Conor Dooley
2022-09-29  3:26               ` Atish Patra
2022-09-29  3:26                 ` Atish Patra
2022-10-01 20:13                 ` Conor Dooley
2022-10-01 20:13                   ` Conor Dooley
2022-10-04 16:52                   ` Atish Patra
2022-10-04 16:52                     ` Atish Patra
2022-10-04 17:15                     ` Conor Dooley
2022-10-04 17:15                       ` Conor Dooley
2022-10-04 17:24                     ` Jessica Clarke
2022-10-04 17:24                       ` Jessica Clarke
2022-10-05  0:38                       ` Guo Ren
2022-10-05  0:38                         ` Guo Ren
2022-10-05  1:01                         ` Jessica Clarke
2022-10-05  1:01                           ` Jessica Clarke
2022-10-05  1:40                           ` Guo Ren
2022-10-05  1:40                             ` Guo Ren
2022-10-05 14:25                             ` Jessica Clarke
2022-10-05 14:25                               ` Jessica Clarke
2022-10-06  6:48 ` Jisheng Zhang
2022-10-06  6:48   ` Jisheng Zhang
2022-10-26 13:59   ` Palmer Dabbelt
2022-10-26 13:59     ` Palmer Dabbelt
2023-02-01  7:21 ` Palmer Dabbelt
2023-02-01  7:21   ` Palmer Dabbelt
2023-02-02 16:25   ` Jisheng Zhang [this message]
2023-02-02 16:25     ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9vkBZknfDOHGZzu@xhacker \
    --to=jszhang@kernel.org \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atishp@rivosinc.com \
    --cc=daolu@rivosinc.com \
    --cc=guoren@kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=palmer@rivosinc.com \
    --cc=paul.walmsley@sifive.com \
    --cc=samuel@sholland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.