All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.com>
Cc: ltp@lists.linux.it, Oliver Hartkopp <socketcan@hartkopp.net>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	linux-can@vger.kernel.org
Subject: Re: [LTP] [PATCH v3 6/7] can: Remove obsolete test wrapper script
Date: Mon, 25 Jan 2021 10:10:27 +0100	[thread overview]
Message-ID: <YA6LA4rSb9obia6k@pevik> (raw)
In-Reply-To: <20210120143723.26483-7-rpalethorpe@suse.com>

Hi Richie,

>  2) To Run the tests from this directory, do:
> -$ ./run_ltp-can_tests.sh
> +$ ./can_filter
> +$ ./can_rcv_own_msgs
>  3) To let LTP run the tests from $LTPROOT, execute:
>  $ ./runltp -f can

You also need to update runtest/can (which can be done during merge).

diff --git runtest/can runtest/can
index 6aa2ae9f5..b637183c6 100644
--- runtest/can
+++ runtest/can
@@ -1,2 +1,2 @@
-can_filter can_run_tests.sh can_filter
-can_rcv_own_msgs can_run_tests.sh can_rcv_own_msgs
+can_filter can_filter
+can_rcv_own_msgs can_rcv_own_msgs

Whole patchset LGTM, thanks!

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 6/7] can: Remove obsolete test wrapper script
Date: Mon, 25 Jan 2021 10:10:27 +0100	[thread overview]
Message-ID: <YA6LA4rSb9obia6k@pevik> (raw)
In-Reply-To: <20210120143723.26483-7-rpalethorpe@suse.com>

Hi Richie,

>  2) To Run the tests from this directory, do:
> -$ ./run_ltp-can_tests.sh
> +$ ./can_filter
> +$ ./can_rcv_own_msgs
>  3) To let LTP run the tests from $LTPROOT, execute:
>  $ ./runltp -f can

You also need to update runtest/can (which can be done during merge).

diff --git runtest/can runtest/can
index 6aa2ae9f5..b637183c6 100644
--- runtest/can
+++ runtest/can
@@ -1,2 +1,2 @@
-can_filter can_run_tests.sh can_filter
-can_rcv_own_msgs can_run_tests.sh can_rcv_own_msgs
+can_filter can_filter
+can_rcv_own_msgs can_rcv_own_msgs

Whole patchset LGTM, thanks!

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

  reply	other threads:[~2021-01-26  6:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 14:37 [PATCH v3 0/7] Convert CAN tests to new LTP API Richard Palethorpe
2021-01-20 14:37 ` [LTP] " Richard Palethorpe
2021-01-20 14:37 ` [PATCH v3 1/7] API: Add FILE_SCANF to new lib Richard Palethorpe
2021-01-20 14:37   ` [LTP] " Richard Palethorpe
2021-01-20 14:37 ` [PATCH v3 2/7] can: Add can_common.h for vcan device setup Richard Palethorpe
2021-01-20 14:37   ` [LTP] " Richard Palethorpe
2021-01-25 10:20   ` Oliver Hartkopp
2021-01-25 10:20     ` [LTP] " Oliver Hartkopp
2021-01-25 10:59     ` Richard Palethorpe
2021-01-25 10:59       ` [LTP] " Richard Palethorpe
2021-01-26 21:28       ` Petr Vorel
2021-01-26 21:28         ` [LTP] " Petr Vorel
2021-01-27  7:52         ` Oliver Hartkopp
2021-01-27  7:52           ` [LTP] " Oliver Hartkopp
2021-01-27  8:18           ` Richard Palethorpe
2021-01-27  8:18             ` [LTP] " Richard Palethorpe
2021-01-27 12:13             ` Petr Vorel
2021-01-27 12:13               ` [LTP] " Petr Vorel
2021-01-27 15:07               ` Petr Vorel
2021-01-27 15:07                 ` Petr Vorel
2021-01-20 14:37 ` [PATCH v3 3/7] can: Add COPYING with dual license text Richard Palethorpe
2021-01-20 14:37   ` [LTP] " Richard Palethorpe
2021-01-20 14:37 ` [PATCH v3 4/7] can_filter: Convert to new library Richard Palethorpe
2021-01-20 14:37   ` [LTP] " Richard Palethorpe
2021-01-20 14:37 ` [PATCH v3 5/7] can_recv_own_msgs: " Richard Palethorpe
2021-01-20 14:37   ` [LTP] " Richard Palethorpe
2021-01-25 14:29   ` Cyril Hrubis
2021-01-25 14:29     ` Cyril Hrubis
2021-01-20 14:37 ` [PATCH v3 6/7] can: Remove obsolete test wrapper script Richard Palethorpe
2021-01-20 14:37   ` [LTP] " Richard Palethorpe
2021-01-25  9:10   ` Petr Vorel [this message]
2021-01-25  9:10     ` Petr Vorel
2021-01-20 14:37 ` [PATCH v3 7/7] can: Update contact details Richard Palethorpe
2021-01-20 14:37   ` [LTP] " Richard Palethorpe
2021-01-25 10:25   ` Oliver Hartkopp
2021-01-25 10:25     ` [LTP] " Oliver Hartkopp
2021-01-25 14:30   ` Cyril Hrubis
2021-01-25 14:30     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YA6LA4rSb9obia6k@pevik \
    --to=pvorel@suse.cz \
    --cc=linux-can@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=mkl@pengutronix.de \
    --cc=rpalethorpe@suse.com \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.