From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Alex Elder <elder@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net-next] ipa: add remoteproc dependency
Date: Mon, 25 Jan 2021 09:23:01 -0600 [thread overview]
Message-ID: <YA7iVQtm8P2F1VAN@builder.lan> (raw)
In-Reply-To: <20210125113557.2388311-1-arnd@kernel.org>
On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing without CONFIG_REMOTEPROC results in a build failure:
>
> >>> referenced by ipa_main.c
> >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
> ld.lld: error: undefined symbol: rproc_put
> >>> referenced by ipa_main.c
> >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
> >>> referenced by ipa_main.c
> >>> net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a
>
> Add a new dependency to avoid this.
>
Afaict this should be addressed by:
86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency")
which is present in linux-next.
Regards,
Bjorn
> Fixes: 38a4066f593c ("net: ipa: support COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ipa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
> index b68f1289b89e..aa1c0ae3cf01 100644
> --- a/drivers/net/ipa/Kconfig
> +++ b/drivers/net/ipa/Kconfig
> @@ -3,6 +3,7 @@ config QCOM_IPA
> depends on 64BIT && NET && QCOM_SMEM
> depends on ARCH_QCOM || COMPILE_TEST
> depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
> + depends on REMOTEPROC
> select QCOM_MDT_LOADER if ARCH_QCOM
> select QCOM_QMI_HELPERS
> help
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-01-26 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 11:35 [PATCH] [net-next] ipa: add remoteproc dependency Arnd Bergmann
2021-01-25 15:23 ` Bjorn Andersson [this message]
2021-01-25 15:30 ` Arnd Bergmann
2021-01-25 15:33 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA7iVQtm8P2F1VAN@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.