From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: chenzhou <chenzhou10-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse_param()
Date: Fri, 15 Jan 2021 11:08:55 +0100 [thread overview]
Message-ID: <YAFpt6aYW4nVQoZf@blackbook> (raw)
In-Reply-To: <7804658e-7644-8edb-5ca8-0c97389c8c62-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
On Fri, Jan 15, 2021 at 09:55:43AM +0800, chenzhou <chenzhou10-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
> Yeah, this will select all enabled controllers, but which doesn't the behavior we want.
I see what the issue is now.
> See above. Just the mount behavior isn't what we what.
I agree this a bug and your I find your approach correct
Reviewed-by: Michal Koutný <mkoutny-IBi9RG/b67k@public.gmane.org>
> The behavior was changed since commit f5dfb5315d34 ("cgroup: take
> options parsing into ->parse_monolithic()"), will add this as Fixes.
Thanks.
Michal
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Michal Koutný" <mkoutny@suse.com>
To: chenzhou <chenzhou10@huawei.com>
Cc: tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse_param()
Date: Fri, 15 Jan 2021 11:08:55 +0100 [thread overview]
Message-ID: <YAFpt6aYW4nVQoZf@blackbook> (raw)
In-Reply-To: <7804658e-7644-8edb-5ca8-0c97389c8c62@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
On Fri, Jan 15, 2021 at 09:55:43AM +0800, chenzhou <chenzhou10@huawei.com> wrote:
> Yeah, this will select all enabled controllers, but which doesn't the behavior we want.
I see what the issue is now.
> See above. Just the mount behavior isn't what we what.
I agree this a bug and your I find your approach correct
Reviewed-by: Michal Koutný <mkoutny@suse.com>
> The behavior was changed since commit f5dfb5315d34 ("cgroup: take
> options parsing into ->parse_monolithic()"), will add this as Fixes.
Thanks.
Michal
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-15 10:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 6:17 [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse_param() Chen Zhou
2020-12-18 6:17 ` Chen Zhou
[not found] ` <20201218061755.121205-1-chenzhou10-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2020-12-18 7:02 ` Zefan Li
2020-12-18 7:02 ` Zefan Li
2021-01-14 13:12 ` Michal Koutný
2021-01-14 14:08 ` chenzhou
2021-01-14 14:08 ` chenzhou
[not found] ` <d4ba14b0-ee06-b793-a840-2c2ff369d890-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-01-14 16:54 ` Michal Koutný
2021-01-14 16:54 ` Michal Koutný
2021-01-15 1:55 ` chenzhou
2021-01-15 1:55 ` chenzhou
2021-01-15 3:17 ` Tejun Heo
[not found] ` <YAEJPs4DJIgAXWul-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2021-01-15 5:58 ` chenzhou
2021-01-15 5:58 ` chenzhou
[not found] ` <7804658e-7644-8edb-5ca8-0c97389c8c62-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-01-15 10:08 ` Michal Koutný [this message]
2021-01-15 10:08 ` Michal Koutný
2021-01-15 11:09 ` chenzhou
2021-01-15 11:09 ` chenzhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAFpt6aYW4nVQoZf@blackbook \
--to=mkoutny-ibi9rg/b67k@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=chenzhou10-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.