All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN
Date: Wed, 20 Jan 2021 22:47:45 +0200	[thread overview]
Message-ID: <YAiW8Vp6OSB6qZ2M@smile.fi.intel.com> (raw)
In-Reply-To: <YAiWn+MK+o/m4IOY@smile.fi.intel.com>

On Wed, Jan 20, 2021 at 10:46:23PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 20, 2021 at 09:37:56PM +0100, Heinrich Schuchardt wrote:
> > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and
> > CONFIG_ACPIGEN=n fails with
> > 
> > ld.bfd: cmd/built-in.o: in function `do_acpi_items':
> > cmd/acpi.c:162: undefined reference to `acpi_dump_items'
> > 
> > Add the missing configuration dependency.

...

> >  config CMD_ACPI
> >  	bool "acpi"
> > -	default y if ACPIGEN
> > +	depends on ACPIGEN
> > +	default y
> 
> Shouldn't be rather
> 
> 	default ACPIGEN
> 
> ?

Actually it makes no difference...

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-01-20 20:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 20:37 [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN Heinrich Schuchardt
2021-01-20 20:46 ` Andy Shevchenko
2021-01-20 20:47   ` Andy Shevchenko [this message]
2021-01-21  1:19     ` Heinrich Schuchardt
2021-01-21  3:13 ` Bin Meng
2021-01-21  5:45   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAiW8Vp6OSB6qZ2M@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.