* [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN
@ 2021-01-20 20:37 Heinrich Schuchardt
2021-01-20 20:46 ` Andy Shevchenko
2021-01-21 3:13 ` Bin Meng
0 siblings, 2 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2021-01-20 20:37 UTC (permalink / raw)
To: u-boot
Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and
CONFIG_ACPIGEN=n fails with
ld.bfd: cmd/built-in.o: in function `do_acpi_items':
cmd/acpi.c:162: undefined reference to `acpi_dump_items'
Add the missing configuration dependency.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
cmd/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 0625ee4050..928a2a0a2d 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -84,7 +84,8 @@ menu "Info commands"
config CMD_ACPI
bool "acpi"
- default y if ACPIGEN
+ depends on ACPIGEN
+ default y
help
List and dump ACPI tables. ACPI (Advanced Configuration and Power
Interface) is used mostly on x86 for providing information to the
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN
2021-01-20 20:37 [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN Heinrich Schuchardt
@ 2021-01-20 20:46 ` Andy Shevchenko
2021-01-20 20:47 ` Andy Shevchenko
2021-01-21 3:13 ` Bin Meng
1 sibling, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-01-20 20:46 UTC (permalink / raw)
To: u-boot
On Wed, Jan 20, 2021 at 09:37:56PM +0100, Heinrich Schuchardt wrote:
> Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and
> CONFIG_ACPIGEN=n fails with
>
> ld.bfd: cmd/built-in.o: in function `do_acpi_items':
> cmd/acpi.c:162: undefined reference to `acpi_dump_items'
>
> Add the missing configuration dependency.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> cmd/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 0625ee4050..928a2a0a2d 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -84,7 +84,8 @@ menu "Info commands"
>
> config CMD_ACPI
> bool "acpi"
> - default y if ACPIGEN
> + depends on ACPIGEN
> + default y
Shouldn't be rather
default ACPIGEN
?
> help
> List and dump ACPI tables. ACPI (Advanced Configuration and Power
> Interface) is used mostly on x86 for providing information to the
> --
> 2.29.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN
2021-01-20 20:46 ` Andy Shevchenko
@ 2021-01-20 20:47 ` Andy Shevchenko
2021-01-21 1:19 ` Heinrich Schuchardt
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-01-20 20:47 UTC (permalink / raw)
To: u-boot
On Wed, Jan 20, 2021 at 10:46:23PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 20, 2021 at 09:37:56PM +0100, Heinrich Schuchardt wrote:
> > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and
> > CONFIG_ACPIGEN=n fails with
> >
> > ld.bfd: cmd/built-in.o: in function `do_acpi_items':
> > cmd/acpi.c:162: undefined reference to `acpi_dump_items'
> >
> > Add the missing configuration dependency.
...
> > config CMD_ACPI
> > bool "acpi"
> > - default y if ACPIGEN
> > + depends on ACPIGEN
> > + default y
>
> Shouldn't be rather
>
> default ACPIGEN
>
> ?
Actually it makes no difference...
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN
2021-01-20 20:47 ` Andy Shevchenko
@ 2021-01-21 1:19 ` Heinrich Schuchardt
0 siblings, 0 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2021-01-21 1:19 UTC (permalink / raw)
To: u-boot
Am 20. Januar 2021 21:47:45 MEZ schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
>On Wed, Jan 20, 2021 at 10:46:23PM +0200, Andy Shevchenko wrote:
>> On Wed, Jan 20, 2021 at 09:37:56PM +0100, Heinrich Schuchardt wrote:
>> > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and
>> > CONFIG_ACPIGEN=n fails with
>> >
>> > ld.bfd: cmd/built-in.o: in function `do_acpi_items':
>> > cmd/acpi.c:162: undefined reference to `acpi_dump_items'
>> >
>> > Add the missing configuration dependency.
>
>...
>
>> > config CMD_ACPI
>> > bool "acpi"
>> > - default y if ACPIGEN
>> > + depends on ACPIGEN
>> > + default y
>>
>> Shouldn't be rather
>>
>> default ACPIGEN
>>
>> ?
Thanks for reviewing.
You cannot drop the depends line.
If you only want to change the last line only, 'default y' is easier to read and matches the style of the rest of our code.
Best regards
Heinrich
>
>Actually it makes no difference...
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN
2021-01-20 20:37 [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN Heinrich Schuchardt
2021-01-20 20:46 ` Andy Shevchenko
@ 2021-01-21 3:13 ` Bin Meng
2021-01-21 5:45 ` Bin Meng
1 sibling, 1 reply; 6+ messages in thread
From: Bin Meng @ 2021-01-21 3:13 UTC (permalink / raw)
To: u-boot
On Thu, Jan 21, 2021 at 4:38 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and
> CONFIG_ACPIGEN=n fails with
>
> ld.bfd: cmd/built-in.o: in function `do_acpi_items':
> cmd/acpi.c:162: undefined reference to `acpi_dump_items'
>
> Add the missing configuration dependency.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> cmd/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN
2021-01-21 3:13 ` Bin Meng
@ 2021-01-21 5:45 ` Bin Meng
0 siblings, 0 replies; 6+ messages in thread
From: Bin Meng @ 2021-01-21 5:45 UTC (permalink / raw)
To: u-boot
On Thu, Jan 21, 2021 at 11:13 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Thu, Jan 21, 2021 at 4:38 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and
> > CONFIG_ACPIGEN=n fails with
> >
> > ld.bfd: cmd/built-in.o: in function `do_acpi_items':
> > cmd/acpi.c:162: undefined reference to `acpi_dump_items'
> >
> > Add the missing configuration dependency.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > ---
> > cmd/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-21 5:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-20 20:37 [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN Heinrich Schuchardt
2021-01-20 20:46 ` Andy Shevchenko
2021-01-20 20:47 ` Andy Shevchenko
2021-01-21 1:19 ` Heinrich Schuchardt
2021-01-21 3:13 ` Bin Meng
2021-01-21 5:45 ` Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.