* [PATCH] sound: x86: Trivial spell fixes throughout the file intel_hdmi_audio.c
@ 2021-02-05 9:32 Bhaskar Chowdhury
2021-02-05 9:39 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Bhaskar Chowdhury @ 2021-02-05 9:32 UTC (permalink / raw)
To: perex, tiwai, alsa-devel, linux-kernel; +Cc: rdunlap, Bhaskar Chowdhury
s/confgiuration/configuration/
s/Calculte/Calculate/
s/unreference/unreferenced/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
sound/x86/intel_hdmi_audio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
index 9f9fcd2749f2..89ddd9dd8fde 100644
--- a/sound/x86/intel_hdmi_audio.c
+++ b/sound/x86/intel_hdmi_audio.c
@@ -342,7 +342,7 @@ static int had_prog_status_reg(struct snd_pcm_substream *substream,
/*
* function to initialize audio
- * registers and buffer confgiuration registers
+ * registers and buffer configuration registers
* This function is called in the prepare callback
*/
static int had_init_audio_ctrl(struct snd_pcm_substream *substream,
@@ -611,7 +611,7 @@ static void had_prog_dip(struct snd_pcm_substream *substream,
frame2.regx.chnl_cnt = substream->runtime->channels - 1;
frame3.regx.chnl_alloc = ca;
- /* Calculte the byte wide checksum for all valid DIP words */
+ /* Calculate the byte wide checksum for all valid DIP words */
for (i = 0; i < BYTES_PER_WORD; i++)
checksum += (info_frame >> (i * 8)) & 0xff;
for (i = 0; i < BYTES_PER_WORD; i++)
@@ -1109,7 +1109,7 @@ static int had_pcm_close(struct snd_pcm_substream *substream)
intelhaddata = snd_pcm_substream_chip(substream);
- /* unreference and sync with the pending PCM accesses */
+ /* unreferenced and sync with the pending PCM accesses */
spin_lock_irq(&intelhaddata->had_spinlock);
intelhaddata->stream_info.substream = NULL;
intelhaddata->stream_info.substream_refcount--;
--
2.30.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] sound: x86: Trivial spell fixes throughout the file intel_hdmi_audio.c
2021-02-05 9:32 [PATCH] sound: x86: Trivial spell fixes throughout the file intel_hdmi_audio.c Bhaskar Chowdhury
@ 2021-02-05 9:39 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2021-02-05 9:39 UTC (permalink / raw)
To: Bhaskar Chowdhury; +Cc: linux-kernel, alsa-devel, rdunlap, tiwai
On Fri, 05 Feb 2021 10:32:14 +0100,
Bhaskar Chowdhury wrote:
>
>
>
> s/confgiuration/configuration/
> s/Calculte/Calculate/
> s/unreference/unreferenced/
The last one isn't correct. It was meant as a positive form, so if
any, it's "unrefer", but "reference" could be used as a verb in the
tech term, so IMO we can keep as is.
thanks,
Takashi
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> sound/x86/intel_hdmi_audio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> index 9f9fcd2749f2..89ddd9dd8fde 100644
> --- a/sound/x86/intel_hdmi_audio.c
> +++ b/sound/x86/intel_hdmi_audio.c
> @@ -342,7 +342,7 @@ static int had_prog_status_reg(struct snd_pcm_substream *substream,
>
> /*
> * function to initialize audio
> - * registers and buffer confgiuration registers
> + * registers and buffer configuration registers
> * This function is called in the prepare callback
> */
> static int had_init_audio_ctrl(struct snd_pcm_substream *substream,
> @@ -611,7 +611,7 @@ static void had_prog_dip(struct snd_pcm_substream *substream,
> frame2.regx.chnl_cnt = substream->runtime->channels - 1;
> frame3.regx.chnl_alloc = ca;
>
> - /* Calculte the byte wide checksum for all valid DIP words */
> + /* Calculate the byte wide checksum for all valid DIP words */
> for (i = 0; i < BYTES_PER_WORD; i++)
> checksum += (info_frame >> (i * 8)) & 0xff;
> for (i = 0; i < BYTES_PER_WORD; i++)
> @@ -1109,7 +1109,7 @@ static int had_pcm_close(struct snd_pcm_substream *substream)
>
> intelhaddata = snd_pcm_substream_chip(substream);
>
> - /* unreference and sync with the pending PCM accesses */
> + /* unreferenced and sync with the pending PCM accesses */
> spin_lock_irq(&intelhaddata->had_spinlock);
> intelhaddata->stream_info.substream = NULL;
> intelhaddata->stream_info.substream_refcount--;
> --
> 2.30.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sound: x86: Trivial spell fixes throughout the file intel_hdmi_audio.c
@ 2021-02-05 9:39 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2021-02-05 9:39 UTC (permalink / raw)
To: Bhaskar Chowdhury; +Cc: perex, tiwai, alsa-devel, linux-kernel, rdunlap
On Fri, 05 Feb 2021 10:32:14 +0100,
Bhaskar Chowdhury wrote:
>
>
>
> s/confgiuration/configuration/
> s/Calculte/Calculate/
> s/unreference/unreferenced/
The last one isn't correct. It was meant as a positive form, so if
any, it's "unrefer", but "reference" could be used as a verb in the
tech term, so IMO we can keep as is.
thanks,
Takashi
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> sound/x86/intel_hdmi_audio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> index 9f9fcd2749f2..89ddd9dd8fde 100644
> --- a/sound/x86/intel_hdmi_audio.c
> +++ b/sound/x86/intel_hdmi_audio.c
> @@ -342,7 +342,7 @@ static int had_prog_status_reg(struct snd_pcm_substream *substream,
>
> /*
> * function to initialize audio
> - * registers and buffer confgiuration registers
> + * registers and buffer configuration registers
> * This function is called in the prepare callback
> */
> static int had_init_audio_ctrl(struct snd_pcm_substream *substream,
> @@ -611,7 +611,7 @@ static void had_prog_dip(struct snd_pcm_substream *substream,
> frame2.regx.chnl_cnt = substream->runtime->channels - 1;
> frame3.regx.chnl_alloc = ca;
>
> - /* Calculte the byte wide checksum for all valid DIP words */
> + /* Calculate the byte wide checksum for all valid DIP words */
> for (i = 0; i < BYTES_PER_WORD; i++)
> checksum += (info_frame >> (i * 8)) & 0xff;
> for (i = 0; i < BYTES_PER_WORD; i++)
> @@ -1109,7 +1109,7 @@ static int had_pcm_close(struct snd_pcm_substream *substream)
>
> intelhaddata = snd_pcm_substream_chip(substream);
>
> - /* unreference and sync with the pending PCM accesses */
> + /* unreferenced and sync with the pending PCM accesses */
> spin_lock_irq(&intelhaddata->had_spinlock);
> intelhaddata->stream_info.substream = NULL;
> intelhaddata->stream_info.substream_refcount--;
> --
> 2.30.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sound: x86: Trivial spell fixes throughout the file intel_hdmi_audio.c
2021-02-05 9:39 ` Takashi Iwai
@ 2021-02-05 9:55 ` Bhaskar Chowdhury
-1 siblings, 0 replies; 5+ messages in thread
From: Bhaskar Chowdhury @ 2021-02-05 9:55 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-kernel, alsa-devel, rdunlap, tiwai
[-- Attachment #1: Type: text/plain, Size: 2100 bytes --]
On 10:39 Fri 05 Feb 2021, Takashi Iwai wrote:
>On Fri, 05 Feb 2021 10:32:14 +0100,
>Bhaskar Chowdhury wrote:
>>
>>
>>
>> s/confgiuration/configuration/
>> s/Calculte/Calculate/
>> s/unreference/unreferenced/
>
>The last one isn't correct. It was meant as a positive form, so if
>any, it's "unrefer", but "reference" could be used as a verb in the
>tech term, so IMO we can keep as is.
>
Good catch...thanks Takashi! As you like. :)
>
>thanks,
>
>Takashi
>
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> sound/x86/intel_hdmi_audio.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
>> index 9f9fcd2749f2..89ddd9dd8fde 100644
>> --- a/sound/x86/intel_hdmi_audio.c
>> +++ b/sound/x86/intel_hdmi_audio.c
>> @@ -342,7 +342,7 @@ static int had_prog_status_reg(struct snd_pcm_substream *substream,
>>
>> /*
>> * function to initialize audio
>> - * registers and buffer confgiuration registers
>> + * registers and buffer configuration registers
>> * This function is called in the prepare callback
>> */
>> static int had_init_audio_ctrl(struct snd_pcm_substream *substream,
>> @@ -611,7 +611,7 @@ static void had_prog_dip(struct snd_pcm_substream *substream,
>> frame2.regx.chnl_cnt = substream->runtime->channels - 1;
>> frame3.regx.chnl_alloc = ca;
>>
>> - /* Calculte the byte wide checksum for all valid DIP words */
>> + /* Calculate the byte wide checksum for all valid DIP words */
>> for (i = 0; i < BYTES_PER_WORD; i++)
>> checksum += (info_frame >> (i * 8)) & 0xff;
>> for (i = 0; i < BYTES_PER_WORD; i++)
>> @@ -1109,7 +1109,7 @@ static int had_pcm_close(struct snd_pcm_substream *substream)
>>
>> intelhaddata = snd_pcm_substream_chip(substream);
>>
>> - /* unreference and sync with the pending PCM accesses */
>> + /* unreferenced and sync with the pending PCM accesses */
>> spin_lock_irq(&intelhaddata->had_spinlock);
>> intelhaddata->stream_info.substream = NULL;
>> intelhaddata->stream_info.substream_refcount--;
>> --
>> 2.30.0
>>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sound: x86: Trivial spell fixes throughout the file intel_hdmi_audio.c
@ 2021-02-05 9:55 ` Bhaskar Chowdhury
0 siblings, 0 replies; 5+ messages in thread
From: Bhaskar Chowdhury @ 2021-02-05 9:55 UTC (permalink / raw)
To: Takashi Iwai; +Cc: perex, tiwai, alsa-devel, linux-kernel, rdunlap
[-- Attachment #1: Type: text/plain, Size: 2100 bytes --]
On 10:39 Fri 05 Feb 2021, Takashi Iwai wrote:
>On Fri, 05 Feb 2021 10:32:14 +0100,
>Bhaskar Chowdhury wrote:
>>
>>
>>
>> s/confgiuration/configuration/
>> s/Calculte/Calculate/
>> s/unreference/unreferenced/
>
>The last one isn't correct. It was meant as a positive form, so if
>any, it's "unrefer", but "reference" could be used as a verb in the
>tech term, so IMO we can keep as is.
>
Good catch...thanks Takashi! As you like. :)
>
>thanks,
>
>Takashi
>
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> sound/x86/intel_hdmi_audio.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
>> index 9f9fcd2749f2..89ddd9dd8fde 100644
>> --- a/sound/x86/intel_hdmi_audio.c
>> +++ b/sound/x86/intel_hdmi_audio.c
>> @@ -342,7 +342,7 @@ static int had_prog_status_reg(struct snd_pcm_substream *substream,
>>
>> /*
>> * function to initialize audio
>> - * registers and buffer confgiuration registers
>> + * registers and buffer configuration registers
>> * This function is called in the prepare callback
>> */
>> static int had_init_audio_ctrl(struct snd_pcm_substream *substream,
>> @@ -611,7 +611,7 @@ static void had_prog_dip(struct snd_pcm_substream *substream,
>> frame2.regx.chnl_cnt = substream->runtime->channels - 1;
>> frame3.regx.chnl_alloc = ca;
>>
>> - /* Calculte the byte wide checksum for all valid DIP words */
>> + /* Calculate the byte wide checksum for all valid DIP words */
>> for (i = 0; i < BYTES_PER_WORD; i++)
>> checksum += (info_frame >> (i * 8)) & 0xff;
>> for (i = 0; i < BYTES_PER_WORD; i++)
>> @@ -1109,7 +1109,7 @@ static int had_pcm_close(struct snd_pcm_substream *substream)
>>
>> intelhaddata = snd_pcm_substream_chip(substream);
>>
>> - /* unreference and sync with the pending PCM accesses */
>> + /* unreferenced and sync with the pending PCM accesses */
>> spin_lock_irq(&intelhaddata->had_spinlock);
>> intelhaddata->stream_info.substream = NULL;
>> intelhaddata->stream_info.substream_refcount--;
>> --
>> 2.30.0
>>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-06 0:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-05 9:32 [PATCH] sound: x86: Trivial spell fixes throughout the file intel_hdmi_audio.c Bhaskar Chowdhury
2021-02-05 9:39 ` Takashi Iwai
2021-02-05 9:39 ` Takashi Iwai
2021-02-05 9:55 ` Bhaskar Chowdhury
2021-02-05 9:55 ` Bhaskar Chowdhury
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.