All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "Ivan J." <parazyd@dyne.org>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
Date: Sat, 6 Feb 2021 09:23:23 +0200	[thread overview]
Message-ID: <YB5D6zYcU6GES7WY@atomide.com> (raw)
In-Reply-To: <8daa6fce-bfad-ea28-e8dd-f3083bf43b01@ti.com>

* Grygorii Strashko <grygorii.strashko@ti.com> [210205 15:04]:
> On 05/02/2021 16:46, Tony Lindgren wrote:
> > That will potentially break things too as the configs now expect
> > it to be selected :) Looks like that got changed with commit
> > f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in
> > Kconfig").
> 
> Yah. It's really has to be "depends on".

Yeah that's almost always better than select for sure.

> > So why can't we do similar patches to select MICREL_PHY for
> > the other non-ks8851 configurations in drivers/net/ethernet
> > Kconfig files as needed?
> 
> because there is no dependency between Ethernet controller (CPSW) and
> Ethernet PHY - any MII capable PHY can be used with CPSW.

OK thanks for the info.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-omap@vger.kernel.org, "Ivan J." <parazyd@dyne.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
Date: Sat, 6 Feb 2021 09:23:23 +0200	[thread overview]
Message-ID: <YB5D6zYcU6GES7WY@atomide.com> (raw)
In-Reply-To: <8daa6fce-bfad-ea28-e8dd-f3083bf43b01@ti.com>

* Grygorii Strashko <grygorii.strashko@ti.com> [210205 15:04]:
> On 05/02/2021 16:46, Tony Lindgren wrote:
> > That will potentially break things too as the configs now expect
> > it to be selected :) Looks like that got changed with commit
> > f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in
> > Kconfig").
> 
> Yah. It's really has to be "depends on".

Yeah that's almost always better than select for sure.

> > So why can't we do similar patches to select MICREL_PHY for
> > the other non-ks8851 configurations in drivers/net/ethernet
> > Kconfig files as needed?
> 
> because there is no dependency between Ethernet controller (CPSW) and
> Ethernet PHY - any MII capable PHY can be used with CPSW.

OK thanks for the info.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-06  7:24 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 11:34 [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Ivan Jelincic
2021-02-03 11:34 ` Ivan Jelincic
2021-02-03 11:34 ` [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options Ivan Jelincic
2021-02-03 11:34   ` Ivan Jelincic
2021-02-04  6:56   ` Tony Lindgren
2021-02-04  6:56     ` Tony Lindgren
2021-02-05 13:15     ` Grygorii Strashko
2021-02-05 13:15       ` Grygorii Strashko
2021-02-05 13:17       ` Ivan J.
2021-02-05 13:17         ` Ivan J.
2021-02-05 13:30         ` Tony Lindgren
2021-02-05 13:30           ` Tony Lindgren
2021-02-05 14:25           ` Grygorii Strashko
2021-02-05 14:25             ` Grygorii Strashko
2021-02-05 14:46             ` Tony Lindgren
2021-02-05 14:46               ` Tony Lindgren
2021-02-05 15:04               ` Grygorii Strashko
2021-02-05 15:04                 ` Grygorii Strashko
2021-02-05 15:04                 ` Grygorii Strashko
2021-02-06  7:23                 ` Tony Lindgren [this message]
2021-02-06  7:23                   ` Tony Lindgren
2021-02-05 13:18 ` [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Grygorii Strashko
2021-02-05 13:18   ` Grygorii Strashko
2021-02-05 13:33   ` Tony Lindgren
2021-02-05 13:33     ` Tony Lindgren
2021-02-05 14:01     ` Grygorii Strashko
2021-02-05 14:01       ` Grygorii Strashko
  -- strict thread matches above, loose matches on Subject: below --
2021-01-26 12:21 [PATCH 1/2] ARM: omap2plus_defconfig: Update for moved options Tony Lindgren
2021-01-26 12:21 ` [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options Tony Lindgren
2021-01-26 12:21   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YB5D6zYcU6GES7WY@atomide.com \
    --to=tony@atomide.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=parazyd@dyne.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.