All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 2/2] soc: sunxi: mbus: Remove DE2 display engine compatibles
Date: Wed, 27 Jan 2021 14:03:03 +0100	[thread overview]
Message-ID: <YBFkh/faoPnTRZtl@aptenodytes> (raw)
In-Reply-To: <20210115175831.1184260-2-paul.kocialkowski@bootlin.com>


[-- Attachment #1.1: Type: text/plain, Size: 1701 bytes --]

Hi,

On Fri 15 Jan 21, 18:58, Paul Kocialkowski wrote:
> The DE2 display engine hardware takes physical addresses that do not
> need PHYS_BASE subtracted. As a result, they should not be present
> on the mbus driver match list. Remove them.
> 
> This was tested on the A83T, along with the patch allowing the DMA
> range map to be non-NULL and restores a working display.

Could we get this merged ASAP (in this RC cycle), hopefully with the patch
that superseded 1/2 from this series so that we don't end up with either
CSI or DE2 broken in the next release?

Cheers,

Paul

> Fixes: b4bdc4fbf8d0 ("soc: sunxi: Deal with the MBUS DMA offsets in a central place")
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
>  drivers/soc/sunxi/sunxi_mbus.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/soc/sunxi/sunxi_mbus.c b/drivers/soc/sunxi/sunxi_mbus.c
> index e9925c8487d7..d90e4a264b6f 100644
> --- a/drivers/soc/sunxi/sunxi_mbus.c
> +++ b/drivers/soc/sunxi/sunxi_mbus.c
> @@ -23,12 +23,7 @@ static const char * const sunxi_mbus_devices[] = {
>  	"allwinner,sun7i-a20-display-engine",
>  	"allwinner,sun8i-a23-display-engine",
>  	"allwinner,sun8i-a33-display-engine",
> -	"allwinner,sun8i-a83t-display-engine",
> -	"allwinner,sun8i-h3-display-engine",
> -	"allwinner,sun8i-r40-display-engine",
> -	"allwinner,sun8i-v3s-display-engine",
>  	"allwinner,sun9i-a80-display-engine",
> -	"allwinner,sun50i-a64-display-engine",
>  
>  	/*
>  	 * And now we have the regular devices connected to the MBUS
> -- 
> 2.30.0
> 

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/2] soc: sunxi: mbus: Remove DE2 display engine compatibles
Date: Wed, 27 Jan 2021 14:03:03 +0100	[thread overview]
Message-ID: <YBFkh/faoPnTRZtl@aptenodytes> (raw)
In-Reply-To: <20210115175831.1184260-2-paul.kocialkowski@bootlin.com>

[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]

Hi,

On Fri 15 Jan 21, 18:58, Paul Kocialkowski wrote:
> The DE2 display engine hardware takes physical addresses that do not
> need PHYS_BASE subtracted. As a result, they should not be present
> on the mbus driver match list. Remove them.
> 
> This was tested on the A83T, along with the patch allowing the DMA
> range map to be non-NULL and restores a working display.

Could we get this merged ASAP (in this RC cycle), hopefully with the patch
that superseded 1/2 from this series so that we don't end up with either
CSI or DE2 broken in the next release?

Cheers,

Paul

> Fixes: b4bdc4fbf8d0 ("soc: sunxi: Deal with the MBUS DMA offsets in a central place")
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
>  drivers/soc/sunxi/sunxi_mbus.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/soc/sunxi/sunxi_mbus.c b/drivers/soc/sunxi/sunxi_mbus.c
> index e9925c8487d7..d90e4a264b6f 100644
> --- a/drivers/soc/sunxi/sunxi_mbus.c
> +++ b/drivers/soc/sunxi/sunxi_mbus.c
> @@ -23,12 +23,7 @@ static const char * const sunxi_mbus_devices[] = {
>  	"allwinner,sun7i-a20-display-engine",
>  	"allwinner,sun8i-a23-display-engine",
>  	"allwinner,sun8i-a33-display-engine",
> -	"allwinner,sun8i-a83t-display-engine",
> -	"allwinner,sun8i-h3-display-engine",
> -	"allwinner,sun8i-r40-display-engine",
> -	"allwinner,sun8i-v3s-display-engine",
>  	"allwinner,sun9i-a80-display-engine",
> -	"allwinner,sun50i-a64-display-engine",
>  
>  	/*
>  	 * And now we have the regular devices connected to the MBUS
> -- 
> 2.30.0
> 

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-01-27 13:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 17:58 [PATCH 1/2] of: device: Allow DMA range map to be set before of_dma_configure_id Paul Kocialkowski
2021-01-15 17:58 ` Paul Kocialkowski
2021-01-15 17:58 ` [PATCH 2/2] soc: sunxi: mbus: Remove DE2 display engine compatibles Paul Kocialkowski
2021-01-15 17:58   ` Paul Kocialkowski
2021-01-27 13:03   ` Paul Kocialkowski [this message]
2021-01-27 13:03     ` Paul Kocialkowski
2021-01-28 10:23     ` Maxime Ripard
2021-01-28 10:23       ` Maxime Ripard
2021-01-16 14:57 ` [PATCH 1/2] of: device: Allow DMA range map to be set before of_dma_configure_id Robin Murphy
2021-01-16 14:57   ` Robin Murphy
2021-01-16 17:07   ` Paul Kocialkowski
2021-01-16 17:07     ` Paul Kocialkowski
2021-01-18 13:27     ` Robin Murphy
2021-01-18 13:27       ` Robin Murphy
2021-01-19  9:04       ` Paul Kocialkowski
2021-01-19  9:04         ` Paul Kocialkowski
2021-01-27 13:01 ` Paul Kocialkowski
2021-01-27 13:01   ` Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBFkh/faoPnTRZtl@aptenodytes \
    --to=paul.kocialkowski@bootlin.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.