From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] syscalls/sched_getparam{01, 02}: Convert to new API and cleanup
Date: Fri, 29 Jan 2021 14:21:48 +0100 [thread overview]
Message-ID: <YBQL7EiQNkqv7nuV@yuki.lan> (raw)
In-Reply-To: <20210126022631.2566169-1-yangx.jy@cn.fujitsu.com>
Hi!
> + if (param.sched_priority) {
> + tst_res(TFAIL,
> + "sched_getparam(%d) got wrong sched_priority %d, expected 0",
> + pids[n], param.sched_priority);
> + exit(1);
I do not think that we should do exit(1) here, since that would cause
TBROK in the library when we reap the children. The failure is
propagated by the tst_res(TFAIL, ...) here already.
With the exit(1) replaced by exit(0):
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-01-29 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 6:37 [LTP] [PATCH 1/2] syscalls/sched_getparam{01, 02}: Convert to new API and cleanup Xiao Yang
2020-12-14 6:37 ` [LTP] [PATCH 2/2] syscalls/sched_getparam03: " Xiao Yang
2021-01-26 2:26 ` [LTP] [PATCH v2 1/2] syscalls/sched_getparam{01, 02}: " Xiao Yang
2021-01-26 2:26 ` [LTP] [PATCH v2 2/2] syscalls/sched_getparam03: " Xiao Yang
2021-01-29 13:38 ` Cyril Hrubis
2021-01-29 13:21 ` Cyril Hrubis [this message]
2021-01-31 7:51 ` [LTP] [PATCH v2 1/2] syscalls/sched_getparam{01, 02}: " Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBQL7EiQNkqv7nuV@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.