* [PATCH] drm: Fix drm_atomic_get_new_crtc_state call error
@ 2021-02-01 9:33 ` Zhaoge Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Zhaoge Zhang @ 2021-02-01 9:33 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel
Cc: linux-kernel, dri-devel
This position is to clear the previous mask flags,
so drm_atomic_get_crtc_state should be used.
Signed-off-by: Zhaoge Zhang <zhangzhaoge@loongson.cn>
---
drivers/gpu/drm/drm_atomic_uapi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
index 268bb69..07fe01b 100644
--- a/drivers/gpu/drm/drm_atomic_uapi.c
+++ b/drivers/gpu/drm/drm_atomic_uapi.c
@@ -313,8 +313,8 @@ drm_atomic_set_crtc_for_connector(struct drm_connector_state *conn_state,
return 0;
if (conn_state->crtc) {
- crtc_state = drm_atomic_get_new_crtc_state(conn_state->state,
- conn_state->crtc);
+ crtc_state = drm_atomic_get_crtc_state(conn_state->state,
+ conn_state->crtc);
crtc_state->connector_mask &=
~drm_connector_mask(conn_state->connector);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm: Fix drm_atomic_get_new_crtc_state call error
@ 2021-02-01 9:33 ` Zhaoge Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Zhaoge Zhang @ 2021-02-01 9:33 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel
Cc: dri-devel, linux-kernel
This position is to clear the previous mask flags,
so drm_atomic_get_crtc_state should be used.
Signed-off-by: Zhaoge Zhang <zhangzhaoge@loongson.cn>
---
drivers/gpu/drm/drm_atomic_uapi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
index 268bb69..07fe01b 100644
--- a/drivers/gpu/drm/drm_atomic_uapi.c
+++ b/drivers/gpu/drm/drm_atomic_uapi.c
@@ -313,8 +313,8 @@ drm_atomic_set_crtc_for_connector(struct drm_connector_state *conn_state,
return 0;
if (conn_state->crtc) {
- crtc_state = drm_atomic_get_new_crtc_state(conn_state->state,
- conn_state->crtc);
+ crtc_state = drm_atomic_get_crtc_state(conn_state->state,
+ conn_state->crtc);
crtc_state->connector_mask &=
~drm_connector_mask(conn_state->connector);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Fix drm_atomic_get_new_crtc_state call error
2021-02-01 9:33 ` Zhaoge Zhang
@ 2021-02-02 8:38 ` Ville Syrjälä
-1 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2021-02-02 8:38 UTC (permalink / raw)
To: Zhaoge Zhang; +Cc: tzimmermann, airlied, linux-kernel, dri-devel
On Mon, Feb 01, 2021 at 05:33:44PM +0800, Zhaoge Zhang wrote:
> This position is to clear the previous mask flags,
> so drm_atomic_get_crtc_state should be used.
>
> Signed-off-by: Zhaoge Zhang <zhangzhaoge@loongson.cn>
> ---
> drivers/gpu/drm/drm_atomic_uapi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
> index 268bb69..07fe01b 100644
> --- a/drivers/gpu/drm/drm_atomic_uapi.c
> +++ b/drivers/gpu/drm/drm_atomic_uapi.c
> @@ -313,8 +313,8 @@ drm_atomic_set_crtc_for_connector(struct drm_connector_state *conn_state,
> return 0;
>
> if (conn_state->crtc) {
> - crtc_state = drm_atomic_get_new_crtc_state(conn_state->state,
> - conn_state->crtc);
> + crtc_state = drm_atomic_get_crtc_state(conn_state->state,
> + conn_state->crtc);
drm_atomic_get_new_crtc_state() should be fine here since
drm_atomic_get_connector_state() will have added the old
crtc to the state already.
>
> crtc_state->connector_mask &=
> ~drm_connector_mask(conn_state->connector);
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Fix drm_atomic_get_new_crtc_state call error
@ 2021-02-02 8:38 ` Ville Syrjälä
0 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2021-02-02 8:38 UTC (permalink / raw)
To: Zhaoge Zhang
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
linux-kernel, dri-devel
On Mon, Feb 01, 2021 at 05:33:44PM +0800, Zhaoge Zhang wrote:
> This position is to clear the previous mask flags,
> so drm_atomic_get_crtc_state should be used.
>
> Signed-off-by: Zhaoge Zhang <zhangzhaoge@loongson.cn>
> ---
> drivers/gpu/drm/drm_atomic_uapi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
> index 268bb69..07fe01b 100644
> --- a/drivers/gpu/drm/drm_atomic_uapi.c
> +++ b/drivers/gpu/drm/drm_atomic_uapi.c
> @@ -313,8 +313,8 @@ drm_atomic_set_crtc_for_connector(struct drm_connector_state *conn_state,
> return 0;
>
> if (conn_state->crtc) {
> - crtc_state = drm_atomic_get_new_crtc_state(conn_state->state,
> - conn_state->crtc);
> + crtc_state = drm_atomic_get_crtc_state(conn_state->state,
> + conn_state->crtc);
drm_atomic_get_new_crtc_state() should be fine here since
drm_atomic_get_connector_state() will have added the old
crtc to the state already.
>
> crtc_state->connector_mask &=
> ~drm_connector_mask(conn_state->connector);
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-02 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-01 9:33 [PATCH] drm: Fix drm_atomic_get_new_crtc_state call error Zhaoge Zhang
2021-02-01 9:33 ` Zhaoge Zhang
2021-02-02 8:38 ` Ville Syrjälä
2021-02-02 8:38 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.