* [PATCH] Input: Use true and false for bool variable
@ 2021-02-18 10:23 Jiapeng Chong
2021-02-19 3:34 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-02-18 10:23 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: rydberg, linux-input, linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in
function 'zinitix_init_touch' with return type bool.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/input/touchscreen/zinitix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/zinitix.c b/drivers/input/touchscreen/zinitix.c
index a3e3adb..acb1d53 100644
--- a/drivers/input/touchscreen/zinitix.c
+++ b/drivers/input/touchscreen/zinitix.c
@@ -247,7 +247,7 @@ static bool zinitix_init_touch(struct bt541_ts_data *bt541)
udelay(10);
}
- return 0;
+ return false;
}
static int zinitix_init_regulators(struct bt541_ts_data *bt541)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: Use true and false for bool variable
2021-02-18 10:23 [PATCH] Input: Use true and false for bool variable Jiapeng Chong
@ 2021-02-19 3:34 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2021-02-19 3:34 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: rydberg, linux-input, linux-kernel
Hi,
On Thu, Feb 18, 2021 at 06:23:55PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in
> function 'zinitix_init_touch' with return type bool.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/input/touchscreen/zinitix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/zinitix.c b/drivers/input/touchscreen/zinitix.c
> index a3e3adb..acb1d53 100644
> --- a/drivers/input/touchscreen/zinitix.c
> +++ b/drivers/input/touchscreen/zinitix.c
> @@ -247,7 +247,7 @@ static bool zinitix_init_touch(struct bt541_ts_data *bt541)
> udelay(10);
> }
>
> - return 0;
> + return false;
This is incorrect, as earlier we try to return error codes from this
function. It needs to be changed to return int, I'll take care of it.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-19 3:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-18 10:23 [PATCH] Input: Use true and false for bool variable Jiapeng Chong
2021-02-19 3:34 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.