From: Minchan Kim <minchan@kernel.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
willy@infradead.org, gregkh@linuxfoundation.org,
surenb@google.com, joaodias@google.com,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH v3] mm: cma: support sysfs
Date: Wed, 10 Feb 2021 07:59:15 -0800 [thread overview]
Message-ID: <YCQC02Qr417cdnSI@google.com> (raw)
In-Reply-To: <070ca72a-c99f-a2a7-c460-0a823cc262f4@nvidia.com>
On Wed, Feb 10, 2021 at 12:05:48AM -0800, John Hubbard wrote:
> On 2/9/21 11:55 PM, Minchan Kim wrote:
> > Since CMA is getting used more widely, it's more important to
> > keep monitoring CMA statistics for system health since it's
> > directly related to user experience.
> >
> > This patch introduces sysfs statistics for CMA, in order to provide
> > some basic monitoring of the CMA allocator.
> >
> > * the number of CMA page allocation attempts
> > * the number of CMA page allocation failures
> >
> > These two values allow the user to calcuate the allocation
> > failure rate for each CMA area.
> >
> > e.g.)
> > /sys/kernel/mm/cma/WIFI/cma_alloc_pages_[attempts|fails]
> > /sys/kernel/mm/cma/SENSOR/cma_alloc_pages_[attempts|fails]
> > /sys/kernel/mm/cma/BLUETOOTH/cma_alloc_pages_[attempts|fails]
> >
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > ---
>
> Looks good.
>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Thanks for reviewing, John and Greg!
next prev parent reply other threads:[~2021-02-10 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 7:55 [PATCH v3] mm: cma: support sysfs Minchan Kim
2021-02-10 8:02 ` Greg KH
2021-02-10 8:05 ` John Hubbard
2021-02-10 15:59 ` Minchan Kim [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-03 20:50 Minchan Kim
2021-03-03 22:44 ` Andrew Morton
2021-03-04 1:38 ` Minchan Kim
2021-03-04 6:09 ` Andrew Morton
2021-03-04 15:39 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCQC02Qr417cdnSI@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jhubbard@nvidia.com \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.