From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
joaodias@google.com, willy@infradead.org, surenb@google.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH v3] mm: cma: support sysfs
Date: Thu, 4 Mar 2021 07:39:34 -0800 [thread overview]
Message-ID: <YED/NlZJ9QmMss4I@google.com> (raw)
In-Reply-To: <20210303220957.0525de2aebc2c55ad9435cdc@linux-foundation.org>
On Wed, Mar 03, 2021 at 10:09:57PM -0800, Andrew Morton wrote:
> On Wed, 3 Mar 2021 17:38:12 -0800 Minchan Kim <minchan@kernel.org> wrote:
>
> > > > #endif
> > > > char name[CMA_MAX_NAME];
> > > > +#ifdef CONFIG_CMA_SYSFS
> > > > + struct cma_stat *stat;
> > > > +#endif
> > > > };
> > >
> > > Why aren't the stat fields simply placed directly into struct cma_stat?
> >
> > It have a related long discussion.
> > https://lore.kernel.org/linux-mm/YCIoHBGELFWAyfMi@kroah.com/
> > https://lore.kernel.org/linux-mm/YCLLKDEQ4NYqb5Y5@kroah.com/
> >
> > TLDR - Greg really want to see kobject stuff working as dynamic
> > property.
>
> Please add to changelog?
Sure.
>
> > >
> > > ?
> > >
> > > > + if (!cma_stats) {
> > > > + pr_err("failed to create cma_stats\n");
> > >
> > > Probably unneeded - the ENOMEM stack backtrace will point straight here.
> >
> > I failed to find the point you mentioned to print backtrace.
> > Where code do you mean to dump the backtrace?
>
> The thing which __GFP_NOWARN disables.
Got the point.
next prev parent reply other threads:[~2021-03-04 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 20:50 [PATCH v3] mm: cma: support sysfs Minchan Kim
2021-03-03 22:44 ` Andrew Morton
2021-03-04 1:38 ` Minchan Kim
2021-03-04 6:09 ` Andrew Morton
2021-03-04 15:39 ` Minchan Kim [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-10 7:55 Minchan Kim
2021-02-10 8:02 ` Greg KH
2021-02-10 8:05 ` John Hubbard
2021-02-10 15:59 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YED/NlZJ9QmMss4I@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jhubbard@nvidia.com \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.