From: Petr Vorel <pvorel@suse.cz>
To: Jens Axboe <axboe@kernel.dk>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, Nicolai Stange <nstange@suse.de>,
Martin Doucha <mdoucha@suse.cz>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
ltp@lists.linux.it, Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: CVE-2020-29373 reproducer fails on v5.11
Date: Fri, 12 Feb 2021 13:49:41 +0100 [thread overview]
Message-ID: <YCZ5ZS5Sr2tPiUvP@pevik> (raw)
In-Reply-To: <270c474f-476a-65d2-1f5b-57d3330efb04@kernel.dk>
Hi all,
> On 2/10/21 12:32 PM, Pavel Begunkov wrote:
> > On 10/02/2021 19:08, Petr Vorel wrote:
> >> Hi all,
> >> I found that the reproducer for CVE-2020-29373 from Nicolai Stange (source attached),
> >> which was backported to LTP as io_uring02 by Martin Doucha [1] is failing since
> >> 10cad2c40dcb ("io_uring: don't take fs for recvmsg/sendmsg") from v5.11-rc1.
> > Thanks for letting us know, we need to revert it
> I'll queue up a revert. Would also be nice to turn that into
> a liburing regression test.
Jens (or others), could you please have look that the other commit 907d1df30a51
("io_uring: fix wqe->lock/completion_lock deadlock") from v5.11-rc6 didn't cause
any regression? Changed behavior causing io_uring02 test [1] and the original
reproducer [2] to fail is probably a test bug, but better double check that.
Kind regards,
Petr
[1] https://github.com/linux-test-project/ltp/tree/master/testcases/kernel/syscalls/io_uring/io_uring02.c
[2] https://lore.kernel.org/io-uring/YCQvL8%2FDMNVLLuuf@pevik/
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] CVE-2020-29373 reproducer fails on v5.11
Date: Fri, 12 Feb 2021 13:49:41 +0100 [thread overview]
Message-ID: <YCZ5ZS5Sr2tPiUvP@pevik> (raw)
In-Reply-To: <270c474f-476a-65d2-1f5b-57d3330efb04@kernel.dk>
Hi all,
> On 2/10/21 12:32 PM, Pavel Begunkov wrote:
> > On 10/02/2021 19:08, Petr Vorel wrote:
> >> Hi all,
> >> I found that the reproducer for CVE-2020-29373 from Nicolai Stange (source attached),
> >> which was backported to LTP as io_uring02 by Martin Doucha [1] is failing since
> >> 10cad2c40dcb ("io_uring: don't take fs for recvmsg/sendmsg") from v5.11-rc1.
> > Thanks for letting us know, we need to revert it
> I'll queue up a revert. Would also be nice to turn that into
> a liburing regression test.
Jens (or others), could you please have look that the other commit 907d1df30a51
("io_uring: fix wqe->lock/completion_lock deadlock") from v5.11-rc6 didn't cause
any regression? Changed behavior causing io_uring02 test [1] and the original
reproducer [2] to fail is probably a test bug, but better double check that.
Kind regards,
Petr
[1] https://github.com/linux-test-project/ltp/tree/master/testcases/kernel/syscalls/io_uring/io_uring02.c
[2] https://lore.kernel.org/io-uring/YCQvL8%2FDMNVLLuuf@pevik/
next prev parent reply other threads:[~2021-02-12 12:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 19:08 CVE-2020-29373 reproducer fails on v5.11 Petr Vorel
2021-02-10 19:08 ` [LTP] " Petr Vorel
2021-02-10 19:32 ` Pavel Begunkov
2021-02-10 19:32 ` [LTP] " Pavel Begunkov
2021-02-10 19:37 ` Jens Axboe
2021-02-10 19:37 ` [LTP] " Jens Axboe
2021-02-10 21:39 ` Petr Vorel
2021-02-10 21:39 ` [LTP] " Petr Vorel
2021-02-12 12:49 ` Petr Vorel [this message]
2021-02-12 12:49 ` Petr Vorel
2021-02-12 13:05 ` Pavel Begunkov
2021-02-12 13:05 ` [LTP] " Pavel Begunkov
2021-02-15 7:04 ` Petr Vorel
2021-02-15 7:04 ` [LTP] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCZ5ZS5Sr2tPiUvP@pevik \
--to=pvorel@suse.cz \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bjorn.andersson@linaro.org \
--cc=io-uring@vger.kernel.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
--cc=nstange@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.