From: Al Viro <viro@zeniv.linux.org.uk>
To: kbuild-all@lists.01.org
Subject: Re: arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user'
Date: Sun, 14 Feb 2021 22:59:51 +0000 [thread overview]
Message-ID: <YCmrZ7i2TXZZXjLy@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <8b064ade-ccc2-909f-5ef9-ca8287212049@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 994 bytes --]
On Thu, Feb 11, 2021 at 06:52:36PM -0800, Randy Dunlap wrote:
> >>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' [-Werror=missing-prototypes]
> > 328 | csum_and_copy_from_user(const void __user *src, void *dst, int len,
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> > arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototype for 'csum_partial_copy_nocheck' [-Werror=missing-prototypes]
> > 375 | csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
>
> I can't reproduce this (wrong version of gcc) but it looks like adding
> #include <asm/checksum.h>
> to arch/alpha/lib/csum_partial_copy.c should fix the warnings.
I'd rather go with net/checksum.h; converting all includes outside of
net/checksum.h itself would have to wait, but let's not breed more of
those without a good reason...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user'
Date: Sun, 14 Feb 2021 22:59:51 +0000 [thread overview]
Message-ID: <YCmrZ7i2TXZZXjLy@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <8b064ade-ccc2-909f-5ef9-ca8287212049@infradead.org>
On Thu, Feb 11, 2021 at 06:52:36PM -0800, Randy Dunlap wrote:
> >>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' [-Werror=missing-prototypes]
> > 328 | csum_and_copy_from_user(const void __user *src, void *dst, int len,
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> > arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototype for 'csum_partial_copy_nocheck' [-Werror=missing-prototypes]
> > 375 | csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
>
> I can't reproduce this (wrong version of gcc) but it looks like adding
> #include <asm/checksum.h>
> to arch/alpha/lib/csum_partial_copy.c should fix the warnings.
I'd rather go with net/checksum.h; converting all includes outside of
net/checksum.h itself would have to wait, but let's not breed more of
those without a good reason...
next prev parent reply other threads:[~2021-02-14 22:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 23:26 arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' kernel test robot
2021-02-11 23:26 ` kernel test robot
2021-02-12 2:52 ` Randy Dunlap
2021-02-12 2:52 ` Randy Dunlap
2021-02-14 22:59 ` Al Viro [this message]
2021-02-14 22:59 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2021-02-12 8:33 kernel test robot
2021-02-12 8:33 ` kernel test robot
2021-03-19 11:52 kernel test robot
2021-03-19 11:52 ` kernel test robot
2021-03-19 19:10 kernel test robot
2021-03-19 19:10 ` kernel test robot
2021-05-06 14:26 kernel test robot
2021-05-06 14:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCmrZ7i2TXZZXjLy@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.