From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Jacob Pan <jacob.jun.pan@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
zhangfei.gao@foxmail.com,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH v6 08/12] fork: Clear PASID for new mm
Date: Tue, 2 Mar 2021 11:43:36 +0100 [thread overview]
Message-ID: <YD4W2GPg4OUFVWty@myrica> (raw)
In-Reply-To: <20210301150011.766e70a3@jacob-builder>
On Mon, Mar 01, 2021 at 03:00:11PM -0800, Jacob Pan wrote:
> > functionality is not a problem without this patch on x86. But I think
> I feel the reason that x86 doesn't care is that mm->pasid is not used
> unless bind_mm is called.
I think vt-d also maintains the global_svm_list, that tells whether a
PASID is already allocated for the mm. The SMMU driver relies only on
iommu_sva_alloc_pasid() for this.
> For the fork children even mm->pasid is non-zero,
> it has no effect since it is not loaded onto MSRs.
> Perhaps you could also add a check or WARN_ON(!mm->pasid) in load_pasid()?
>
> > we do need to have this patch in the kernel because PASID is per addr
> > space and two addr spaces shouldn't have the same PASID.
> >
> Agreed.
>
> > Who will accept this patch?
It's not clear from get_maintainers.pl, but I guess it should go via
linux-mm. Since the list wasn't cc'd on the original patch, I resent it.
Thanks,
Jean
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Jacob Pan <jacob.jun.pan@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>, Joerg Roedel <joro@8bytes.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Ashok Raj <ashok.raj@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org, zhangfei.gao@foxmail.com,
linux-mm@kvack.org
Subject: Re: [PATCH v6 08/12] fork: Clear PASID for new mm
Date: Tue, 2 Mar 2021 11:43:36 +0100 [thread overview]
Message-ID: <YD4W2GPg4OUFVWty@myrica> (raw)
In-Reply-To: <20210301150011.766e70a3@jacob-builder>
On Mon, Mar 01, 2021 at 03:00:11PM -0800, Jacob Pan wrote:
> > functionality is not a problem without this patch on x86. But I think
> I feel the reason that x86 doesn't care is that mm->pasid is not used
> unless bind_mm is called.
I think vt-d also maintains the global_svm_list, that tells whether a
PASID is already allocated for the mm. The SMMU driver relies only on
iommu_sva_alloc_pasid() for this.
> For the fork children even mm->pasid is non-zero,
> it has no effect since it is not loaded onto MSRs.
> Perhaps you could also add a check or WARN_ON(!mm->pasid) in load_pasid()?
>
> > we do need to have this patch in the kernel because PASID is per addr
> > space and two addr spaces shouldn't have the same PASID.
> >
> Agreed.
>
> > Who will accept this patch?
It's not clear from get_maintainers.pl, but I guess it should go via
linux-mm. Since the list wasn't cc'd on the original patch, I resent it.
Thanks,
Jean
next prev parent reply other threads:[~2021-03-02 10:44 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 23:47 [PATCH v6 00/12] x86: tag application address space for devices Fenghua Yu
2020-07-13 23:47 ` Fenghua Yu
2020-07-13 23:47 ` Fenghua Yu
2020-07-13 23:47 ` [PATCH v6 01/12] iommu: Change type of pasid to u32 Fenghua Yu
2020-07-13 23:47 ` Fenghua Yu
2020-07-13 23:47 ` Fenghua Yu
2020-07-14 2:45 ` Liu, Yi L
2020-07-14 2:45 ` Liu, Yi L
2020-07-14 2:45 ` Liu, Yi L
2020-07-14 13:54 ` Fenghua Yu
2020-07-14 13:54 ` Fenghua Yu
2020-07-14 13:54 ` Fenghua Yu
2020-07-14 13:56 ` Liu, Yi L
2020-07-14 13:56 ` Liu, Yi L
2020-07-14 13:56 ` Liu, Yi L
2020-07-22 14:03 ` Joerg Roedel
2020-07-22 14:03 ` Joerg Roedel
2020-07-22 14:03 ` Joerg Roedel
2020-07-22 17:21 ` Fenghua Yu
2020-07-22 17:21 ` Fenghua Yu
2020-07-22 17:21 ` Fenghua Yu
2020-07-13 23:47 ` [PATCH v6 02/12] iommu/vt-d: Change flags type to unsigned int in binding mm Fenghua Yu
2020-07-13 23:47 ` Fenghua Yu
2020-07-13 23:47 ` Fenghua Yu
2020-07-13 23:47 ` [PATCH v6 03/12] docs: x86: Add documentation for SVA (Shared Virtual Addressing) Fenghua Yu
2020-07-13 23:47 ` Fenghua Yu
2020-07-13 23:47 ` Fenghua Yu
2020-07-14 3:25 ` Liu, Yi L
2020-07-14 3:25 ` Liu, Yi L
2020-07-14 3:25 ` Liu, Yi L
2020-07-15 23:32 ` Fenghua Yu
2020-07-15 23:32 ` Fenghua Yu
2020-07-15 23:32 ` Fenghua Yu
2020-07-13 23:47 ` [PATCH v6 04/12] x86/cpufeatures: Enumerate ENQCMD and ENQCMDS instructions Fenghua Yu
2020-07-13 23:47 ` Fenghua Yu
2020-07-13 23:47 ` Fenghua Yu
2020-07-13 23:48 ` [PATCH v6 05/12] x86/fpu/xstate: Add supervisor PASID state for ENQCMD feature Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` [PATCH v6 06/12] x86/msr-index: Define IA32_PASID MSR Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` [PATCH v6 07/12] mm: Define pasid in mm Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` [PATCH v6 08/12] fork: Clear PASID for new mm Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2021-02-24 10:19 ` Jean-Philippe Brucker
2021-02-24 10:19 ` Jean-Philippe Brucker
2021-02-25 22:17 ` Fenghua Yu
2021-02-25 22:17 ` Fenghua Yu
2021-03-01 23:00 ` Jacob Pan
2021-03-01 23:00 ` Jacob Pan
2021-03-02 10:43 ` Jean-Philippe Brucker [this message]
2021-03-02 10:43 ` Jean-Philippe Brucker
2020-07-13 23:48 ` [PATCH v6 09/12] x86/process: Clear PASID state for a newly forked/cloned thread Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-08-01 1:44 ` Andy Lutomirski
2020-08-01 1:44 ` Andy Lutomirski
2020-08-01 1:44 ` Andy Lutomirski
2020-07-13 23:48 ` [PATCH v6 10/12] x86/mmu: Allocate/free PASID Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` [PATCH v6 11/12] sched: Define and initialize a flag to identify valid PASID in the task Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` [PATCH v6 12/12] x86/traps: Fix up invalid PASID Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-13 23:48 ` Fenghua Yu
2020-07-31 23:34 ` Andy Lutomirski
2020-07-31 23:34 ` Andy Lutomirski
2020-07-31 23:34 ` Andy Lutomirski
2020-08-01 0:42 ` Fenghua Yu
2020-08-01 0:42 ` Fenghua Yu
2020-08-01 0:42 ` Fenghua Yu
2020-08-03 15:03 ` Dave Hansen
2020-08-03 15:03 ` Dave Hansen
2020-08-03 15:03 ` Dave Hansen
2020-08-03 15:12 ` Andy Lutomirski
2020-08-03 15:12 ` Andy Lutomirski
2020-08-03 15:12 ` Andy Lutomirski
2020-08-03 15:19 ` Raj, Ashok
2020-08-03 15:19 ` Raj, Ashok
2020-08-03 15:19 ` Raj, Ashok
2020-08-03 16:36 ` Dave Hansen
2020-08-03 16:36 ` Dave Hansen
2020-08-03 16:36 ` Dave Hansen
2020-08-03 17:16 ` Andy Lutomirski
2020-08-03 17:16 ` Andy Lutomirski
2020-08-03 17:16 ` Andy Lutomirski
2020-08-03 17:34 ` Dave Hansen
2020-08-03 17:34 ` Dave Hansen
2020-08-03 17:34 ` Dave Hansen
2020-08-03 19:24 ` Andy Lutomirski
2020-08-03 19:24 ` Andy Lutomirski
2020-08-03 19:24 ` Andy Lutomirski
2020-08-01 1:28 ` Andy Lutomirski
2020-08-01 1:28 ` Andy Lutomirski
2020-08-01 1:28 ` Andy Lutomirski
2020-08-03 17:19 ` Fenghua Yu
2020-08-03 17:19 ` Fenghua Yu
2020-08-03 17:19 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD4W2GPg4OUFVWty@myrica \
--to=jean-philippe@linaro.org \
--cc=ashok.raj@intel.com \
--cc=fenghua.yu@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zhangfei.gao@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.