From: Petr Vorel <pvorel@suse.cz>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Cc: Mimi Zohar <zohar@linux.ibm.com>,
Greg KH <gregkh@linuxfoundation.org>,
bauerman@linux.ibm.com, dmitry.kasatkin@gmail.com,
ebiederm@xmission.com, sashal@kernel.org,
tyhicks@linux.microsoft.com, linux-integrity@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ima: Free IMA measurement buffer on error
Date: Wed, 24 Feb 2021 00:33:58 +0100 [thread overview]
Message-ID: <YDWQ5rBBe8t7+Bs2@pevik> (raw)
In-Reply-To: <b8573374-86d0-f679-6c9f-a61b2bc6f7ea@linux.microsoft.com>
Hi all,
<snip>
> > > > <formletter>
> > > > This is not the correct way to submit patches for inclusion in the
> > > > stable kernel tree. Please read:
> > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > > > for how to do this properly.
> > > > </formletter>
> > > Thanks for the info Greg.
> > > I will re-submit the two patches in the proper format.
> > No need. I'm testing these patches now. I'm not exactly sure what the
> > problem is. Stable wasn't Cc'ed. Is it that you sent the patch
> > directly to Greg or added "Fixes"?
> I had not Cced stable, but had "Fixes" tag in the patch.
> Fixes: 7b8589cc29e7 ("ima: on soft reboot, save the measurement list")
> The problem is that the buffer allocated for forwarding the IMA measurement
> list is not freed - at the end of the kexec call and also in an error path.
> Please see the patch description for
> [PATCH v2 2/2] ima: Free IMA measurement buffer after kexec syscall
> IMA allocates kernel virtual memory to carry forward the measurement
> list, from the current kernel to the next kernel on kexec system call,
> in ima_add_kexec_buffer() function. This buffer is not freed before
> completing the kexec system call resulting in memory leak.
> thanks,
> -lakshmi
Mimi, Lakshmi, it looks like these two fixes haven't been submitted to stable kernels.
Could you please submit them?
Thanks a lot!
Kind regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Cc: sashal@kernel.org, Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
tyhicks@linux.microsoft.com, ebiederm@xmission.com,
dmitry.kasatkin@gmail.com, linux-integrity@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com
Subject: Re: [PATCH v2 1/2] ima: Free IMA measurement buffer on error
Date: Wed, 24 Feb 2021 00:33:58 +0100 [thread overview]
Message-ID: <YDWQ5rBBe8t7+Bs2@pevik> (raw)
In-Reply-To: <b8573374-86d0-f679-6c9f-a61b2bc6f7ea@linux.microsoft.com>
Hi all,
<snip>
> > > > <formletter>
> > > > This is not the correct way to submit patches for inclusion in the
> > > > stable kernel tree. Please read:
> > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > > > for how to do this properly.
> > > > </formletter>
> > > Thanks for the info Greg.
> > > I will re-submit the two patches in the proper format.
> > No need. I'm testing these patches now. I'm not exactly sure what the
> > problem is. Stable wasn't Cc'ed. Is it that you sent the patch
> > directly to Greg or added "Fixes"?
> I had not Cced stable, but had "Fixes" tag in the patch.
> Fixes: 7b8589cc29e7 ("ima: on soft reboot, save the measurement list")
> The problem is that the buffer allocated for forwarding the IMA measurement
> list is not freed - at the end of the kexec call and also in an error path.
> Please see the patch description for
> [PATCH v2 2/2] ima: Free IMA measurement buffer after kexec syscall
> IMA allocates kernel virtual memory to carry forward the measurement
> list, from the current kernel to the next kernel on kexec system call,
> in ima_add_kexec_buffer() function. This buffer is not freed before
> completing the kexec system call resulting in memory leak.
> thanks,
> -lakshmi
Mimi, Lakshmi, it looks like these two fixes haven't been submitted to stable kernels.
Could you please submit them?
Thanks a lot!
Kind regards,
Petr
next prev parent reply other threads:[~2021-02-23 23:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 17:49 [PATCH v2 1/2] ima: Free IMA measurement buffer on error Lakshmi Ramasubramanian
2021-02-04 17:49 ` [PATCH v2 2/2] ima: Free IMA measurement buffer after kexec syscall Lakshmi Ramasubramanian
2021-02-05 10:05 ` Greg KH
2021-02-05 10:05 ` Greg KH
2021-02-05 10:05 ` [PATCH v2 1/2] ima: Free IMA measurement buffer on error Greg KH
2021-02-05 10:05 ` Greg KH
2021-02-05 17:39 ` Lakshmi Ramasubramanian
2021-02-05 17:39 ` Lakshmi Ramasubramanian
2021-02-05 17:49 ` Mimi Zohar
2021-02-05 17:49 ` Mimi Zohar
2021-02-05 17:59 ` Lakshmi Ramasubramanian
2021-02-05 17:59 ` Lakshmi Ramasubramanian
2021-02-23 23:33 ` Petr Vorel [this message]
2021-02-23 23:33 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDWQ5rBBe8t7+Bs2@pevik \
--to=pvorel@suse.cz \
--cc=bauerman@linux.ibm.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nramas@linux.microsoft.com \
--cc=sashal@kernel.org \
--cc=tyhicks@linux.microsoft.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.