All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Riesen <alexander.riesen@cetitec.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Simon Ser <contact@emersion.fr>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Ben Skeggs <bskeggs@redhat.com>,
	nouveau <nouveau@lists.freedesktop.org>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [Nouveau] [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace
Date: Wed, 24 Feb 2021 17:35:14 +0100	[thread overview]
Message-ID: <YDaAQts9LIb5h3xd@pflmari> (raw)
In-Reply-To: <CAKb7UvgQXXThAfqJo+FEfUbgLtGzb2kvg9aSFXZn_XWivsv48Q@mail.gmail.com>

Ilia Mirkin, Wed, Feb 24, 2021 16:10:57 +0100:
> On Wed, Feb 24, 2021 at 4:09 AM Alex Riesen <alexander.riesen@cetitec.com> wrote:
> > Ilia Mirkin, Tue, Feb 23, 2021 19:13:59 +0100:
> > > It might also be worthwhile just testing if the 256x256 cursor works
> > > quite the way one would want. If you're interested, grab libdrm,
> > > there's a test called 'modetest', which has an option to enable a
> > > moving cursor (-c iirc). It's hard-coded to 64x64, so you'll have to
> > > modify it there too (and probably change the pattern from plain gray
> > > to any one of the other ones).
> >
> > I am interested, so I did.
> >
> > If I start the test without X running, the sprite of 256x256 cursor always
> > contained horizontal lines across it, both with commit reverted and vanilla
> > v5.11. Similarly, the 64x64 cursor has no lines across it in both kernels.
> >
> > The test does not seem to work at all if there is an X server running (using
> > modesetting driver): modetest complained about permission denied to set the
> > mode, and just sits there, drawing nothing on the displays.
> > So I could not run the test in the environment of original problem.
> > Am I starting it correctly? Is the change in modetest.c correct?
> 
> Looks right. Although TBH I'd just start it on a single display (I
> forgot you could even do multiple displays). You should be able to
> start it with the X server running if you switch to a vt (and run it
> as root). If you can't, that means the modesetting driver is
> forgetting to do something in the LeaveVT function.

Tried that and yes, modetest works. Even without running it as root.

> The fact that you're getting lines with modetest means there's
> something wrong with 256x256. What if you do 128x128 -- does that work
> OK?

Yes. Unfortunately in both cases.

> Simon, you tested on a GK208, that has a slightly later display
> controller than the GK104 -- can you try to reproduce Alex's results?
> Perhaps there was a problem with the GK10x's and it starts working OK
> with the GK110 disp.
> 
> I don't have any GK10x's in my posession (I have nearly every other
> iteration of the display controller), but hopefully someone on the
> nouveau team will be able to dig one up and reproduce.
> 
> Thanks for testing, Alex!

You're welcome! As I'm stuck with this particular machine for foreseeable
future, you can count on mine GK10x as well.

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

WARNING: multiple messages have this Message-ID (diff)
From: Alex Riesen <alexander.riesen@cetitec.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	Ben Skeggs <bskeggs@redhat.com>,
	nouveau <nouveau@lists.freedesktop.org>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace
Date: Wed, 24 Feb 2021 17:35:14 +0100	[thread overview]
Message-ID: <YDaAQts9LIb5h3xd@pflmari> (raw)
In-Reply-To: <CAKb7UvgQXXThAfqJo+FEfUbgLtGzb2kvg9aSFXZn_XWivsv48Q@mail.gmail.com>

Ilia Mirkin, Wed, Feb 24, 2021 16:10:57 +0100:
> On Wed, Feb 24, 2021 at 4:09 AM Alex Riesen <alexander.riesen@cetitec.com> wrote:
> > Ilia Mirkin, Tue, Feb 23, 2021 19:13:59 +0100:
> > > It might also be worthwhile just testing if the 256x256 cursor works
> > > quite the way one would want. If you're interested, grab libdrm,
> > > there's a test called 'modetest', which has an option to enable a
> > > moving cursor (-c iirc). It's hard-coded to 64x64, so you'll have to
> > > modify it there too (and probably change the pattern from plain gray
> > > to any one of the other ones).
> >
> > I am interested, so I did.
> >
> > If I start the test without X running, the sprite of 256x256 cursor always
> > contained horizontal lines across it, both with commit reverted and vanilla
> > v5.11. Similarly, the 64x64 cursor has no lines across it in both kernels.
> >
> > The test does not seem to work at all if there is an X server running (using
> > modesetting driver): modetest complained about permission denied to set the
> > mode, and just sits there, drawing nothing on the displays.
> > So I could not run the test in the environment of original problem.
> > Am I starting it correctly? Is the change in modetest.c correct?
> 
> Looks right. Although TBH I'd just start it on a single display (I
> forgot you could even do multiple displays). You should be able to
> start it with the X server running if you switch to a vt (and run it
> as root). If you can't, that means the modesetting driver is
> forgetting to do something in the LeaveVT function.

Tried that and yes, modetest works. Even without running it as root.

> The fact that you're getting lines with modetest means there's
> something wrong with 256x256. What if you do 128x128 -- does that work
> OK?

Yes. Unfortunately in both cases.

> Simon, you tested on a GK208, that has a slightly later display
> controller than the GK104 -- can you try to reproduce Alex's results?
> Perhaps there was a problem with the GK10x's and it starts working OK
> with the GK110 disp.
> 
> I don't have any GK10x's in my posession (I have nearly every other
> iteration of the display controller), but hopefully someone on the
> nouveau team will be able to dig one up and reproduce.
> 
> Thanks for testing, Alex!

You're welcome! As I'm stuck with this particular machine for foreseeable
future, you can count on mine GK10x as well.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-02-24 16:35 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19  1:54 [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Lyude Paul
2021-01-19  1:54 ` Lyude Paul
2021-01-19  1:54 ` Lyude Paul
     [not found] ` <20210119015415.2511028-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-01-19  1:54   ` [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace Lyude Paul
2021-01-19  1:54     ` Lyude Paul
2021-01-19  1:54     ` Lyude Paul
     [not found]     ` <20210119015415.2511028-2-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-01-19 10:22       ` Simon Ser
2021-01-19 10:22         ` Simon Ser
2021-01-19 10:22         ` Simon Ser
2021-02-23 14:15     ` [Nouveau] " Alex Riesen
2021-02-23 14:15       ` Alex Riesen
2021-02-23 14:15       ` Alex Riesen
2021-02-23 14:56       ` [Nouveau] " Ilia Mirkin
2021-02-23 14:56         ` Ilia Mirkin
2021-02-23 14:56         ` Ilia Mirkin
2021-02-23 15:36         ` [Nouveau] " Alex Riesen
2021-02-23 15:36           ` Alex Riesen
2021-02-23 15:36           ` Alex Riesen
2021-02-23 15:46           ` [Nouveau] " Ilia Mirkin
2021-02-23 15:46             ` Ilia Mirkin
2021-02-23 15:46             ` Ilia Mirkin
2021-02-23 15:51             ` [Nouveau] " Alex Riesen
2021-02-23 15:51               ` Alex Riesen
2021-02-23 15:51               ` Alex Riesen
2021-02-23 16:22               ` [Nouveau] " Alex Riesen
2021-02-23 16:22                 ` Alex Riesen
2021-02-23 16:22                 ` Alex Riesen
2021-02-23 18:13                 ` [Nouveau] " Ilia Mirkin
2021-02-23 18:13                   ` Ilia Mirkin
2021-02-23 18:13                   ` Ilia Mirkin
2021-02-24  9:08                   ` [Nouveau] " Alex Riesen
2021-02-24  9:08                     ` Alex Riesen
2021-02-24  9:08                     ` Alex Riesen
2021-02-24 15:10                     ` [Nouveau] " Ilia Mirkin
2021-02-24 15:10                       ` Ilia Mirkin
2021-02-24 16:35                       ` Alex Riesen [this message]
2021-02-24 16:35                         ` Alex Riesen
2021-02-24 16:48                         ` [Nouveau] " Ilia Mirkin
2021-02-24 16:48                           ` Ilia Mirkin
2021-02-24 16:53                           ` [Nouveau] " Alex Riesen
2021-02-24 16:53                             ` Alex Riesen
2021-02-24 16:57                             ` [Nouveau] " Ilia Mirkin
2021-02-24 16:57                               ` Ilia Mirkin
2021-02-24 17:02                               ` [Nouveau] " Alex Riesen
2021-02-24 17:02                                 ` Alex Riesen
2021-02-24 17:47                                 ` [Nouveau] " Ilia Mirkin
2021-02-24 17:47                                   ` Ilia Mirkin
2021-02-27 12:28                                   ` [Nouveau] " Uwe Sauter
2021-02-27 21:26                                     ` Ilia Mirkin
2021-02-28 15:10                                       ` Uwe Sauter
2021-02-28 17:02                                         ` Ilia Mirkin
2021-02-28 17:59                                           ` Uwe Sauter
2021-02-28 19:10                                             ` Ilia Mirkin
2021-02-28 19:24                                               ` Uwe Sauter
2021-02-28 20:38                                                 ` Ilia Mirkin
2021-03-03 12:41                                       ` Alex Riesen
2021-03-03 13:12                                         ` Ilia Mirkin
2021-03-03 13:25                                           ` Uwe Sauter
2021-03-03 13:33                                             ` Ilia Mirkin
2021-03-03 17:02                                               ` Uwe Sauter
2021-03-03 17:11                                                 ` Lyude Paul
2021-03-03 16:51                                           ` Lyude Paul
2021-03-03 17:05                                             ` James Jones
2021-01-19  1:54   ` [PATCH 3/3] drm/nouveau/kms/nve4-nv138: Fix > 64x64 cursors Lyude Paul
2021-01-19  1:54     ` Lyude Paul
2021-01-19  1:54     ` Lyude Paul
2021-01-19 10:18   ` [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Simon Ser
2021-01-19 10:18     ` Simon Ser
2021-01-19 10:18     ` Simon Ser
2021-01-19 15:50   ` Ville Syrjälä
2021-01-19 15:50     ` Ville Syrjälä
2021-01-19 15:50     ` Ville Syrjälä
2021-01-19 15:52   ` James Jones
2021-01-19 15:52     ` James Jones
2021-01-19 15:52     ` James Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDaAQts9LIb5h3xd@pflmari \
    --to=alexander.riesen@cetitec.com \
    --cc=airlied@redhat.com \
    --cc=bskeggs@redhat.com \
    --cc=contact@emersion.fr \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imirkin@alum.mit.edu \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.