All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Syed Nayyar Waris <syednwaris@gmail.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Robert Richter <rrichter@marvell.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Zhang, Rui" <rui.zhang@intel.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amit.kucheria@verdurent.com>,
	Linux-Arch <linux-arch@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value
Date: Sat, 27 Mar 2021 21:02:04 +0900	[thread overview]
Message-ID: <YF8evJTkiBYjnDON@shinobu> (raw)
In-Reply-To: <CAHp75VfDZbJjCOEGdHc=-D6W8_7m2=CinXj-itwn6hvoVqdWYQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

On Sat, Mar 27, 2021 at 09:29:26AM +0200, Andy Shevchenko wrote:
> On Saturday, March 27, 2021, Syed Nayyar Waris <syednwaris@gmail.com> wrote:
> 
> > On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > >
> > > On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris <syednwaris@gmail.com>
> > wrote:
> > >
> > > > +       bitmap_set_value(old, 64, state[0], 32, 0);
> > > > +       bitmap_set_value(old, 64, state[1], 32, 32);
> > >
> > > Isn't it effectively bitnap_from_arr32() ?
> > >
> > > > +       bitmap_set_value(new, 64, state[0], 32, 0);
> > > > +       bitmap_set_value(new, 64, state[1], 32, 32);
> > >
> > > Ditto.
> > >
> > > --
> > > With Best Regards,
> > > Andy Shevchenko
> >
> > Hi Andy,
> >
> > With bitmap_set_value() we are also specifying the offset (or start)
> > position too. so that the remainder of the array remains unaffected. I
> > think it would not be feasible to use bitmap_from/to_arr32()  here.
> 
> 
> You have hard coded start and nbits parameters to 32. How is it not the
> same?

Would these four lines become something like this:

	bitmap_from_arr32(old, state, 64);
	...
	bitmap_from_arr32(new, state, 64);

Sincerely,

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Syed Nayyar Waris <syednwaris@gmail.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Robert Richter <rrichter@marvell.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Zhang, Rui" <rui.zhang@intel.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amit.kucheria@verdurent.com>,
	Linux-Arch <linux-arch@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value
Date: Sat, 27 Mar 2021 21:02:04 +0900	[thread overview]
Message-ID: <YF8evJTkiBYjnDON@shinobu> (raw)
In-Reply-To: <CAHp75VfDZbJjCOEGdHc=-D6W8_7m2=CinXj-itwn6hvoVqdWYQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1261 bytes --]

On Sat, Mar 27, 2021 at 09:29:26AM +0200, Andy Shevchenko wrote:
> On Saturday, March 27, 2021, Syed Nayyar Waris <syednwaris@gmail.com> wrote:
> 
> > On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > >
> > > On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris <syednwaris@gmail.com>
> > wrote:
> > >
> > > > +       bitmap_set_value(old, 64, state[0], 32, 0);
> > > > +       bitmap_set_value(old, 64, state[1], 32, 32);
> > >
> > > Isn't it effectively bitnap_from_arr32() ?
> > >
> > > > +       bitmap_set_value(new, 64, state[0], 32, 0);
> > > > +       bitmap_set_value(new, 64, state[1], 32, 32);
> > >
> > > Ditto.
> > >
> > > --
> > > With Best Regards,
> > > Andy Shevchenko
> >
> > Hi Andy,
> >
> > With bitmap_set_value() we are also specifying the offset (or start)
> > position too. so that the remainder of the array remains unaffected. I
> > think it would not be feasible to use bitmap_from/to_arr32()  here.
> 
> 
> You have hard coded start and nbits parameters to 32. How is it not the
> same?

Would these four lines become something like this:

	bitmap_from_arr32(old, state, 64);
	...
	bitmap_from_arr32(new, state, 64);

Sincerely,

William Breathitt Gray

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-03-27 12:02 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06 14:01 [PATCH v3 0/3] Introduce the for_each_set_nbits macro Syed Nayyar Waris
2021-03-06 14:01 ` Syed Nayyar Waris
2021-03-06 14:03 ` [PATCH v3 1/3] gpiolib: " Syed Nayyar Waris
2021-03-06 14:03   ` Syed Nayyar Waris
2021-03-06 14:05 ` [PATCH v3 2/3] gpio: thunderx: Utilize " Syed Nayyar Waris
2021-03-06 14:05   ` Syed Nayyar Waris
2021-03-06 14:06 ` [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value Syed Nayyar Waris
2021-03-06 14:06   ` Syed Nayyar Waris
2021-03-08  7:13   ` Michal Simek
2021-03-08  7:13     ` Michal Simek
2021-03-26 17:27     ` Bartosz Golaszewski
2021-03-26 17:27       ` Bartosz Golaszewski
2021-03-31 15:26       ` Srinivas Neeli
2021-03-31 15:26         ` Srinivas Neeli
2021-04-01 11:15         ` Syed Nayyar Waris
2021-04-01 11:15           ` Syed Nayyar Waris
2021-04-01 12:51           ` Bartosz Golaszewski
2021-04-01 12:51             ` Bartosz Golaszewski
2021-03-26 17:57   ` Andy Shevchenko
2021-03-26 17:57     ` Andy Shevchenko
2021-04-02  9:40     ` Syed Nayyar Waris
2021-04-02  9:40       ` Syed Nayyar Waris
2021-03-26 18:02   ` Andy Shevchenko
2021-03-26 18:02     ` Andy Shevchenko
2021-03-26 22:12     ` Syed Nayyar Waris
2021-03-26 22:12       ` Syed Nayyar Waris
     [not found]       ` <CAHp75VfDZbJjCOEGdHc=-D6W8_7m2=CinXj-itwn6hvoVqdWYQ@mail.gmail.com>
2021-03-27 12:02         ` William Breathitt Gray [this message]
2021-03-27 12:02           ` William Breathitt Gray
2021-03-27 16:35           ` Andy Shevchenko
2021-03-27 16:35             ` Andy Shevchenko
2021-04-01 17:50             ` Syed Nayyar Waris
2021-04-01 17:50               ` Syed Nayyar Waris
2021-03-29 15:24   ` Andy Shevchenko
2021-03-29 15:24     ` Andy Shevchenko
2021-04-01 17:47     ` Syed Nayyar Waris
2021-04-01 17:47       ` Syed Nayyar Waris
2021-04-02 10:07     ` Syed Nayyar Waris
2021-04-02 10:07       ` Syed Nayyar Waris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YF8evJTkiBYjnDON@shinobu \
    --to=vilhelm.gray@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit.kucheria@verdurent.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=rrichter@marvell.com \
    --cc=rui.zhang@intel.com \
    --cc=syednwaris@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.