All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: iommu@lists.linux-foundation.org, Jon.Grimm@amd.com,
	linux-kernel@vger.kernel.org, Wei.Huang2@amd.com
Subject: Re: [RFC PATCH 7/7] iommu/amd: Add support for using AMD IOMMU v2 page table for DMA-API
Date: Thu, 18 Mar 2021 16:44:49 +0100	[thread overview]
Message-ID: <YFN1cdOrH7v81CJt@8bytes.org> (raw)
In-Reply-To: <20210312090411.6030-8-suravee.suthikulpanit@amd.com>

On Fri, Mar 12, 2021 at 03:04:11AM -0600, Suravee Suthikulpanit wrote:
> Introduce init function for setting up DMA domain for DMA-API with
> the IOMMU v2 page table.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
>  drivers/iommu/amd/iommu.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index e29ece6e1e68..bd26de8764bd 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -1937,6 +1937,24 @@ static int protection_domain_init_v1(struct protection_domain *domain, int mode)
>  	return 0;
>  }
>  
> +static int protection_domain_init_v2(struct protection_domain *domain)
> +{
> +	spin_lock_init(&domain->lock);
> +	domain->id = domain_id_alloc();
> +	if (!domain->id)
> +		return -ENOMEM;
> +	INIT_LIST_HEAD(&domain->dev_list);
> +
> +	domain->giov = true;
> +
> +	if (amd_iommu_pgtable == AMD_IOMMU_V2 &&
> +	    domain_enable_v2(domain, 1, false)) {
> +		return -ENOMEM;
> +	}
> +
> +	return 0;
> +}
> +

You also need to advertise a different aperture size and a different
pgsize-bitmap. The host page-table can only map a 48 bit address space,
not a 64 bit one like with v1 page-tables.

Regards,

	Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Jon.Grimm@amd.com, Wei.Huang2@amd.com
Subject: Re: [RFC PATCH 7/7] iommu/amd: Add support for using AMD IOMMU v2 page table for DMA-API
Date: Thu, 18 Mar 2021 16:44:49 +0100	[thread overview]
Message-ID: <YFN1cdOrH7v81CJt@8bytes.org> (raw)
In-Reply-To: <20210312090411.6030-8-suravee.suthikulpanit@amd.com>

On Fri, Mar 12, 2021 at 03:04:11AM -0600, Suravee Suthikulpanit wrote:
> Introduce init function for setting up DMA domain for DMA-API with
> the IOMMU v2 page table.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
>  drivers/iommu/amd/iommu.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index e29ece6e1e68..bd26de8764bd 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -1937,6 +1937,24 @@ static int protection_domain_init_v1(struct protection_domain *domain, int mode)
>  	return 0;
>  }
>  
> +static int protection_domain_init_v2(struct protection_domain *domain)
> +{
> +	spin_lock_init(&domain->lock);
> +	domain->id = domain_id_alloc();
> +	if (!domain->id)
> +		return -ENOMEM;
> +	INIT_LIST_HEAD(&domain->dev_list);
> +
> +	domain->giov = true;
> +
> +	if (amd_iommu_pgtable == AMD_IOMMU_V2 &&
> +	    domain_enable_v2(domain, 1, false)) {
> +		return -ENOMEM;
> +	}
> +
> +	return 0;
> +}
> +

You also need to advertise a different aperture size and a different
pgsize-bitmap. The host page-table can only map a 48 bit address space,
not a 64 bit one like with v1 page-tables.

Regards,

	Joerg

  reply	other threads:[~2021-03-18 15:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  9:04 [RFC PATCH 0/7] iommu/amd: Add Generic IO Page Table Framework Support for v2 Page Table Suravee Suthikulpanit
2021-03-12  9:04 ` Suravee Suthikulpanit
2021-03-12  9:04 ` [RFC PATCH 1/7] iommu/amd: Refactor amd_iommu_domain_enable_v2 Suravee Suthikulpanit
2021-03-12  9:04   ` Suravee Suthikulpanit
2021-03-12  9:04 ` [RFC PATCH 2/7] iommu/amd: Update sanity check when enable PRI/ATS Suravee Suthikulpanit
2021-03-12  9:04   ` Suravee Suthikulpanit
2021-03-12  9:04 ` [RFC PATCH 3/7] iommu/amd: Decouple the logic to enable PPR and GT Suravee Suthikulpanit
2021-03-12  9:04   ` Suravee Suthikulpanit
2021-03-12  9:04 ` [RFC PATCH 4/7] iommu/amd: Initial support for AMD IOMMU v2 page table Suravee Suthikulpanit
2021-03-12  9:04   ` Suravee Suthikulpanit
2021-03-18 15:28   ` Joerg Roedel
2021-03-18 15:28     ` Joerg Roedel
2021-03-12  9:04 ` [RFC PATCH 5/7] iommu/amd: Add support for Guest IO protection Suravee Suthikulpanit
2021-03-12  9:04   ` Suravee Suthikulpanit
2021-03-18 15:31   ` Joerg Roedel
2021-03-18 15:31     ` Joerg Roedel
2021-03-25 13:06     ` Suravee Suthikulpanit
2021-03-25 13:06       ` Suravee Suthikulpanit
2021-03-12  9:04 ` [RFC PATCH 6/7] iommu/amd: Introduce amd_iommu_pgtable command-line option Suravee Suthikulpanit
2021-03-12  9:04   ` Suravee Suthikulpanit
2021-03-18 15:33   ` Joerg Roedel
2021-03-18 15:33     ` Joerg Roedel
2021-03-22  4:24     ` Suravee Suthikulpanit
2021-03-22  4:24       ` Suravee Suthikulpanit
2021-03-12  9:04 ` [RFC PATCH 7/7] iommu/amd: Add support for using AMD IOMMU v2 page table for DMA-API Suravee Suthikulpanit
2021-03-12  9:04   ` Suravee Suthikulpanit
2021-03-18 15:44   ` Joerg Roedel [this message]
2021-03-18 15:44     ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFN1cdOrH7v81CJt@8bytes.org \
    --to=joro@8bytes.org \
    --cc=Jon.Grimm@amd.com \
    --cc=Wei.Huang2@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suravee.suthikulpanit@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.